Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jul 29 2020 01:16
  • Jul 22 2020 07:07
  • Jul 22 2020 07:07
    Travis kseo/codechain-rpc-js (license) passed (1)
  • Mar 20 2020 06:28
    MSNTCS opened #1962
  • Mar 20 2020 06:27
    MSNTCS commented #1961
  • Mar 20 2020 06:25
    MSNTCS closed #1961
  • Mar 19 2020 08:02
    MSNTCS review_requested #1961
  • Mar 19 2020 08:02
    MSNTCS opened #1961
  • Mar 03 2020 02:37
    ScarletBlue edited #1948
  • Mar 03 2020 02:37
    ScarletBlue edited #1931
  • Mar 02 2020 00:41
    ScarletBlue edited #1915
  • Mar 02 2020 00:41
    ScarletBlue edited #1915
  • Feb 27 2020 00:09
    sgkim126 closed #1959
  • Feb 27 2020 00:09

    sgkim126 on master

    Bug fix in on_request_commit_me… (compare)

  • Feb 25 2020 09:41
    majecty labeled #1960
  • Feb 25 2020 09:41
    majecty opened #1960
  • Feb 17 2020 02:10
    majecty commented #1959
  • Feb 14 2020 23:13
    sgkim126 review_requested #1959
  • Feb 14 2020 23:13
    sgkim126 review_requested #1959
  • Feb 14 2020 23:13
    sgkim126 opened #1959
Park Juhyung
@majecty
@sgkim126 When are you available? I need your help to implement code generating/verifying Merkle proof.
Joonmo Yang
@Remagpie

Current DEX protocols have solved problems wrt to the risk of accidentally losing users custody due to security breaches. But two big issues remain unsolved. 1) centralized listing/delisting processes and 2) front-running issues due to the decentralized and transparent nature.

I and @joojis designed a new protocol, named CodeChain DEX protocol, that solves both of these problems. CodeChain DEX has a delegation system that encourages stakeholders to list assets that are in great demand and delist assets that are in poor demand. In addition, CodeChain DEX adopts time-release cryptography and ID-based encryption to prevent front-running attacks. Our commit-reveal scheme does not require any interaction between the participants, allowing traders to send orders non-interactively to the network.

Here is the link for the proposal we've written. We're open to new suggestions and ideas. https://research.codechain.io/t/codechain-dex-protocol/30

GeunWoo Kim
@GNUp
@foriequal0 Pls review this PR CodeChain-io/codechain-sdk-python#32
@majecty As I remember correctly, I also implemented some code generating the merkle proof for the purpose of debugging.
Park Juhyung
@majecty
@GNUp Wow. Could you share the code?
Joonmo Yang
@Remagpie
I wrote three proposals for opcodes required for implementing Vault language. Please have a look and give some feedback:
https://research.codechain.io/t/integer-opcodes/32
https://research.codechain.io/t/stack-rotation-opcodes/33
https://research.codechain.io/t/script-based-timelock/34
@sgkim126 ^
Seulgi Kim
@sgkim126
@Remagpie Okay. I'll check it.
GeunWoo Kim
@GNUp
@foriequal0 I resolved your comments on this PR CodeChain-io/codechain-sdk-python#28
GeunWoo Kim
@GNUp
GeunWoo Kim
@GNUp
@foriequal0 I got this errors after merging this PR CodeChain-io/codechain-sdk-python#31. I add a commit fixing this to here CodeChain-io/codechain-sdk-python#28
_______________________________________________ test_from_string_mutisig _______________________________________________

    def test_from_string_mutisig():
        address = AssetAddress.from_string(
>           "tcaqypsyqg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyfzyg3zyg3zyg3zyg3zyg3zyg3zyg3zygsn28hf0"
        )

tests/test_AssetAddress.py:61:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
codechain/primitives/AssetAddress.py:80: in from_string
    return AssetAddress(address_type, MultiSig(n, m, pubkeys), address)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <codechain.primitives.AssetAddress.AssetAddress object at 0x7f012617fe48>, address_type = 3
payload = MultiSig(n=2, m=1, pubkeys=[b'\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11', b'""""""""""""""""""""'])
address = 'tcaqypsyqg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyfzyg3zyg3zyg3zyg3zyg3zyg3zyg3zygsn28hf0'

    def __init__(
        self, address_type: int, payload: Union[H160, str, MultiSig], address: str
    ):
        self.address_type = address_type

        if isinstance(payload, (H160, str)):
            self.payload = H160(payload)
        else:
>           n, m, pubkeys = payload
E           TypeError: 'MultiSig' object is not iterable

codechain/primitives/AssetAddress.py:27: TypeError
__________________________________________ test_from_type_and_payload_mutisig __________________________________________

    def test_from_type_and_payload_mutisig():
        sig = MultiSig(
            2,
            1,
            [
                H160("1111111111111111111111111111111111111111"),
                H160("2222222222222222222222222222222222222222"),
            ],
        )
        address1 = AssetAddress.from_string(
>           "tcaqypsyqg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyfzyg3zyg3zyg3zyg3zyg3zyg3zyg3zygsn28hf0"
        )

tests/test_AssetAddress.py:87:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
codechain/primitives/AssetAddress.py:80: in from_string
    return AssetAddress(address_type, MultiSig(n, m, pubkeys), address)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <codechain.primitives.AssetAddress.AssetAddress object at 0x7f01263df4e0>, address_type = 3
payload = MultiSig(n=2, m=1, pubkeys=[b'\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11', b'""""""""""""""""""""'])
address = 'tcaqypsyqg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyfzyg3zyg3zyg3zyg3zyg3zyg3zyg3zygsn28hf0'

    def __init__(
        self, address_type: int, payload: Union[H160, str, MultiSig], address: str
    ):
        self.address_type = address_type

        if isinstance(payload, (H160, str)):
            self.payload = H160(payload)
        else:
>           n, m, pubkeys = payload
E           TypeError: 'MultiSig' object is not iterable

codechain/primitives/AssetAddress.py:27: TypeError
Joonmo Yang
@Remagpie
I'm working on snapshot synchronization, and currently I'm checking the entire codebase to make sure that CodeChain works even if there are missing blocks/headers in the database.
It's such an hard and tedious work, so it'd be nice if someone let me know the parts that I can skip checking.
Please let me know if you have any information :)
Park Juhyung
@majecty
@GNUp Thank you!
GeunWoo Kim
@GNUp
@foriequal0 Both PR here https://github.com/CodeChain-io/codechain-sdk-python/pulls are ready to be merged.
JinGyeong Jeong
@joojis
Warning: Unknown configuration option `fn_args_layout`
Is this happening only for me?
I see. I should update the rustfmt version to 2019-10-13.
JinGyeong Jeong
@joojis
Kwang Yul Seo
@kseo
Seulgi Kim
@sgkim126
@kseo I'll update toolchains. We don't need the new features yet, but I think we will need async/await soon.
Kwang Yul Seo
@kseo
@sgkim126 okay!
Kwang Yul Seo
@kseo
the rust team published an article on async/await :)
https://blog.rust-lang.org/2019/11/07/Async-await-stable.html
Seulgi Kim
@sgkim126
@/all CodeChain-io/codechain#1850 This PR upgrades rust, rustfmt, clippy, node and typescript.
JinGyeong Jeong
@joojis
GeunWoo Kim
@GNUp
@foriequal0 CodeChain-io/codechain-sdk-python#43 this PR is ready for review
SeongChan Lee
@foriequal0
@GNUp Okay I’ll check that
SeongChan Lee
@foriequal0
Park Juhyung
@majecty
👍
JinGyeong Jeong
@joojis
:thumbsup:
GeunWoo Kim
@GNUp
@foriequal0 I resolved your comments here. CodeChain-io/codechain-sdk-python#43
GeunWoo Kim
@GNUp
@foriequal0 pls check this PR CodeChain-io/codechain-sdk-python#48
GeunWoo Kim
@GNUp
@foriequal0 I resolved your comment. CodeChain-io/codechain-sdk-python#48
Park Juhyung
@majecty
@Remagpie You can find the private key used in CodeChain integration tests here.
CodeChainRepo/test/src/helper/constants.ts
Joonmo Yang
@Remagpie
Thx!
GeunWoo Kim
@GNUp
@foriequal0 I resolved your comments here CodeChain-io/codechain-sdk-python#48
GeunWoo Kim
@GNUp
and pls review this PR CodeChain-io/codechain-sdk-python#49
GeunWoo Kim
@GNUp
@foriequal0 I resolved your comment here CodeChain-io/codechain-sdk-python#49
Seulgi Kim
@sgkim126
@HoOngEe CodeChain-io/codechain#1870 is waiting for your review.
Seonpyo Kim
@HoOngEe
@sgkim126 Sorry for the late check, I'm going to review it from now.
GeunWoo Kim
@GNUp
@foriequal0 I resolved your comment. CodeChain-io/codechain-sdk-python#49
Joonmo Yang
@Remagpie
@sgkim126 Could you check the comment in CodeChain-io/codechain#1873 ?
GeunWoo Kim
@GNUp
@foriequal0 pls review this PR. CodeChain-io/codechain-sdk-python#53
Seulgi Kim
@sgkim126
@Remagpie I commented.
Joonmo Yang
@Remagpie
Thx. I applied the suggestion.
Kwang Yul Seo
@kseo
@sgkim126 what’s this issue about? would you describe more?
CodeChain-io/codechain#1064
Seulgi Kim
@sgkim126
@kseo updated
I'll try to make e2e tests stable. It fails too much now.
Kwang Yul Seo
@kseo
@sgkim126 sounds good. please share the root cause of the flakyness before you start fixing it
Kwang Yul Seo
@kseo
@sgkim126 let’s discuss this issue next week. please take a look at it
CodeChain-io/codechain#1884
Seulgi Kim
@sgkim126
@kseo Okay