@majecty The parts you touched are not related to my parts. I think only Cargo.lock will conflict.
@sgkim126 What do you think about running
We are using
https://doc.rust-lang.org/edition-guide/rust-2018/module-system/path-clarity.html#no-more-extern-crate
cargo fix --edition-idioms in the foundry project?We are using
extern crate in many cases, but from the 2018 edition, we don't need it in most cases.https://doc.rust-lang.org/edition-guide/rust-2018/module-system/path-clarity.html#no-more-extern-crate
I'm considering not to remove MintAsset instead of a new dummy transaction.
The "ShardStore" transaction saves arbitrary data in shards.
Our check_shard_level_state macro is an excellent point to study Rust macro. I understood how to use the macro by reading it.
https://github.com/CodeChain-io/foundry/blob/master/state/src/impls/test_helper.rs#L558
I'll do CodeChain-io/foundry#21, CodeChain-io/foundry#14 would be better doing after snapshot refactoring.
Hi @majecty and @kseo, While I'm reviewing and writing commits, I found that the current coding style about importing order is easy to make a mistake. https://github.com/CodeChain-io/codechain/wiki/Coding-Style Currently, we split imports into 3 groups that are systems, other packages, and self modules, and sorting them in a group, but there are no formatting tools that group imports according to prefixes.
So we split the groups with a blank line, but we should take care of whether they are grouped as intended; it's easy to make a mistake.
I suggest to remove groups and make all imports ordered alphabetically. AFAIK, rust compilation doesn't affect by the importing order; therefore, it will not make a problem.
I think we should change our practice to use
sendRpcRequest function in our e2e tests so that no SDK publish is required.
also this one
CodeChain-io/foundry#35
CodeChain-io/foundry#35
CodeChain-io/foundry#12 is waiting for CodeChain-io/foundry#11. I'll review CodeChain-io/foundry#35 now.
@sgkim126 I updated the CodeChain-io/foundry#12 PR.
Since the PR is created in the remagpie's branch, I cannot update PR.
Should I close the PR and re-create it?
Since the PR is created in the remagpie's branch, I cannot update PR.
Should I close the PR and re-create it?
^ I sent a new PR CodeChain-io/foundry#120
It is funny that the new PR's number = 120 = 10 * the previous PR's number.
It is funny that the new PR's number = 120 = 10 * the previous PR's number.
I'll import CodeChain's ICS implementation PR to Foundry.
CodeChain-io/codechain#1849
CodeChain-io/codechain#1849
The previous ics-poc was using the custom action handler. Since Seulgi will remove custom action soon, I'll migrate custom actions to normal transaction types.
