sgkim126 on master
Bug fix in on_request_commit_me… (compare)
Anyone know about history of parameter names in execute method of ActionHandler trait?
I think the name 'fee_payer' makes it hard to understand. The address can be read as fee payer for money transfer, but I think it should be 'deposit_owner' in self nomination and 'informant' in double vote reporting.
Does the fee_payer actually pay fee? If not, I will make a PR to change its name to more understandable one, such as 'sender_address'.
Let me summarize. You need decode and fromWord functions in the Foundry tests. So, you want to use the recent version of codechain-primitive-js in Foundry test code.
It looks good to me. Go ahead.
Yes, I need to add some exports in
Index.ts. Do I need to change the version of the package and publish another version? or use a branch in my fork repository?