by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 20 06:28
    MSNTCS opened #1962
  • Mar 20 06:27
    MSNTCS commented #1961
  • Mar 20 06:25
    MSNTCS closed #1961
  • Mar 19 08:02
    MSNTCS review_requested #1961
  • Mar 19 08:02
    MSNTCS opened #1961
  • Mar 03 02:37
    ScarletBlue edited #1948
  • Mar 03 02:37
    ScarletBlue edited #1931
  • Mar 02 00:41
    ScarletBlue edited #1915
  • Mar 02 00:41
    ScarletBlue edited #1915
  • Feb 27 00:09
    sgkim126 closed #1959
  • Feb 27 00:09

    sgkim126 on master

    Bug fix in on_request_commit_me… (compare)

  • Feb 25 09:41
    majecty labeled #1960
  • Feb 25 09:41
    majecty opened #1960
  • Feb 17 02:10
    majecty commented #1959
  • Feb 14 23:13
    sgkim126 review_requested #1959
  • Feb 14 23:13
    sgkim126 review_requested #1959
  • Feb 14 23:13
    sgkim126 opened #1959
  • Feb 14 23:13
    sgkim126 labeled #1959
  • Feb 14 06:30
    majecty closed #1911
  • Feb 14 06:30
    majecty commented #1911
Park Juhyung
@majecty
@MSNTCS OK.
@junha1 I think it is not a good time to do it. Since our team is modifying a lot of foundry code, it can change many RPCs. Let's do it after Foundry is stabilized.
junha1
@junha1
Ok
Park Juhyung
@majecty
It seems that there is a bug in the RlpEncodable and RlpDecodable macro.
junha1
@junha1
How?
Park Juhyung
@majecty
When I used the two proc macro in a struct, It failed to pass rlp_encode_and_decode_test test. I'm figuring out it now.
Mohammadsadegh Najafi
@MSNTCS
@majecty error Incorrect hash when fetching from the cache for foundry-rpc. I cannot find the source of problem.
Park Juhyung
@majecty
@MSNTCS I'll check it now.
Mohammadsadegh Najafi
@MSNTCS
@majecty thanks
Park Juhyung
@majecty
@MSNTCS Could you try again after removing this line?
https://github.com/CodeChain-io/foundry/blob/b20fe1304b35efffd363e13db8157848c77f3216/.travis.yml#L98
It seems that Travis' cache is not working well.
Mohammadsadegh Najafi
@MSNTCS
Alright
Should I remove it and push it as changes in PR?
Park Juhyung
@majecty
Yes. Create a new commit for it, and include it in your PR.
I found that we can remove cache in Travis. I'll try it.
Park Juhyung
@majecty

When I used the two proc macro in a struct, It failed to pass rlp_encode_and_decode_test test. I'm figuring out it now.

It was my fault. 😭

junha1
@junha1
What was the reason? I'm curious about that
Park Juhyung
@majecty
I used append instead of append_single_value
junha1
@junha1
I'll remove foundry directory and kind for that. This poc is not considered to support other chain. @majecty
Park Juhyung
@majecty
OK.
Mohammadsadegh Najafi
@MSNTCS
@majecty I think, I have to update codechain-primitives to use some of its function like decode, fromWord. What is your idea?
junha1
@junha1
To 0.2?
Park Juhyung
@majecty
@MSNTCS Do you mean codechain-primitives-js or rust-codechain-primitives?
Mohammadsadegh Najafi
@MSNTCS
@majecty codechain-primitives-js
Park Juhyung
@majecty
Let me summarize. You need decode and fromWord functions in the Foundry tests. So, you want to use the recent version of codechain-primitive-js in Foundry test code.
It looks good to me. Go ahead.
@Byeongjee Could you give the link to the code you showed me before?
Mohammadsadegh Najafi
@MSNTCS

Let me summarize. You need decode and fromWord functions in the Foundry tests. So, you want to use the recent version of codechain-primitive-js in Foundry test code.
It looks good to me. Go ahead.

Yes, I need to add some exports in Index.ts. Do I need to change the version of the package and publish another version? or use a branch in my fork repository?

Byeongjee Kang
@Byeongjee
@majecty https://github.com/Byeongjee/rust-codechain-primitives/blob/master/src/hash.rs This is my implementation of serde, and other types are declared in ethereum-types package https://docs.rs/crate/ethereum-types/0.4.0/source/src/hash.rs . I copy-and-pasted impl_serde macro from ethereum-types to rust-codechain-primitives, so that may cause the error, but I'm not sure.
junha1
@junha1
Can I have a definition of action_data in general? It confuses me..
Park Juhyung
@majecty
@junha1 action_data is used by custom action, which will be removed soon by Seulgi.
junha1
@junha1
Ah thanks. It appears in many places.
And I think there should be make_proof() in TopLevelState. Is it ok to make one?
Park Juhyung
@majecty
@Byeongjee Your code is using cfg(feature = "serialize")
I'm suspecting that it is the cause of your problem. Since you did not give feature="serialize" when you use the crate, the code is not generated.
https://doc.rust-lang.org/1.9.0/book/conditional-compilation.html
Byeongjee Kang
@Byeongjee
action_data will be removed?
Mohammadsadegh Najafi
@MSNTCS

Let me summarize. You need decode and fromWord functions in the Foundry tests. So, you want to use the recent version of codechain-primitive-js in Foundry test code.
It looks good to me. Go ahead.

Yes, I need to add some exports in Index.ts. Do I need to change the version of the package and publish another version? or use a branch in my fork repository?

@majecty

Park Juhyung
@majecty

@Byeongjee @junha1
The ActionData is used by custom transactions. We used the custom transaction to introduce transactions that optionally enabled by consensus engine.
We are using it for the stake module. Transactions related stake is enabled only in the solo and Tendermint consensus.
Since Foundry has a module system, we don't need an optionable transaction type. Seulgi is removing custom transactions.

https://github.com/CodeChain-io/foundry/blob/b20fe1304b35efffd363e13db8157848c77f3216/state/src/item/action_data.rs

@junha1

And I think there should be make_proof() in TopLevelState. Is it ok to make one?

Yes, Looks good to me.

@MSNTCS

Yes, I need to add some exports in Index.ts. Do I need to change the version of the package and publish another version? or use a branch in my fork repository?

Since we will copy whole SDK things to Foundry, please do not modify them. Let's use a copied version of it.

Park Juhyung
@majecty

@junha1

And I think there should be make_proof() in TopLevelState. Is it ok to make one?

Also, please share the code that has interface first before you modifying many code places.

junha1
@junha1
ok
SeungMin Lee
@somniumism
I'm working on removing the score, and I'm trying to modify e2e tests. But I don't know exactly which part to correct, and the following error occurred:
Error: Expected chain_getBlock to return either null or JSON of Block, but an error occurred: Error: U256 must be a positive integer but found undefined
@majecty Could you give me some advice?
junha1
@junha1
Have you updated all definitions of headers?
It exists in codechain-sdk-js too.
SeungMin Lee
@somniumism
I'll check it.
SeungMin Lee
@somniumism
So there is a dependency between codechain-sdk-js with the score and e2e tests I modified, which leads to an error. Am I right?
Then, in order to run e2e tests in the case without the score, I have to modify the codechain-sdk-js like you?
junha1
@junha1
Just follow exactly same steps I've done after my PR gets merged.
SeungMin Lee
@somniumism
Alright, Thank you : )
Park Juhyung
@majecty
@somniumism, it seems that you modified the header struct. Since other people are changing it, let's delay removing the real "score" field. Let's remove it after other PRs are landed.
SeungMin Lee
@somniumism
Ok! I'll push commits that only removes the logic related to the score and make a new issue!