sgkim126 on master
Bug fix in on_request_commit_me… (compare)
Let me summarize. You need decode and fromWord functions in the Foundry tests. So, you want to use the recent version of codechain-primitive-js in Foundry test code.
It looks good to me. Go ahead.
Yes, I need to add some exports in Index.ts
. Do I need to change the version of the package and publish another version? or use a branch in my fork repository?
make_proof()
in TopLevelState
. Is it ok to make one?
cfg(feature = "serialize")
feature="serialize"
when you use the crate, the code is not generated.Let me summarize. You need decode and fromWord functions in the Foundry tests. So, you want to use the recent version of codechain-primitive-js in Foundry test code.
It looks good to me. Go ahead.Yes, I need to add some exports in
Index.ts
. Do I need to change the version of the package and publish another version? or use a branch in my fork repository?
@majecty
@Byeongjee @junha1
The ActionData
is used by custom transactions. We used the custom transaction to introduce transactions that optionally enabled by consensus engine.
We are using it for the stake module. Transactions related stake is enabled only in the solo and Tendermint consensus.
Since Foundry has a module system, we don't need an optionable transaction type. Seulgi is removing custom transactions.
@junha1
And I think there should be
make_proof()
inTopLevelState
. Is it ok to make one?
Yes, Looks good to me.
@MSNTCS
Yes, I need to add some exports in
Index.ts
. Do I need to change the version of the package and publish another version? or use a branch in my fork repository?
Since we will copy whole SDK things to Foundry, please do not modify them. Let's use a copied version of it.
Error: Expected chain_getBlock to return either null or JSON of Block, but an error occurred: Error: U256 must be a positive integer but found undefined