by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
junha1
@junha1
What's our plan on ICS 05 port allocation? @majecty
5 replies
Byeongjee Kang
@Byeongjee
Should I use BLSPublic or BlsPublic? What is our convention?
5 replies
junha1
@junha1
junha1
@junha1
@majecty I want to have a discussion with you about things I've asked today + channel implementation + KV store interface
junha1
@junha1
fn get_opt(&self, path: Path) -> Option<Bytes>;
fn set_opt(&self, path: Path, value: &[u8]) -> Option<Bytes>;
fn delete_opt(&self, path: Path) ->Option<Bytes>;
How about this? @majecty
7 replies
Mohammadsadegh Najafi
@MSNTCS
@majecty can we have a shrt discussion?
Mohammadsadegh Najafi
@MSNTCS
@majecty I think I need size limit to get future transaction and current. Therefor, I use the usize:max_value()
Seulgi Kim
@sgkim126
@/all I upgraded rust toolchains. https://github.com/CodeChain-io/foundry/pull/198/commits/2b686af560e4df93ac964f6f43e89c45205c36ec Please upgrade rustfmt and clippy.
5 replies
Park Juhyung
@majecty
@MSNTCS
Could you add more description in issue #207 ?
Please add the information below in the issue:
  • mempool_getPendingTransactions RPC is not returning whole pending transactions
  • mempool_getPendingTransactions RPC is using ready_transactions method that is used to create a block.
  • ready_transactions returns transactions that can be included in a block.
2 replies
SeungMin Lee
@somniumism
@HoOngEe I added tests that verify the result form my implementation like testing oracles and modified some codes. Could you check CodeChain-io/foundry-primitives-js#1?
Mohammadsadegh Najafi
@MSNTCS
@majecty when we can have a somehow long discussion?
Park Juhyung
@majecty
2 replies
@MSNTCS We can use "Notification" in JSONRPC spec to send streaming events: https://www.jsonrpc.org/specification#notification
1 reply
Park Juhyung
@majecty
Ethereum Go implementation is using websocket to streaming events: https://geth.ethereum.org/docs/rpc/pubsub
2 replies
Park Juhyung
@majecty
@MSNTCS You can try websocket server and client using ws library. https://github.com/websockets/ws
Park Juhyung
@majecty
@somniumism Here is an example snippet that handles internal library that needs an async initialization: https://repl.it/@majecty/Async-outer-init
Park Juhyung
@majecty
Park Juhyung
@majecty
I'm adding an IBC transaction type in typescript. I'm not familiar with that part of SDK. I hope it will be an easy job.
Byeongjee Kang
@Byeongjee
FYI, I’m fixing the curve point decoding problem as follows, based on yesterday’s discussion with @majecty , @junha1, and @HoOngEe .
  • Signature should be stored in bytes form
    • because each signature will be verified only once
  • There will be two types
    • BlsPublicUnverified type has serde, rlp traits
    • BlsPublic type has all verification-related methods
  • At self-nomination step, convert BlsPublicUnverified into BlsPublic after verification
    • every Candidate and Validator must hold BlsPublic, not BlsPublicUnverified
  • Conversion from BlsPublicUnverifiedto BlsPublic occurs at self-nomination step
  • When decoding genesis state from initial configuration file, it should directly decode BlsPublic from string. Error at this step should be treated as a decoding error
    • This part is not pretty, but it is hard to find a nice place to convert from BlsPublicUnverified into BlsPublicVerified
5 replies
Park Juhyung
@majecty
@HoOngEe I found that CodeChain SDK is using Typedoc.
https://typedoc.org/guides/installation/
1 reply
SeungMin Lee
@somniumism
@/all I’m working on replacing ECDSA with Ed25519 in foundry-primitives-js, and I completed the implementation. However, if this implementation is applied, all functions related to crypto and key that are being used by the foundry-keystone-js as well as the foundry e2e test should be changed. Of course, it will not have a significant impact on the overall system, but it will be a big work. I want to know your opinion. Could you check this comment?
Mohammadsadegh Najafi
@MSNTCS
I am going to provide a document for informer API. The format of the document would be semilar to https://geth.ethereum.org/docs/rpc/pubsub
Mohammadsadegh Najafi
@MSNTCS
@majecty subscribtion API of geth use an id feature to store subscribtion data. We need the same structure. I would not include this in my document for now but I think we should have a discussion about it in the meeting or later you and me.
2 replies
Kwang Yul Seo
@kseo
@Byeongjee i’ve created experiment label. Would you add the label to your bls signature related issues and PRs?
2 replies
@junha1 @majecty would you add experiment label to the ics related issues and PRs too?
3 replies
Park Juhyung
@majecty
@MSNTCS Please tell me when your PR is ready for a review: CodeChain-io/foundry#202
9 replies
Mohammadsadegh Najafi
@MSNTCS
@majecty here is the first draft of Informer API. Is not complete. In my point of view, it should be look like this, although I borrowed the structure of it from geth. Can you check it out and let me know whether it is the thing that you have in your mind or not? here is the link https://docs.google.com/document/d/1_ko0aialG78mrxJE_9N9ySnpNx4wtEexZnDdDM-kheE/edit
8 replies
Mohammadsadegh Najafi
@MSNTCS
@majecty While you are reviewing the doc I will review foundry/rpc.rs and rpc-server in foundry.
Park Juhyung
@majecty
I'll review "getPendingTransaction PR" CodeChain-io/foundry#202
4 replies
Park Juhyung
@majecty
@junha1 I found an interesting decision in the Tendermint team that you might be interested in.
https://github.com/tendermint/tendermint/issues/4470#issuecomment-590895503
The tendermint team decide not to save next validator set in the light client with the assumption: "most blockchains won't be changing their validator set often"
1 reply
SeungMin Lee
@somniumism
@HoOngEe I added a commit. Could you check it?
Mohammadsadegh Najafi
@MSNTCS
1 reply
junha1
@junha1
Please review CodeChain-io/foundry#210 @majecty
2 replies
junha1
@junha1
I'm implementing chanOpenAck()
Mohammadsadegh Najafi
@MSNTCS
@majecty can we have a discussion after your lunch regarding my next step?
3 replies
Park Juhyung
@majecty
I'm reviewing Junha's ICS channel PR: CodeChain-io/foundry#210
2 replies
Mohammadsadegh Najafi
@MSNTCS
Thanks to @majecty, I am going to sepnd my time to check whether the current RPC library that we use can support streaming API or not. If the library cannot support streaming API, I need to find another library
1 reply
Mohammadsadegh Najafi
@MSNTCS
@majecty do we need to take care of athuntication? becasue it might make a huge difference.
Byeongjee Kang
@Byeongjee

Anyone know about this warning in tendermint e2e test?

(node:64879) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'indexOf' of undefined
at Object.compatibleMessage
(/Users/byeongjee/foundry/test/node_modules/check-error/index.js:82:29)
at /Users/byeongjee/foundry/test/node_modules/chai-as-promised/lib/chai-as-promised.js:191:77
at runMicrotasks (<anonymous>)

13 replies
Park Juhyung
@majecty
@junha1 I reviewed your PR: CodeChain-io/foundry#210
Byeongjee Kang
@Byeongjee
@HoOngEe I think we should cherry-pick at least CodeChain-io/foundry@5ace355 into bls-consensus-signature branch. Using different formatting tool for two different branches is too annoying.
1 reply
junha1
@junha1
@majecty https://github.com/CodeChain-io/foundry/pull/210#discussion_r384923352 I'm not sure what to do when there is already an existing ChannelEnd.
4 replies
Mohammadsadegh Najafi
@MSNTCS
@majecty I think if the client can open a websocket request, we can manage stream API with sending Notification RPC request and I need to check wether the current library can handle Notification RPC request or not. Am I right?
28 replies
junha1
@junha1
So long, Gitter!
Park Juhyung
@majecty
It's hard to decide how to manage identifiers in relayer.
junha1
@junha1
@majecty Could you check updates on CodeChain-io/foundry#210
junha1
@junha1
I don't understand why optimistic handshake is important. It just makes code dirtier to allow that. Why is it needed? @majecty
junha1
@junha1
byebye
Kwang Yul Seo
@kseo
We moved to Discord https://discord.gg/xhpdXm7