These are chat archives for CommBank/maestro

10th
Apr 2015
Luke Williams
@shmookey
Apr 10 2015 04:09
#317 tested on cluster, seems to be working - ok to merge?
Sam Roberts
@SamRoberts
Apr 10 2015 04:16
#356 ready for review again, have added error accumulation back to Validator.all
Sam Roberts
@SamRoberts
Apr 10 2015 04:21
@shmookey there are still a few minor changes left to be addressed in the PR
Luke Williams
@shmookey
Apr 10 2015 04:35
oh i thought i fixed those
ah, didn't push
Sam Roberts
@SamRoberts
Apr 10 2015 04:48
would someone mind reviewing #359? It's super small and simple
Luke Williams
@shmookey
Apr 10 2015 05:58
@stephanh what do you think of:
@transformer(args=(foo, bar))
val foobarMapper:(Foo, Bar) => FooBar = (
  thatInt    := foo.thisInt,
  thatString := bar.thisString
)
i was thinking we might want to leave open the possibility of other arguments to the macro
eg:
@transformer(args=(foo, bar), allowAmbiguousFields=true)
val foobarMapper2:(Foo, Bar) => FooBar = (
thatInt := foo.thisInt,
thatString := bar.thisString
)
Vineeth Varghese
@vineethvarghese
Apr 10 2015 06:01
@shmookey what does "allowAmbiguousFields=true" do?
Luke Williams
@shmookey
Apr 10 2015 06:01
in this particular case i was also wondering if it's important that we replicate the runtime field value equality check that join does
@vineethvarghese i was thinking it might let two source structs have the same field name (but not the same value) by picking the first match (or something)
Vineeth Varghese
@vineethvarghese
Apr 10 2015 06:06
I am guessing that is turn off by default?
Luke Williams
@shmookey
Apr 10 2015 06:06
that's not necessarily a realistic example but i feel like there's probably other transformer behaviour we might want to be able to control in the future too
depends what people want :)
Stephan Hoermann
@stephanh
Apr 10 2015 06:41
For the benefit of everyone else I mentioned to at @shmookey that if we take the @transformer(args=(foo, bar)) we start mixing custom syntax foo, bar which has no meaning in standard Scala with normal Scala syntax. I really want to avoid the amount of custom syntax we have and where we do have custom syntax I want to set it apart as much as possible.