Where communities thrive

Join over 1.5M+ people
Join over 100K+ communities
Free without limits
Create your own community

Explore more communities

CoraleStudios/Colore

A powerful C# library for Razer Chroma's SDK

People

Repo info

Activity

Dec 20 2020 15:10

olivierverwoerd edited #283
Dec 20 2020 15:09

olivierverwoerd opened #283
Dec 10 2020 14:37

Sharparam labeled #280
Dec 10 2020 14:37

Sharparam closed #278
Dec 10 2020 14:37

Sharparam closed #276
Dec 10 2020 14:37

Sharparam commented #276
Aug 24 2020 23:59

QuiNz0r opened #281
Jul 03 2020 17:03

poveden commented #279
Jun 18 2020 19:31

Sharparam on 6.0.0

Disable coverage reports on Tra… Update GitHub target in Cake I… Use Cake in GitHub actions (compare)
Jun 18 2020 19:21

Sharparam on 6.0.0

Fix invalid table formatting (compare)
Jun 18 2020 19:20

Sharparam on 6.0.0

Add note in readme about pre-re… Configure indent size for markd… Make top of README prettier and 8 more (compare)
Jun 18 2020 18:22

Sharparam on 6.0.0

Use dotnet tool version of Repo… Move coverage report generation… Add zip of coverage report and 2 more (compare)
Jun 18 2020 16:47

Sharparam on 6.0.0

Fix commented code (compare)
Jun 18 2020 15:59

Sharparam on 6.0.0

Fix old paths in GitHub Actions… Fix parameter parsing in build.… (compare)
Jun 18 2020 15:36

Sharparam on 6.0.0

Switch to using Cake as a dotne… Use GitVersion as a dotnet tool Use uppercase "V" for verbosity and 5 more (compare)
Jun 18 2020 01:14

Sharparam on gh-pages

[AUTOMATED] Documentation updat… (compare)
Jun 18 2020 01:11

Sharparam on v6.0.0-rc14

(compare)
Jun 18 2020 01:02

Sharparam on 6.0.0

Fix glob pattern in cache key Update artifact paths (compare)
Jun 18 2020 00:48

Sharparam on 6.0.0

Fix glob paths for artifacts (compare)
Jun 18 2020 00:45

Sharparam on 6.0.0

Upgrade Travis dist to bionic Enable main GitHub Action workf… Create some artifacts in GitHub… (compare)

Adrian

@WolfspiritM

A workaround for now to find out which layout it is: The System Windows Forms Namespace does have a "InputLanguage.CurrentInputLanguage" which could be used I assume. I've not used it yet for anything, but InputLanguage.CurrentInputLanguage.LayoutName for me returns "German". It's not using the actual Keyboard Layout but the Keyboard Layout definied in Windows.

Adam Hellberg

@Sharparam

@WolfspiritM The current system language doesn't necessarily correspond to the actual physical layout of the keyboard, which is where the problem surfaces

Adrian

@WolfspiritM

@Sharparam It's not the system language it returns. My system is set to english. It's returning the input device configuration and I'd say mostly this is set correctly as Z wouldn't be Z for example. But I agree that the layout you define in windows doesn't mean the hardware does really have that layout. That's why it's a workaround...it'd be better then nothing.

Adam Hellberg

@Sharparam

s/system language/input language/. I know a couple people who remap their caps lock to escape for example.

Adrian

@WolfspiritM

I agree...handling remapped keys would be a way harder problem

Adam Hellberg

@Sharparam

Razer needs to provide a definite (this is important) list of ALL available physical layouts of the keyboard as well as provide a function that accurately returns the physical layout of the keyboard. Otherwise there is no reliable way to even try to handle it.

problem is that since they seem hellbent on putting this workload on the developers, every developer needs to implement their own solution to this since they won't add it natively in the SDK.

Adrian

@WolfspiritM

Or make their SDK light up the correct key no matter what Keyboard Layout...

Adam Hellberg

@Sharparam

people using Colore can use the methods in there of course, but those not using C# and working with the SDK directly will produce hundreds of duplicate methods to do this

Adrian

@WolfspiritM

It's one big flaw I saw in their SDK as I was playing around, that they didn't think of other keyboard layouts. Let's just hope they'll work on it.

Adam Hellberg

@Sharparam

Then you also have to consider that some people may have multiple keyboards plugged in with differing layouts

it's likely a small enough amount to be irrelevant, but still an interesting thought

Adrian

@WolfspiritM

not sure if that'd be so hard for their SDK that is doing the USB part to switch out keys (Y and Z for example) depending on the layout of the device it's sending to. Then it doesn't matter how many keyboards are plugged in

Adam Hellberg

@Sharparam

it's the reason this should be put in the driver so it's as close to the hardware as possible, or firmware even. but they've already released the keyboards so it's a bit late for that

the SDK doesn't (and probably won't for the foreseeable future) provide granular access to specific devices, only to "all <device type here>" so the SDK can't be used to filter devices out

Dariusz Niemczyk

@Palid

@Sharparam tbh from what I'm reading the SDK is a piece of crap.

Adrian

@WolfspiritM

Not really talking about the API part of the SDK...more the backend (driver) part that does the work. The driver knows what layout it is and it could fix this. However...it's totally Razers part to do that

Dariusz Niemczyk

@Palid

Wait. We should have access to the keyboard's product number, or sth.

this way we can at least try doing an ugly fix.

Model number*

Adam Hellberg

@Sharparam

you can query a GUID and get the device type and whether it's connected, not any details about its layout

see: DeviceType struct and Query method on Chroma class

DeviceInfo*

Dariusz Niemczyk

@Palid

Well, we can try with the Model Number then.

Adam Hellberg

@Sharparam

it cannot be queried

we can only get type of device (keyboard, mouse et.c) and whether it's connected

Dariusz Niemczyk

@Palid

@Sharparam you sure that it can't be queried? I'm not talking about SDK now.

Let's just agree that SDK sucks and try different methods. :P

Adam Hellberg

@Sharparam

you could probably start making your own stuff to read USB data, but then you're reverse engineering and breaking rules and shit

Adrian

@WolfspiritM

You could query the USB somehow

Dariusz Niemczyk

@Palid

tbh if Razer would start doing something against 'illegal rev-eng' in this case they would lose a lot of fanbase.

Adrian

@WolfspiritM

Even having the model...I think using InputLanguage.CurrentInputLanguage as an ugly workaround would be easier instead somehow mapping model/guid to region to key

Dariusz Niemczyk

@Palid

but yeah, let's not go into this discussion. :D

@WolfspiritM There's a problem with ugly workarounds: they are ugly and always do a problem in edge cases.

and here the edge case isn't even so edge-like.

Adrian

@WolfspiritM

Querying the USB for a model number is nothing more then a ugly workaround, too...

Dariusz Niemczyk

@Palid

True, but a bit more bulletproof.

Adam Hellberg

@Sharparam

@/all Whoever had issues with exceptions from UnInit can you try using feature/uninit-improvement and see if that fixes the issue?

Adrian

@WolfspiritM

@Palid I don't really see where it would be much more bulletproof. It won't fix multiple keyboards with different layouts nor remapped keys. But you can sure try querying USB :-)

@Sharparam I will try it later. Thanks!

Adam Hellberg

@Sharparam

@WolfspiritM also if you find issues with it please comment about them here: CoraleStudios/Colore#108

Adrian

@WolfspiritM

@Sharparam alright

Dariusz Niemczyk

@Palid

@WolfspiritM will do if I have some time this weekend

got so many tickets that I'll have to work overtime on the weekend :(