Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 24 23:59
    QuiNz0r opened #281
  • Jul 03 17:03
    poveden commented #279
  • Jun 18 19:31

    Sharparam on 6.0.0

    Disable coverage reports on Tra… Update GitHub target in Cake I… Use Cake in GitHub actions (compare)

  • Jun 18 19:21

    Sharparam on 6.0.0

    Fix invalid table formatting (compare)

  • Jun 18 19:20

    Sharparam on 6.0.0

    Add note in readme about pre-re… Configure indent size for markd… Make top of README prettier and 8 more (compare)

  • Jun 18 18:22

    Sharparam on 6.0.0

    Use dotnet tool version of Repo… Move coverage report generation… Add zip of coverage report and 2 more (compare)

  • Jun 18 16:47

    Sharparam on 6.0.0

    Fix commented code (compare)

  • Jun 18 15:59

    Sharparam on 6.0.0

    Fix old paths in GitHub Actions… Fix parameter parsing in build.… (compare)

  • Jun 18 15:36

    Sharparam on 6.0.0

    Switch to using Cake as a dotne… Use GitVersion as a dotnet tool Use uppercase "V" for verbosity and 5 more (compare)

  • Jun 18 01:14

    Sharparam on gh-pages

    [AUTOMATED] Documentation updat… (compare)

  • Jun 18 01:11

    Sharparam on v6.0.0-rc14

    (compare)

  • Jun 18 01:02

    Sharparam on 6.0.0

    Fix glob pattern in cache key Update artifact paths (compare)

  • Jun 18 00:48

    Sharparam on 6.0.0

    Fix glob paths for artifacts (compare)

  • Jun 18 00:45

    Sharparam on 6.0.0

    Upgrade Travis dist to bionic Enable main GitHub Action workf… Create some artifacts in GitHub… (compare)

  • Jun 18 00:12

    Sharparam on 6.0.0

    Fix caches Remove Coveralls integration Add GitHub Actions workflow (compare)

  • Jun 17 23:58

    Sharparam on 6.0.0

    Handle RC tags in docs script Skip restore when running tests Remove outdated code and 2 more (compare)

  • Jun 17 20:08

    Sharparam on 6.0.0

    Add missing newline Add OldStyle option back to Ope… (compare)

  • Jun 17 20:00

    Sharparam on 6.0.0

    Use Path32 register mode for Op… (compare)

  • Jun 17 19:55

    Sharparam on 6.0.0

    Update OpenCover settings (compare)

  • Jun 17 19:32

    Sharparam on gh-pages

    [AUTOMATED] Documentation updat… (compare)

Adrian
@WolfspiritM
It does even break native C++ code as far as I can see
so is the latest version 1.1.2 or 1.1.5?
Brandon Scott
@brandonscott
YEs
The order of the enum is incorrect
Adrian
@WolfspiritM
So it seems like they noticed that 1.0.4 had a wrong order for the enum and swapped it back.
Adam Hellberg
@Sharparam
without telling anyone
reminds me of the opening to hitchhiker's
"What do you mean, this has been on display at <whatever planet it was> for several years!"
Roxas Keyheart
@roxaskeyheart
is anyone around?
Adam Hellberg
@Sharparam
@technicaldaniel on phone on bus so I'm kinda available but can't do any dev work :p
Roxas Keyheart
@roxaskeyheart
is someone online by any chance?
Roxas Keyheart
@roxaskeyheart

I was wondering what the correct syntax is for setting a breathing effect between 2 colours on my keyboard? I can set static colours just fine but I just can't get breathing to work (ie. nothing happens) when i use the same syntax:

Keyboard.Instance.SetBreathing(Corale.Colore.Core.Color.Green, Corale.Colore.Core.Color.Red);

Roxas Keyheart
@roxaskeyheart
@WolfspiritM
Adrian
@WolfspiritM
@technicaldaniel Seems like you found an issue with the Colore implementation of the Breathing struct. Going to fix it
Roxas Keyheart
@roxaskeyheart
greatly appreciated
Roxas Keyheart
@roxaskeyheart

@WolfspiritM I'm not sure if this is part of the same issue but whenever I try and use a different device to set a .SetBreathing() effect it returns the following error:

The type 'System.Windows.Media.Color' is defined in an assembly that is not referenced. You must add a reference to assembly 'PresentationCore, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'.

It doesn't do this for Keyboard though, however it does it for all other devices.

Additionally, the Headset .setBreathing() method only has one parameter so I can't set 2 colours to breath between.

Adrian
@WolfspiritM
@technicaldaniel Headsets only support one Color for breathing.
What other devices are you trying to set breathing and it fails with the error you got? Mouse?
Roxas Keyheart
@roxaskeyheart
@WolfspiritM It appears the error throws for all devices except Keyboard.
I will double check in a sec when i can recompile
Adam Hellberg
@Sharparam
@WolfspiritM Since Colore 3.0 we are supporting setting WPF colors as well as System.Drawing colors, this unfortunately means that apps will have to add a reference to the WPF library (PresentationCore.dll) if they reference code that itself has direct or in-direct references to System.Windows.Media.Color.
@technicaldaniel i mean*
Roxas Keyheart
@roxaskeyheart
@Sharparam does the Colore library reference WPF in the .setBreathing() method? I'm using the exact same colour syntax as my .setAll() methods which has been working perfectly without PresentationCore?
Adrian
@WolfspiritM
@Sharparam I have a test Winforms app that doesn't reference PresentationCore and works. As long as Colore does reference it it should be fine I think
Adam Hellberg
@Sharparam
@technicaldaniel System.Windows.Media.Color is only ever directly referenced in the casting operators inside Corale.Colore.Core.Color, i'm not entirely sure when .NET/the compiler decides that the reference is needed on a project level.
@WolfspiritM On StackOverflow the answers seemed to be that as long as an external type is not referenced in a constructor it's fine, but it seems to not always be the case.
Adrian
@WolfspiritM
@technicaldaniel Mouse.Instance.SetBreathing(Color.Red, Color.Green, Led.All); works for me without PresentationCore. How do you generate your colors? Are you just using Color.Red for example?
Roxas Keyheart
@roxaskeyheart
@WolfspiritM Headset.Instance.SetBreathing(Corale.Colore.Core.Color.Red);
is throwing me the error

Keyboard.Instance.SetBreathing(Corale.Colore.Core.Color.Red, Corale.Colore.Core.Color.Green);

seems to work but nothing happens on the keyboard, but that might be an actual bug as you were saying.

Adrian
@WolfspiritM
Hm I don't have that problem. I don't have a headset to test it but it doesn't give me an error
Yes that won't work but actually should throw an invalid parameter exception from the native call
cause Razer added a BreathingType which Colore doesn't seem to have yet
Roxas Keyheart
@roxaskeyheart
The mouse code you posted seems to be accepted as i didn't have the led parameter on the end, however i don't have a mouse to test if it actually works.
Adam Hellberg
@Sharparam
@WolfspiritM In what version of the SDK? THe docs download is still for 1.0.4 while synapse ships with 1.1.5 so i'm unable to check it out atm
unless synapse saves the headers somewhere but i don't know where
Adrian
@WolfspiritM
1.1.2
CoraleStudios/Colore#129
but 1.0.4 should also have it like that
yep just checked...1.0.4 also has the Type
Sharparam @Sharparam slaps self
Adam Hellberg
@Sharparam
apparently that change went past us
Roxas Keyheart
@roxaskeyheart
Okay i fixed the headset by just referencing PresentationCore. Ideally I would like to do it without that but it works so thats that
Adrian
@WolfspiritM
@Sharparam Actually the UsedImplicitly is just a copy and paste from the Mouse Breathing Effect which also doesn't have PublicAPI :P
But what do you mean that it doesn't have an invalid value?
Adam Hellberg
@Sharparam
myep, hence my comment about our usage not being consistent. UsedImplicitlyshould be on code that is not necessarily publicly accessible but used in some way, to prevent toolings from marking it as unused. (like fields that will be consumed by the SDK but can't actually be seen/used by external code)
the enum in the SDK docs only has "Two" and "Random", not "Invalid"
is the header different?
Adrian
@WolfspiritM
//! Breathing effects.
enum Type
{
TWO_COLORS = 1, //!< 2 colors
RANDOM_COLORS, //!< Random colors
INVALID
} Type;
Adam Hellberg
@Sharparam
that's interesting