Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Guillaume Ayoub
    @liZe
    (And a PR with tests is often a good PR 😉)
    Mohammed Y. Alnajdi
    @malnajdi
    no problem i am loving this
    Mohammed Y. Alnajdi
    @malnajdi
    I hope you got sometime to review it
    Guillaume Ayoub
    @liZe
    I hope too!
    Mohammed Y. Alnajdi
    @malnajdi
    ahahaha
    i just need a signal to keep trying
    here not there
    other wise i will jump into other problem
    i think that is better
    i will check other issues related to RTL
    Guillaume Ayoub
    @liZe
    @malnajdi Your pull request is cool!
    I’ll add a review with some advice. You can fix it if you can, or I can merge it and fix it myself.
    Mohammed Y. Alnajdi
    @malnajdi
    I would like to fix it so i can learn and progress faster next time
    where is the comments ? @liZe
    Guillaume Ayoub
    @liZe
    I didn’t submit the review, oops
    It’s done
    Mohammed Y. Alnajdi
    @malnajdi
    Thanks a lot
    Daniel Fitzpatrick
    @danfitz36
    Are there best practices for how to use weasyprint in the cloud? my company is currently using an older version of weasyprint in an AWS lambda. we're having trouble upgrading because of some limitations of the lambda (i think) but maybe there's a better way entirely
    Guillaume Ayoub
    @liZe
    @danfitz36 Hi!
    I don’t use AWS myself, but I think that there’s a problem with recent versions of Python on AWS, I don’t remember why.
    Let me find the related issue.
    Lucie Anglade
    @grewn0uille
    Daniel Fitzpatrick
    @danfitz36
    great thanks, i'll look into it now
    Mohammed Y. Alnajdi
    @malnajdi
    @liZe pull-request is ready with a passing test cases and a working row, row-r, col, col-r. Please verify and let me know
    Mohammed Y. Alnajdi
    @malnajdi
    Mohammed Y. Alnajdi
    @malnajdi
    Hi
    Lucie Anglade
    @grewn0uille
    Hi @malnajdi
    Mohammed Y. Alnajdi
    @malnajdi
    hi @grewn0uille i have question is it normal that some test have yellow mark ?
    like x in yellow
    Lucie Anglade
    @grewn0uille
    It’s when a test fail and was expected to. You can see @pytest.mark.xfail just before the test like here https://github.com/Kozea/WeasyPrint/blob/master/weasyprint/tests/test_float.py#L714
    Mohammed Y. Alnajdi
    @malnajdi
    so if the code was fixed we should remove this line ?
    Lucie Anglade
    @grewn0uille
    If now the test is working, I guess that yes you can remove this line
    Mohammed Y. Alnajdi
    @malnajdi
    Thanks
    Mohammed Y. Alnajdi
    @malnajdi
    @liZe Hai, do you think the changes for flex and ol can be pushed in the next release ?
    Lucie Anglade
    @grewn0uille
    @malnajdi normally yes it’ll be on the next release :)
    Mohammed Y. Alnajdi
    @malnajdi
    Great @grewn0uille do you mind reviewing the pull-requests ? i am not sure if the second one is correct or not
    Lucie Anglade
    @grewn0uille
    We’ll really try to have your prs merged for the next release :) I can’t review for now as I don’t have enought skills for that yet. And also, we develop WeasyPrint on our freetime and it’s kind of tight right now ^^"
    Mohammed Y. Alnajdi
    @malnajdi
    It's alright, Thanks a lot. No worries. Sorry for the trouble
    julientaq
    @julientaq_gitlab
    Hello!
    Lucie Anglade
    @grewn0uille
    Hi!
    julientaq
    @julientaq_gitlab
    Depuis le temps que j’essaye de prendre contact avec les gens derrière weasyprint, je suis content de vous trouver :)
    Pour la sortie de pagedjs 1.0 (wouhou) si tout se passe bien, en novembre, on organise un événement en ligne autour du #printCSS.
    Je voulais savoir si ça vous dit de venir parler de weasyprint :)
    Lucie Anglade
    @grewn0uille
    Oh nice :)
    Ça pourrait être intéressant :) poke @liZe
    julientaq
    @julientaq_gitlab
    c’est entre le 23 novembre et le 4 décembre, en ligne, le but du jeu c’est de montrer ce qui est possible, en français ou en anglais, ou en ce qui vous plaira. Y a pas mal d’utilisateur de pagedjs mais je pense que plus on est de fous, plus on rit.
    on peut en discuter quand vous voulez, l’invitation est lancée .-)
    Lucie Anglade
    @grewn0uille
    C’est gentil d’avoir pensé à nous :) On va voir ce qu’on peut faire et on te tient au courant
    julientaq
    @julientaq_gitlab
    ça marche!
    Guillaume Ayoub
    @liZe
    Merci beaucoup @julientaq_gitlab pour l’invitation, on viendra en discuter avec toi bientôt :)
    julientaq
    @julientaq_gitlab
    avec plaisir!