by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Gaultier Boniface
@wysow
@bobmulder yes Couscous should update globally with selfupdate as it does internally update the binary phar...
Bob Mulder
@bobmulder
Yeah but I had a very early version...
So that may be relevant for old users ;P
Gaultier Boniface
@wysow
sure you’re right
Julien BIANCHI
@jubianchi
@mnapoli I was asking myself if "automatically" adding the directories listed in .gitignore in the exclude section of couscous.yml would be a good thing. Thoughts ?
Matthieu Napoli
@mnapoli
@jubianchi that would make a lot of sense indeed
Julien BIANCHI
@jubianchi
@mnapoli will do the PR ;)
Bob Mulder
@bobmulder
Haha great idea!
Julien BIANCHI
@jubianchi
I'm fixing my PR and will wait for your feedback... I'm not really satisfied by the implementation/limitations but it perhaps ok for you
Matthieu Napoli
@mnapoli
@jubianchi :+1: I'll have a look (lots of things to do at work ;)). Btw do you have a link to your async library?
Julien BIANCHI
@jubianchi
@mnapoli no hurry ;)
I'm building the webste for the doc
will push the current WIP
Matthieu Napoli
@mnapoli
awesome
there is a CSS issue actually :/
Matthieu Napoli
@mnapoli
@jubianchi ah right, you need to set baseUrl: http://username.github.io/your-project
baseUrl: http://jubianchi.github.io/async-generator
Julien BIANCHI
@jubianchi
@mnapoli yep, just saw that hile reading the template code
Matthieu Napoli
@mnapoli
I agree it's not ideal :/ And I just realized it's not in the "getting started" guide. But it was hard to find another solution, we could use relative URLs and guess the directory depth (add ../ in front of links/resources) but it's quite some work
Julien BIANCHI
@jubianchi
@mnapoli too much work I think ;) moreover, the template's readme is clear
I just forgot to RTFM :D
Matthieu Napoli
@mnapoli
@jubianchi got this output will running couscous preview:
Capture d’écran 2016-06-01 à 22.14.32.png
I think the PHP sub-process died but not fast enough for Couscous, which believed it was a failure. I'm not sure but that's what I suspect, as you can see in the output nothing wrong happened on the webserver, I can reproduce it easily
Julien BIANCHI
@jubianchi
@mnapoli ha this sure comes from my last PR. I'm catching SIGINT (2) which is CTRL+C so the exception is thrown. Perhaps I should not catch this one and only take care of SIGTERM (15)
Matthieu Napoli
@mnapoli
but I think the error comes from "Unable to kill the server", which causes the output of the server to be dumped
I don't know what it considers that it wasn't able to kill the server, maybe it needs to wait for a few seconds?
Julien BIANCHI
@jubianchi
the condition should be inverted
Matthieu Napoli
@mnapoli
ahh :) ok no big deal
Julien BIANCHI
@jubianchi
let my send a fix ;)
Matthieu Napoli
@mnapoli
:+1:
Julien BIANCHI
@jubianchi
I'll also test again with CTRL+C and try to improve the output in this case (i.e not throw an exception if everything went fine with SIGINT)
Julien BIANCHI
@jubianchi
I'll try to push the fix for SIGINT et finish the PR for the gitignore
Julien BIANCHI
@jubianchi
@mnapoli sorry for the tiny bug I introduced. I pushed the fix and also updated the PR about the .gitignore. There is one last question to answer and I'll be done with it ;)
Matthieu Napoli
@mnapoli
no worries! I'll have a look at it
Matthieu Napoli
@mnapoli
Julien BIANCHI
@jubianchi
:+1:
Bob Mulder
@bobmulder
Hi there! Can anybody give me any direction why Github blocks some css files?
blob
Matthieu Napoli
@mnapoli
from the console:
Mixed Content: The page at 'https://bakkerij.github.io/cakeadmin/' was loaded over HTTPS, but requested an insecure stylesheet 'http://bakkerij.github.io/cakeadmin/css/bootstrap.min.css'. This request has been blocked; the content must be served over HTTPS.
Bob Mulder
@bobmulder
Great @mnapoli! However, I think it should be fixed in the template (light) I used, right?
Matthieu Napoli
@mnapoli
right but those a built from the baseUrl you configured I think: https://github.com/CouscousPHP/Template-Light/blob/master/default.twig#L9-L12
Bob Mulder
@bobmulder
Great @mnapoli
I had to change it in my .couscous.yml :)
Thank you for your quick support!