Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 06 2015 07:23

    GoEddie on master

    initial commit Merge pull request #1 from DacF… Merge pull request #4 from GoEd… (compare)

  • Nov 06 2015 07:23
    GoEddie closed #4
  • Nov 06 2015 07:23
    GoEddie opened #4
  • Nov 05 2015 21:11

    GoEddie on master

    initial commit Merge pull request #3 from GoEd… (compare)

  • Nov 05 2015 21:11
    GoEddie closed #3
  • Nov 05 2015 21:10
    GoEddie opened #3
  • Nov 04 2015 12:41

    GoEddie on master

    Adding BatchedTableMigration De… moved to using 'output into' st… adding sqlpackage and 1 more (compare)

  • Nov 04 2015 12:41
    GoEddie closed #2
  • Nov 04 2015 12:41
    GoEddie opened #2
  • Nov 02 2015 16:47

    GoEddie on master

    Adding DeploymentPlanLogger (compare)

  • Nov 02 2015 14:13

    GoEddie on master

    Add Gitter badge Merge pull request #1 from gitt… (compare)

  • Nov 02 2015 14:12
    GoEddie closed #1
  • Nov 02 2015 14:11

    GoEddie on master

    Added gitter link (compare)

  • Nov 02 2015 14:09
    gitter-badger opened #1
Peter Schott
@paschott
Ed, have you ever done a contributor around honoring things like Compression if the edition supports it? SSDT is somewhat lacking in that sort of thing right now.
Ed Elliott
@GoEddie
Hi! I have thought about trying to extend it with things like SQL agent jobs but it seems like quite a lot of work! Do you mean enabling compression only of the edition supports it?
Peter Schott
@paschott
Combination - the first issue is that SSDT can ignore the COMPRESSION options and ONLINE options in indexing completely. Opening a ticket gets a "working as designed", though chatting with the team they do understand the frustration. Second issue is the edition support for those types of features. We had to do acrobatics at my last place to handle ONLINE index creates to avoid completely locking the table.
Re-thinking my original question - I guess this is more around ONLINE, which is completely ignored, as opposed to the various Compression options. I vaguely remember those are picked up properly.
Ed Elliott
@GoEddie
Ah ok so in a contributor we have a TSqlModel of the destination but not the edition so we couldn't just add ONLINE when it was enterprise but we could wrap every create index with a check for edition and then create with and without ONLINE.
To find the edition we could find the parameters passed to sqlpackage and run a query but it is pretty hacky and only for sqlpackage
Peter Schott
@paschott
Definitely hack-y, though it seems you could wrap that in a custom bit of code for the beginning of the script generation part if it came down to that instead of passing a parameter.
We have one instance and one customer that can't support ONLINE/Compression so it makes SSDT a bit trickier to use if we want to compress elsewhere. :-/
Ed Elliott
@GoEddie
I'll try and have a fiddle tomorrow and do one that lets you do stuff based on edition and I can think of a couple of feature requests to make it simpler (giving a contributor a sqlcomnection to the source or target of it has one etc or adding edition to the context object)
Feature requests = connect items!
Peter Schott
@paschott
Well, I did chat w/ the SSDT team recently and gave them some feedback - including this particular issue. They explained the challenges, technical debt, and desire to overcome that as they move forward. I also understand that it's not really a bug as the code is working as designed. I just don't like this particular design. :)
Ed Elliott
@GoEddie
I've been on both sides of the "works as designed" table :) I think that not many people are writing these today so even if it isn't a high priority but makes it in further down the line (or an alternative) then it's worth doing - I like that the ssdt team do actually listen / are available and their 3 month deploy schedule gives me hope!
wterbeek
@wterbeek
Hi Guys, i have a question. i am trying to make the AgileSqlClub.SqlPackageFilter.dll work with my sqlpackage executable. but it keeps throwing errors indication the contributor dll could not be initialized. i've already unblocked the dll and pdb file, put them in the same folder, and also tried putting them in the exteions sub folder, but that does not seem to work either. am i missing something?
the fileVersion of the sqlPackage.exe is 13.0.3119.1
Ed Elliott
@GoEddie
Hi & Welcome :)
Was sqlpackage installed on the machine or are you copying sqlpackage.exe onto it?
Ed Elliott
@GoEddie
What I am getting at is make sure you have the "Microsoft.SqlServer.TransactSql.ScriptDom.dll" in the same folder as well it is normally in the \120\SDK\Assemblies folder
wterbeek
@wterbeek
i just checked, its not in the folder, but im using the 130/sdk folder
it has no assemblies sub folder
and to answer your first question, the sqlpackage.exe is installed on my local machine.
it is also the environment where, at this moment the code will run
this is the complete path C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\Extensions\Microsoft\SQLDB\DAC\130
wterbeek
@wterbeek
i copied the dll into the folder, however it still gives me the same message
copying the files to the extension subfolder doesn't work either
wterbeek
@wterbeek
also, when i check the folder ssdt publish folderin the zip, it holds additional dll's, but i already have to those with a newer modified date. i assume i don't have to copy those
Ed Elliott
@GoEddie
you are on the 2016 ctp? I have a feeling there is an issue with the references - if you are feeling adventurous you could download the code, change the references to the 2016 ones and re-build otherwise I can do it tonight (although I only have ctp2)
you could possible use a binding redirect file as well
Ed Elliott
@GoEddie
This was caused by using sqlpackage from sql 2016 ctp - I'll fix it at some point :)
ntwest
@ntwest
Hi there, I'm trying to figure out how to get this working with SSDT right-click/publish (VS 2013). I'm not clear on where the specific DLLs need to go, and what I need to add to the sqlproj file. Is there any step by step documents on how to get this running from start to finish?
To be specific - i am trying to get the AgileSqlClub "SqlPackage Deployment Filter" working, but an example with this one would probably be fine too.
Ed Elliott
@GoEddie
Check the issue on codeplex :)
ekpaila
@ekpaila
Hi there, I created an exe application that takes takes in SQL contents and make them re-rerun safe. I would like to integrate my code/application to run during publish/generate scripts in SQL DB projects. Could someone please throw me some suggestions. DeploymentScriptGenerator has OnExecute method that I believe generates the final script. I would like to call my code somewhere round here, where i take the final script as an input and modify them. Thanks in advance
Ed Elliott
@GoEddie
Hey, did you look at the example here? https://msdn.microsoft.com/en-us/library/ee461507(v=vs.100).aspx It creates a deployment contributor that makes a script re-runnable - I don't know if the way you do it is similar but the interesting thing is that it shows you how to wrap statements with the re-runnable code (which you can put in whatever you like)
xhead
@xhead
Does MSBuild not support additional contributors for a SqlProject? I have two command lines, one using SqlPackage.exe and one using MSBuild.exe, and the console output (and the generated SQL scripts) shows that for Sqlpackage.Exe, the AgileSQLClub.BatchedTableMigration contributor is getting called, but for MSBuild it is not.
Ed Elliott
@GoEddie
Hi xhead, it isn't a build contributor and is only a demo - what are you trying to do?