by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Jeroen Claassens
    @Favna
    I have the same as Krisztian with DefinitelyTyped/DefinitelyTyped#45306. Created 17 days ago, and ready to merge 9 days ago.
    Krisztián Balla
    @krisztianb
    @Favna our PRs don't show up on the project's status board: https://github.com/DefinitelyTyped/DefinitelyTyped/projects/5 Maybe that's the problem.
    Jeroen Claassens
    @Favna
    Hmmm... Not sure how to contact DT maintainers other than here either
    Piotr Błażejewicz (Peter Blazejewicz)
    @peterblazejewicz
    Sorry folks, for such kind of PR there is still a requirement to have approval from the repo maintainer, sorry for a delay. I think this kidn of PR is being shown properly on the proper project swimlane, but due to the repo activity, somedays there are >100 items on that specific swimline, still requiring DT maintainer review.
    Krisztián Balla
    @krisztianb
    @peterblazejewicz thanks for your info. What swimlane are you refering too? Is it one that we have no privilege to see?
    Piotr Błażejewicz (Peter Blazejewicz)
    @peterblazejewicz
    image.png
    @krisztianb no, absolutely not (regular user here). I meant the left-most column (swimlane could be misleading, sry):
    https://github.com/DefinitelyTyped/DefinitelyTyped/projects/5#column-7552922
    Krisztián Balla
    @krisztianb
    But if I search for "binary" my PR does not show up in that column.
    Piotr Błażejewicz (Peter Blazejewicz)
    @peterblazejewicz
    yes, because your one was just merged:
    DefinitelyTyped/DefinitelyTyped#45340
    Krisztián Balla
    @krisztianb
    I swear it was not in the column yesterday either. Nevermind. :smile:
    Krisztián Balla
    @krisztianb
    The PR of @Favna is not in the column. Shouldn't it be there?
    Jeroen Claassens
    @Favna
    it is there @krisztianb https://favna.s-ul.eu/ncEBAabA.jpeg
    Krisztián Balla
    @krisztianb
    Strange. It is not there if I search for "mui" or "datatables".
    Krisztián Balla
    @krisztianb
    Looks like something went wrong with the README: https://www.npmjs.com/package/@types/binary-split
    Evan Brodie
    @ecbrodie
    Hello. My PR was merged 5 hours ago, which created a new type binding. However, the NPM package has not been published yet. According to your README, I'm supposed to message the Gitter channel about it after > 1 hour. Can someone please investigate? Thank you. My PR: DefinitelyTyped/DefinitelyTyped#45565
    Evan Brodie
    @ecbrodie
    Nevermind, it has appeared in NPM. Thanks: https://www.npmjs.com/package/@types/nulogy__components
    The NPM link in the PR was a little confusing, it doesn't handle links to namespaced packages very well (for example, I create type bindings for @nulogy/components, but it links me to the NPM package page for nulogy__components)
    Vicktor
    @vityapro
    Hello guys. Need some help.
    Have conflict of namespace google when use [@types/google.picker] and [@types/googlemaps] packages. TS pars @types/googlemaps d.ts and give me an error when i try to use google.picker. Or should i create an issue on github repo?
    Piotr Błażejewicz (Peter Blazejewicz)
    @peterblazejewicz
    @vityapro
    The repo itself would be better, in the issue content please copy @authors github handles from the types to get most proper feedback
    Thx!
    Evan Brodie
    @ecbrodie
    Hello. My recently created type binding was exported to NPM without a README. These readme's normally include the link to the directory of the type binding in the DefinitelyTyped repo. I thought this was normally an automatic action by the publisher. Although I could be wrong and maybe I forgot something in my code? https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/nulogy__components
    Krisztián Balla
    @krisztianb
    @ecbrodie I reported this here before. It seems that (all?) recently published packages are affected.
    Maciej Holyszko
    @falkenhawk

    :point_up: May 28, 2020 3:35 PM

    Another issue with new linter is, it seems to be too restrictive, for example it reports now use of @default within JSDoc:

    /**
     * font version string, can be Version x.y or x.y
     * @default 'Version 1.2'
     */
    version?: string;

    this will make linter to throw check error:

    The 'no-redundant-jsdoc-2' rule threw an error in

    The @default is a nice way to provide valid information to type consumer.

    So is it okay to use @defaultin declaration files, or is there a better way?

    Piotr Błażejewicz (Peter Blazejewicz)
    @peterblazejewicz
    So is it okay to use @defaultin declaration files, or is there a better way?
    This is OK, there were issue with changes done in the linters, not with the JSDoc. The linter reports supoerflous information only from JSDoc (param type/return type) - but only in the context of TS, JSDoc itself is here and rules the seas.
    Piotr Błażejewicz (Peter Blazejewicz)
    @peterblazejewicz
    @andrewbranch thank you!
    Andrew Branch
    @andrewbranch

    Sure thing, appreciate your patience @peterblazejewicz 😅

    Were you able to look into my comment about the functions exported from the namespace? I couldn’t find any evidence that those still exist in the source. I’d like to get that cleared up since I think it may be an additional source of confusion for the PR author.

    Rumon
    @msrumon
    Reporting one missing function overhead declaration of ffmpeg package: save() function also works with promise, so adding another overhead would be helpful. Can anyone do it please? I'm not expert in type definition writing, that's why I won't submit PR.
    Piotr Błażejewicz (Peter Blazejewicz)
    @peterblazejewicz

    Were you able to look into my comment about the functions exported from the namespace? I couldn’t find any evidence that those still exist in the source. I’d like to get that cleared up since I think it may be an additional source of confusion for the PR author.

    Yes, looked into that yesterday, but decided to not post yet another comment, you probably understand why. There is a simple construct now in this module, just Email class with bunch of async/non-async mehtods,and a namespace supporting types/interfaces.

    Rumon @msrumon 14:56
    Reporting one missing function overhead declaration of ffmpeg package: save() function also works with promise, so adding another overhead would be helpful. Can anyone do it please? I'm not expert in type definition writing, that's why I won't submit PR.

    can you create an isssue and put a reference to me? @peterblazejewicz I'll try to fix this, thanks!

    Elijah Lucian
    @ELI7VH

    hello all. I am trying to update types on deftyped, and I am getting

    Error: At 3:68 : Expected one of
        /(, )|(,?\r?\n\/\/\s\s+)/
        /\r?\n\/\/ Definitions: [^\r\n]+/
        at Object.parseHeaderOrFail (/home/elucian/DefinitelyTyped/node_modules/@definitelytyped/header-parser/dist/index.js:21:15)

    what is this from?

    Elijah Lucian
    @ELI7VH
    more googling got me the answer thanks!
    Elijah Lucian
    @ELI7VH
    ok... how do i push a branch to this?
    am I blind? I can't figure out how to publish my branch...
    ERROR: Permission to DefinitelyTyped/DefinitelyTyped.git denied to ELI7VH.
    fatal: Could not read from remote repository.
    Elijah Lucian
    @ELI7VH
    curious why we have to fork the project instead of just pushing a branch to the project...
    higher bar for entry?
    Elijah Lucian
    @ELI7VH
    if a function returned some private variables, would you include the min the type: ?
            _start: Date;
            _end: Date;
            _index: number;
    or just include all normally named variables?
    cherryblossom000
    @cherryblossom000

    If a module exports a function like this:

    function f() {}
    module.exports = f
    module.exports.f = f

    is this the appropriate way to type it?

    export = moduleName
    declare const moduleName: typeof f & {f: typeof f}
    declare function f(): void
    declare namespace moduleName {
      // exported types
    }
    Piotr Błażejewicz (Peter Blazejewicz)
    @peterblazejewicz

    if a function returned some private variables, would you include the min the type:

    If these are truly private (within a module or class), do not add them to the type definition. If they seem just for a convention, add them to type definition, but observe if there is a JSDoc comment with @private or just a comment that express author intent to not expose the api. Check in the module README, if these are used. Also check the tests, sometimes those private are intended to be used in tests only, hence the convention. Really depends on the source API

    Piotr Błażejewicz (Peter Blazejewicz)
    @peterblazejewicz

    If a module exports a function like this:

    function f() {}
    module.exports = f
    module.exports.f = f

    try:

    declare function moduleName(): void;
    declare namespace moduleName {
        const f: typeof moduleName;
    }
    export = moduleName;
    cherryblossom000
    @cherryblossom000

    @peterblazejewicz Wouldn't that mean that this will compile but fail at runtime:

    import moduleName from 'moduleName'
    moduleName.f.f()

    The f isn't circular

    Piotr Błażejewicz (Peter Blazejewicz)
    @peterblazejewicz
    @cherryblossom000 it really depends on the source, I've done such construct for backreference for legacy field in Glob CJS, see:
    https://github.com/definitelyTyped/DefinitelyTyped/blob/master/types/glob/index.d.ts
    Can you link the JavaScript source?
    Rumon
    @msrumon
    @peterblazejewicz here it is: DefinitelyTyped/DefinitelyTyped#45882.
    cherryblossom000
    @cherryblossom000
    @peterblazejewicz source
    Peter Wagenet
    @wagenet
    anyone know why DefinitelyTyped/DefinitelyTyped#45978 didn't generate a new release?
    Peter Wagenet
    @wagenet
    @chriskrycho who should I talk to?
    Piotr Błażejewicz (Peter Blazejewicz)
    @peterblazejewicz

    Peter Wagenet @wagenet 22:25
    anyone know why DefinitelyTyped/DefinitelyTyped#45978 didn't generate a new release?

    There is usually a little drag wiht the cache, your changes seems to be now in the wild:
    https://unpkg.com/@types/ember__object@3.12.1/evented.d.ts

    Peter Wagenet
    @wagenet
    @peterblazejewicz ah, thanks! I wouldn't have mentioned it if it didn't say to bring it up in the README
    speaking of which, there doesn't seem to be a readme anymore? https://www.npmjs.com/package/@types/ember__object
    Doesn't matter much to me, but thought you might care