These are chat archives for DefinitelyTyped/DefinitelyTyped

15th
Nov 2016
spacejack
@spacejack
Nov 15 2016 03:31
How should I handle providing new types for a newer version of a JS library? howler.js has types for v1.x of the library, I'd like to add v2.1 (which is a very different API)
Pat Sissons
@patsissons
Nov 15 2016 03:32
basically fork and PR. target master for typings style and types-2.0 for npm @types style
spacejack
@spacejack
Nov 15 2016 03:33
@patsissons thanks. So I create a types-2.1 branch so npm will recognize the version that way?
err, howler-2.1 I guess
Pat Sissons
@patsissons
Nov 15 2016 03:35
you can probably just create a howler branch, the version doesn't need to be in the branch name
types-2.0 is for targetting typescript 2
spacejack
@spacejack
Nov 15 2016 03:35
oh
I'm wondering how to preserve the 1.x types for people using 1.x of the lib
Pat Sissons
@patsissons
Nov 15 2016 03:36
just make sure you base your branch on which ever style you want to conform to
well, if you base on master i believe the ts team does a manual merge over to types-2.0 every week or so
spacejack
@spacejack
Nov 15 2016 03:36
sorry, I mean for users of howler 1.x
Pat Sissons
@patsissons
Nov 15 2016 03:37
they should get versioned organically
spacejack
@spacejack
Nov 15 2016 03:38
From the comments in the .d.ts file?
Pat Sissons
@patsissons
Nov 15 2016 03:38
typings uses the timestamp or commit hash (i forget) and @types is npm versioned
i think the header is for @types style but not really sure on that
spacejack
@spacejack
Nov 15 2016 03:40
ok thanks :)