Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Jack Bates
    @jablko
    Yes sorry different topic
    We're in a window between releasing microsoft/DefinitelyTyped-tools@dfb84eb, which includes microsoft/DefinitelyTyped-tools#93, and landing #44091, which I've now marked ready for review
    The DefinitelyTyped-tools change enables it to find files that previously required exceptions, and #44091 removes those exceptions
    The changes are interdependent: Regardless of which lands first, there's a window of CI failure
    Isiah Meadows
    @isiahmeadows
    Okay. May be worth mentioning in the issue, then, along with the right course of action afterwards.
    Jack Bates
    @jablko
    microsoft/DefinitelyTyped-tools@dfb84eb has been released and is causing a CI outage
    #44091 is pending maintainer review
    @orta @weswigham
    icy0307
    @icy0307

    Hi there! I am trying to use generic type in React.ComponentClass's props
    The example I have right now is:

    import React from 'react';
    interface A {
        a: number;
    }
    
    
    function foo(param: React.ComponentClass<A>) {
        return param;
    }
    
    function foobar<T extends A >(param: React.ComponentClass<T>) {
        foo(param);
    }

    But it faile as this issue discribed: DefinitelyTyped/DefinitelyTyped#47824 Does anybody know how to solve this problem?

    Nathan Shively-Sanders
    @sandersn
    Hi everyone, I just set up a Definitely Typed channel on the Typescript Community discord. Since discord is already a hub of Typescript discussion, I figured it would be easier for us on the team to notice when there is a problem since more of us are there hanging out. I'll make announcements over there in the future as well.
    Sunbreak
    @Sunbreak
    Where could we find the discord?
    Isiah Meadows
    @isiahmeadows
    @Sunbreak I found a link here: https://www.typescriptlang.org/community
    Sunbreak
    @Sunbreak
    👍
    Piotr Błażejewicz (Peter Blazejewicz)
    @peterblazejewicz
    :+1:
    Barak Inbal
    @BrkCoder
    Hey guys, I am really love this repo and I would like to contribute to this repo . I am developing in angular & typescript and I would like to know if there are some js libraries which still need a typed definitions of typescript? I would be happy to help but I need an information about the missing parts...
    Krisztián Balla
    @krisztianb
    @BrkCoder you can find type definition requests here: https://github.com/DefinitelyTyped/DefinitelyTyped/labels/Definition%3ARequest
    mbergwall2222
    @mbergwall2222
    Hey guys. The repo is missing some types from HSLColor from d3-color. What's the best way for me to add these without going through the long PR process? I really don't have time to develop my own PR.
    Specifically the formatHex prototype from HSLColor -- it returns a string.
    Isiah Meadows
    @isiahmeadows

    @mbergwall2222 You could always use the web interface to add those on your own fork, create a subsequent commit with tests, and then create a PR that way. I've done that a few times on other projects where I felt excessively lazy. But in any case, there really isn't a way to avoid the PR process - it's there for a reason.

    I'm not a DT maintainer or a TS core dev, just someone somewhat familiar with their process and has been active in OSS in general for a while.

    Ghost
    @ghost~5f75a8e0d73408ce4ff06899
    Hi. I've just experienced a problem while using @types/mongoose. The second parameter for method Model.updateOne(filter, doc) should accept objects within an object (such as { $inc: { count: 1 } }), however its typing doesn't allow this usage (although it's supported by Mongoose and is being widely used now).
    It pops out an error that says error TS2322: Type 'Number' is not assignable to type 'undefined'.
    Ghost
    @ghost~5f75a8e0d73408ce4ff06899
    I think this is unexpected and needs to be repaired. Could anyone please take a look?
    Tomasz Pluskiewicz
    @tpluscode
    hello. I would like DT maintainers to have a look at DefinitelyTyped/DefinitelyTyped#48399
    we are considering moving a package outside of DT. that package does not describe code but rather a JS specification
    LAURENS Jérôme
    @jlaurens
    Hi there,
    I am switching to typescript and I like it a lot. Unfortunately, while translating my chai test units from js to ts, I am facing a lot of problems that I have to manually solve with many 'as any', which is highly unsatisfactory! I found many problems in the definitions and I kind of solve them but I need some advice (by the authors). Anyone interested in discussing these points with me?
    Kyle Albert
    @kalbert312
    Need someone to take a look at DefinitelyTyped/DefinitelyTyped#46082 . Stuck in abandonment loop.
    seb
    @zedryas
    Hello all,
    For @types/mongodb any plans are set to include the aggregation pipeline as the update argument in the update{one|many} and the findOneAndUpdatemethods ?
    Tomasz Pluskiewicz
    @tpluscode
    I write types for an express package which uses other express middleware. as such I will not import any types from the dependencies. can I add those @types/dependency in package.json?
    Tomasz Pluskiewicz
    @tpluscode
    can anyone explain why this build fails? DefinitelyTyped/DefinitelyTyped#48859
    the referenced types are all there
    Tomasz Pluskiewicz
    @tpluscode
    anyone?
    Loic LE PENN
    @LoiKos

    Hello all ! I tried using @types/koa-session with Koa but i have extends Koa context via

    declare module 'koa' {
      interface Context {
      }
    }

    and i get the following error :

    Argument of type 'import<DefaultState, Context>' is not assignable to parameter of type 'import<DefaultState, DefaultContext>'.
      Types of property 'middleware' are incompatible.

    how can i handle that ?

    Loic LE PENN
    @LoiKos
    Find out just extend BaseContext instead of Context
    Logan
    @logbaseaofn
    Hi, I am having an issue with @types/bezier-js... More can be found DefinitelyTyped/DefinitelyTyped#49185, and in my repo reproducing the problem here
    evan-hughes
    @evan-hughes
    I have a PR that has been waiting for approval for ~20 days. I think it's ready to go: DefinitelyTyped/DefinitelyTyped#48757 - if I'm missing anything, can someone let me know? As far as I can tell, it has passed CI checks.
    pyoor
    @pyoor
    Can one of the maintainers take a look at DefinitelyTyped/DefinitelyTyped#49236 Looks like the original maintainer is not responding.
    Samuel Laulhau
    @lalop
    Hello everyone, I may have find an error in jsforce type definition, According to the documentation
    conn.sobject("Contact")
      .find(
        // conditions in JSON object
        { LastName : { $like : 'A%' },
          CreatedDate: { $gte : jsforce.Date.YESTERDAY },
          'Account.Name' : 'Sony, Inc.' },
        // fields in JSON object
        { Id: 1,
          Name: 1,
          CreatedDate: 1 }
      )
      .sort({ CreatedDate: -1, Name : 1 })
      .limit(5)
      .skip(10)
      .execute(function(err, records) {
        if (err) { return console.error(err); }
        console.log("fetched : " + records.length);
      });
    Samuel Laulhau
    @lalop

    executecallback will receive an array of records

    According to the definitelytyped definition, find will return a Query<Array<Record<T>>> and when calling excuteon that query the wallback will receive an array of Array<Record<T>>

    So the final result will be an Array of Array of Record, There is too much array here I think
    Krisztián Balla
    @krisztianb
    I'd like to report a PR that could be deleted: DefinitelyTyped/DefinitelyTyped#49649
    It has become obsolete since this was merged into master: DefinitelyTyped/DefinitelyTyped#49706
    Please close/delete the first PR. Thank you. :+1:
    Kannan Goundan
    @cakoose

    I made a PR for "big.js" 9 days ago. None of the three definition owners have reviewed the PR yet. One of the definition owners explicitly stated they hadn't used the library in a couple years and didn't feel comfortable reviewing.

    How do I make progress on getting the PR merged?

    Christoph Gysin
    @christophgysin
    Can you guys successfully run the tests on current master? I'm getting:
    $ npm test serve-static
    
    > definitely-typed@0.0.3 test /home/chris/projects/DefinitelyTyped
    > dtslint types "serve-static"
    
    Error: /home/chris/projects/DefinitelyTyped/types/serve-static/serve-static-tests.ts:19:9
    ERROR: 19:9  expect  TypeScript@4.2 expected type to be:
      Response<any, number>
    got:
      Response<never, number>
    ERROR: 49:9  expect  TypeScript@4.2 expected type to be:
      Response<any, number>
    got:
      Response<never, number>
    
        at /home/chris/projects/DefinitelyTyped/node_modules/dtslint/bin/index.js:206:19
        at Generator.next (<anonymous>)
        at fulfilled (/home/chris/projects/DefinitelyTyped/node_modules/dtslint/bin/index.js:6:58)
    npm ERR! Test failed.  See above for more details.
    Christoph Gysin
    @christophgysin
    It seems serve-static is currently broken, and CI will fail for anything that triggers its tests. Could someone merge the fix? DefinitelyTyped/DefinitelyTyped#50061
    Christoph Gysin
    @christophgysin
    ^Merged!
    Christoph Gysin
    @christophgysin
    And now it seems morgan tests are broken :eyes: DefinitelyTyped/DefinitelyTyped#50065
    Christoph Gysin
    @christophgysin
    Who are the DT maintainers? Is there someone I can ping to get DefinitelyTyped/DefinitelyTyped#50065 merged which currently breaks CI?
    Kannan Goundan
    @cakoose

    I'd like to report an issue with the review flow. I believe typescript-bot requested a re-review unnecessarily in my PR: DefinitelyTyped/DefinitelyTyped#50378

    What happened:

    1. I submitted a PR for some type definitions.
    2. Maintainer 1 (doberkofler) accepted.
    3. Maintainer 2 (eps1lon) requested changes.
    4. I updated the PR with the requested changes.
    5. Maintainer 2 accepted.
    6. typescript-bot requested that Maintainer 1 re-review and accept the changes.

    Step 6 seems like a mistake, since Maintainer 2 has already accepted the latest changes.

    Sang
    @hantatsang

    Typescript Bot issue:

    • typescript-bot keep saying "I'm ready to merge this PR...", I commented "Ready to merge" as requested but typescript-boot respond again with the same message "I'm ready to merge this PR...". This seems to go in a loop and I can't merge the PR.

    The bot seems to be broken here?

    tsbot.jpg

    Sang
    @hantatsang

    Typescript Bot issue:

    • typescript-bot keep saying "I'm ready to merge this PR...", I commented "Ready to merge" as requested but typescript-boot respond again with the same message "I'm ready to merge this PR...". This seems to go in a loop and I can't merge the PR.

    The bot seems to be broken here?

    tsbot.jpg

    Tried again and the PR is merged now. All good

    Eli Barzilay
    @elibarzilay
    There was a failure due to some recent changes which was resolved around the time the above was reported, hopefully these things are fine now.