https://github.com/DefinitelyTyped/DefinitelyTyped/projects/5#column-7552922
@nulogy/components, but it links me to the NPM package page for nulogy__components)
:point_up: May 28, 2020 3:35 PM
Another issue with new linter is, it seems to be too restrictive, for example it reports now use of
@defaultwithin JSDoc:/** * font version string, can be Version x.y or x.y * @default 'Version 1.2' */ version?: string;this will make linter to throw check error:
The 'no-redundant-jsdoc-2' rule threw an error in
The
@defaultis a nice way to provide valid information to type consumer.
So is it okay to use @defaultin declaration files, or is there a better way?
So is it okay to use @defaultin declaration files, or is there a better way?
This is OK, there were issue with changes done in the linters, not with the JSDoc. The linter reports supoerflous information only from JSDoc (param type/return type) - but only in the context of TS, JSDoc itself is here and rules the seas.
Sure thing, appreciate your patience @peterblazejewicz 😅
Were you able to look into my comment about the functions exported from the namespace? I couldn’t find any evidence that those still exist in the source. I’d like to get that cleared up since I think it may be an additional source of confusion for the PR author.
Were you able to look into my comment about the functions exported from the namespace? I couldn’t find any evidence that those still exist in the source. I’d like to get that cleared up since I think it may be an additional source of confusion for the PR author.
Yes, looked into that yesterday, but decided to not post yet another comment, you probably understand why. There is a simple construct now in this module, just Email class with bunch of async/non-async mehtods,and a namespace supporting types/interfaces.
Rumon @msrumon 14:56
Reporting one missing function overhead declaration of ffmpeg package: save() function also works with promise, so adding another overhead would be helpful. Can anyone do it please? I'm not expert in type definition writing, that's why I won't submit PR.
can you create an isssue and put a reference to me? @peterblazejewicz I'll try to fix this, thanks!
hello all. I am trying to update types on deftyped, and I am getting
Error: At 3:68 : Expected one of
/(, )|(,?\r?\n\/\/\s\s+)/
/\r?\n\/\/ Definitions: [^\r\n]+/
at Object.parseHeaderOrFail (/home/elucian/DefinitelyTyped/node_modules/@definitelytyped/header-parser/dist/index.js:21:15)what is this from?
ERROR: Permission to DefinitelyTyped/DefinitelyTyped.git denied to ELI7VH.
fatal: Could not read from remote repository.
If a module exports a function like this:
function f() {}
module.exports = f
module.exports.f = fis this the appropriate way to type it?
export = moduleName
declare const moduleName: typeof f & {f: typeof f}
declare function f(): void
declare namespace moduleName {
// exported types
}if a function returned some private variables, would you include the min the type:
If these are truly private (within a module or class), do not add them to the type definition. If they seem just for a convention, add them to type definition, but observe if there is a JSDoc comment with @private or just a comment that express author intent to not expose the api. Check in the module README, if these are used. Also check the tests, sometimes those private are intended to be used in tests only, hence the convention. Really depends on the source API
https://github.com/definitelyTyped/DefinitelyTyped/blob/master/types/glob/index.d.ts
Can you link the JavaScript source?
Peter Wagenet @wagenet 22:25
anyone know why DefinitelyTyped/DefinitelyTyped#45978 didn't generate a new release?
There is usually a little drag wiht the cache, your changes seems to be now in the wild:
https://unpkg.com/@types/ember__object@3.12.1/evented.d.ts
DefinitelyTyped/DefinitelyTyped#45801 (this is the one I think)
static scaleService: {
updateScaleDefaults: (type: ScaleType, updates: ChartScales) => void;
};
