Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 04 16:07
    JaredTate commented #62
  • Aug 04 15:02
    JaredTate synchronize #62
  • Aug 04 14:47
    JaredTate synchronize #62
  • Aug 04 14:44
    JaredTate synchronize #62
  • Aug 04 06:19
    JaredTate synchronize #62
  • Aug 04 05:10
    JaredTate synchronize #62
  • Aug 04 05:03
    JaredTate synchronize #62
  • Aug 04 04:55
    JaredTate synchronize #62
  • Aug 04 04:53
    JaredTate synchronize #62
  • Aug 04 04:45
    JaredTate synchronize #62
  • Aug 04 04:29
    JaredTate synchronize #62
  • Aug 04 04:24
    JaredTate synchronize #62
  • Aug 04 04:18
    JaredTate synchronize #62
  • Aug 04 03:59
    JaredTate synchronize #62
  • Aug 04 03:48
    JaredTate synchronize #62
  • Aug 04 03:47
    JaredTate synchronize #62
  • Aug 04 03:23
    JaredTate synchronize #62
  • Aug 04 03:17
    JaredTate synchronize #62
  • Aug 04 02:41
    JaredTate synchronize #62
  • Aug 04 02:08
    ChillingSilence commented #62
Jared Tate
@JaredTate
Screen Shot 2021-08-01 at 11.06.29 AM.png
Screen Shot 2021-08-01 at 11.16.26 AM.png
Screen Shot 2021-08-01 at 11.17.28 AM.png
Screen Shot 2021-08-01 at 11.19.16 AM.png
Screen Shot 2021-08-01 at 11.19.42 AM.png
Screen Shot 2021-08-01 at 11.19.58 AM.png
So as you can see its now brining in the dark mode from my mac, which is a theme change BTC made. However our existing wallet theme option choices are still there.
It also super handy you can create and manage multiple wallets from GUI directly now.
Still some QT bugs to sort for sure, so this is by no means a stable version.
Jared Tate
@JaredTate
Lets start a QT theme discussion thread here. I personally like the idea of giving users multiple theme options. I dark mode to match OS, white, blue, gray maybe?
2 replies
CypherX86S
@CypherX86S
Hi There Jared and the Digibyte community
2 replies
Im new to the community
How can I get started with my node I'm testing the network at the moment but I want to get it up and running perfectly
Jared Tate
@JaredTate
Thanks for offer to help test. So as of now the 8.22 upstream merge is being worked on here by a group of us: https://github.com/JaredTate/digibyte/tree/8.22develop
However we are not yet ready for a test release or version.
Before that happenes all our work needs to be submitted to the main Digibyte-core account in a pull request for others to test and review.
But anyone can try building from that branch, but there are still several issues being worked on. Tests and some GUI items. So we have been trying to focus on different areas so we don’t work over top of each other.
We are getting close, but perhaps a few more days of sorting some issues and double checking.
Also this new version has new reqs for a macOS build env so make sure to follow the build-osx in /doc folder. Which we should probably refine and trim.
Still working on getting “make deploy” to work as well ater “make”.
Jared Tate
@JaredTate
Screen Shot 2021-08-01 at 4.16.41 PM.png
Yay!! We got a successful sync in about 3 hours from brand new wallet.
Note version bits issue to be sorted.
Screen Shot 2021-08-01 at 4.26.39 PM.png
And it succesfully sent and recieved… sweet. Always a good sign. (Anyone trying to compile this please note its not a release and very much a test wallet.) There have been a lot of changes.
ycagel
@ycagel
Thanks to everyone for all the hard work and testing! Great job.
Sandy Budiman S
@san2ok
Have a big heart everyone.. you guys are the heart of this DGB. (Quarel is inevitable in democracy and freedom of speech that @JaredTate fight for too. Thank You jared, please have a big heart)
1 reply
Jared Tate
@JaredTate

Anyone have experience with Openssl? Bitcoin removed OpenSSL for sha256, qt, and a few other places. It was used in many places. However, we still need it for Scrypt. Litecoin still uses it as well. I am all for fully removing it, but it takes doing and reworking.

https://github.com/JaredTate/digibyte/blob/feature/8.22.0/src/crypto/scrypt-sse2.cpp#L34

https://github.com/litecoin-project/litecoin/blob/master/src/crypto/scrypt-sse2.cpp#L37

5 replies
So @gto90 has opened a WIP branch for 8.22.0 that we are working to get all tests passing before asking others for input and testsing. This is far from a release branch so please treat it as a test branch. We need to get it stable and sorted before pressing on with others fixes, updates and features. If anyone has experience with git worlflows we are trying to get the mac tests to pass put they keep running into an openssl issue as apple depricated openssl in 2016. You can check these tests and branch here: DigiByte-Core/digibyte#62
Murat
@makyurt
I'm not entirely sure but I think Barry already rewrote Scrypt to use libsecp256k1 instead of openssl.
saltedlolly
@saltedlolly

From Josiah's article:
"Barry had also done some other major work with things like the removal of OpenSSL. Bitcoin Core had removed the OpenSSL library from 0.19, which the Scrypt algorithm uses. This is part of what had caused so many issues with 8.19 for Jared back in January of 2020, and Akshaynexus had attempted to readd as a “quick fix” to get things working again. Instead of taking the quick route, Barry implemented a single-file scrypt copy, which had an integrated sha256d function, which got us by, so that OpenSSL would no longer be required. This was no mean feat, and not the kind of thing some junior coder could accomplish (We saw relatively skilled people simply trying to add it back in), nor is it the sort of thing someone could ‘fluke’. This is the kind of thing that requires a LOT of skill and intricate knowledge of how all of the pieces tied together, and making the hashes match what they should be.
We had a fresh implementation, with new code, and outside of Odocrypt, DigiByte had not seen this kind of improvement in the last half a decade."

He did this in November/December I believe.

To be honest, the fact that Jared doesn't know this kind of proves Josiah's point.
Jared Tate
@JaredTate
I did read that, I have heard that, however we have never seen a Pull Request for this in 10 months. If this is infact the case, we would absolutely love Jo & Barry to help with this, as asked for a few times. We have never rejected this work, nor ignored it as we have not seen it put forward to be added to DigiByte-core. It is hard to add to code when its never been seen, or tested. The door is, and has been open for them to help us out here.
gto90
@gto90
#include <openssl/sha.h> is also used in hashquibit.h
It's not just Scrypt that needs work
Jared Tate
@JaredTate
Keep in mind a huge part of why Gitter is around now, is so we can all have open, transparent communitication, and we all can get on the same page. Massive misscommuitcation and private chats is why we found ourselves here in the first place.
Yes, qubit needs to be reworked as well. There were also a few more places it was used, but BTC v22 removed a few remaining ones in the Qt. However since we have some older Qt code for our custom themes we need to double check there, but I am not seeing any with an initial search.
gto90
@gto90
There are 19 locations in the code where openssl are being included. All need to be reworked if we are to remove that dependency. It's not just Scrypt
Jared Tate
@JaredTate
Actualy, I just did a quick search for “openssl” code wide and I see 249 occurances. So in fact it looks like a ton of tests are using it still. So those all need to be rewritten.
ycagel
@ycagel
Are there any long term effects for the way DigiByte operates if we rework or remove those 249 occurrences?
gto90
@gto90
searching for #include <openssl brings up just 19 locations for me
a lot of just searching openssl returns release notes and other references that we don't need to worry about
gto90
@gto90
Litecoin master branch is still using openssl
It looks like @barrystyle pulled the following from litecoin in April: litecoin-project/litecoin@02961f0
@barrystyle , is that all you did to yank OpenSSL from Scrypt or was there anything else?
Jared Tate
@JaredTate

Once again, I want to clearly state that an upstream merge from BTC v22 into our latest stable 7.17.3 is a massive undertaking, with lots of chances for things to go wrong. Which is why we started a new documented process to do this with many people. And have had great controbutions from @gto90 @ycagel @j50ng @SmartArray @digicontributer & others. So thank you all for being involved.

Things really are in a much better, more tested, more reviewed and better process now. Jo & Barry are and have always been free to be part of this effort. And are still welcome to contribute. The more hands on deck the better all this becomes.

People cannot get mad an volunteer, open source devs for not “finishing” ideas and code that have never been submitted as a Pull request for us to review for main code base. This is why we need to clear up all the misscommunication here in a polite, professional manner that is best for all of us and most importantly best for DigiByte in the end. All input is welcome here. And by achieving a group consenus everything is in a much stronger & better place.

Once we have a stable v8.22.0 feature branch, passing all tests (we are close) then we can see a flurry of PRs and fixes made to all known issues. And by all coming together as a team, combining, work expertise and ideas we will all make DGB the best its ever been togther. Jo, Barry and everyone else in here can help make that happen and a reality. The key is we do it all as a community, with complete transparency. Everyone wins.
gto90
@gto90
From reading the Litecoin Release Notes it appears their core developers have strong opinions about why OpenSLL is still required for strong randomness which is why they have chosen not to completely remove OpenSSL at this time.
gto90
@gto90
I would like to hear some knowledgable opinions on the risks or potential impacts of removing OpenSSL for an alternatively library.
3 replies
Jared Tate
@JaredTate
My personal video message to Josiah & the DigiByte blockchain community and rest of the developers. I address several issues, topics, and the division in the community head-on. I explain the current upstream merge process and more. Dropping this here so everyone has transparency, and hopefully we can all get aligned moving forward in the DGB protocol development process. https://www.youtube.com/watch?v=7dxdREYEGdQ