hey... so I went through the repo you sent and I can see couple of problems. Mainly it's about the way how things are coupled together... basically the View shouldn't know that there is such a thing as a service and it shouldn't even care about some module... view should only contain things like triggers... so ideally the
The creation of LoginModule should be done in the main class - basically you want to create the module in main and give it the view and the service. The module knows how to control everything and it knows that the view implements the interface so it can connect to the exposed trigger directly to the controllers
ILoginView interface should contain trigger called something like onLoginRequested which will be triggered when user clicks on the button (the setUsername method is fine, no coupling to outside world).The creation of LoginModule should be done in the main class - basically you want to create the module in main and give it the view and the service. The module knows how to control everything and it knows that the view implements the interface so it can connect to the exposed trigger directly to the controllers
login method (in my opinion it can even connect the trigger directly to the service call but that's just matter of taste)
regarding the injection of model into view... my idea would be to just inject the method, not the whole model... so something like:
//where you're creating the mappings
injector.mapClassNameToValue("Void->Void", model.someFunction);
//and in the view
@Inject
public var someFunction:Void->Void;
... and as always, sorry for the late response and thank you for your patience ;)
Thanks a lot! I updated my repository with some fixes...
I encounter with irritating problem, in My model I trying to fire a trigger, but it's not file anything for some reason the trigger is empty(in console I see:
I encounter with irritating problem, in My model I trying to fire a trigger, but it's not file anything for some reason the trigger is empty(in console I see:
Object { _inputs: Array[0] }) it worked before my changes :( please take a look.
I'm continue trying some things with hexMachina and I inject controller to my view:
@Inject
public var controller:IGeneratorController;When I tried in module insert the view into injector like following, it didn't worked:
this.getInjector().mapToValue(ITransferView, transferView);But this working:
this.getInjector().injectInto(transferView);what injectInto do?
And also, I should to "attach" to view into the module (i.e "mapToValue") and not the module to view (i.e "injectInto"), I'm afraid that I not exactly understand the "Injector" thing...
Hm... I think I understand the injector thing: each object that implements
IInjectorContainer get an injector object, but it's empty, so in the module I should "share" the module's injector with view's injector by this.getInjector().injectInto(transferView);, but if I want add something to module injector I just need to "map it in" by this.getInjector().map methods or by this._map etc...
so class that implements IInjectorContainer doesn't actually include injector... it just means that it can be injected into
the way map method works is following:
// code:
injector.map(ClassX).toValue(x);
// english:
// every time when something requires ClassX provide it this specific value x ... aka singleton pattern
//-----
// code:
injector.map(ClassX).toType(ClassX);
// english:
// every time when something requires ClassX create a new instance of ClassX and provide that instance ... aka factory pattern
so that's what map does
injector.injectInto(instance) does following... it takes the instance you're passing in and goes through all the pre-reflected data (generated by the IInjectorContainer described above) and does injector.getInstance(_whatever type is the public variable type_) which returns instances based on the mapping (or rules in other words) described above
so yes... you understand it pretty much correctly.... btw: in the module
this._map is just a shortcut for this._injector.map
btw: a small teaser - myself and @aliokan will host a hands-on hexMachina injector and DSL workshop at Haxe Summit in September and all the things I described above will be there with Rick and Morty themed coding examples and exercises ;)
Hey guys!
After some other tasks that I had to do I come back to hexMachina.
I solved this problem now but to understand, if I'm not mapping as singleton (i.e:
After some other tasks that I had to do I come back to hexMachina.
I solved this problem now but to understand, if I'm not mapping as singleton (i.e:
this._map(ILoginModel, LoginModel, '', true);) so when I'm doing _get (i.e: this._get(ILoginModel)) I'm getting a new instance of LoginModel? (lol when I'm writing this it's makes more sense)
btw: here's the mentioned workshop - https://github.com/DoclerLabs/hexWorkshop slides for each section are written in markdown in each corresponding folder (for example: hexInject/slides_content.md)
Which kind of problem?
@st3veV I wanted to put a link to the great rick and morty workshop, but didn't find it on Summit youtube channel: https://www.youtube.com/channel/UCGTson1aVohkJnbrqpNBXqg/videos?sort=dd&view=0&shelf_id=0
This is really excuting you guys remove a lit of reflections and such as we talked about a "light year" ago :)
Have this main class:
class Main extends App {
static function main() {
new Main();
}
override function init() {
super.init();
var injector = new Injector();
var vo = new VO();
vo.val = 'bar';
injector.map(VO).toValue(vo);
var container = new Container();
injector.injectInto(container);
}
}
This is VO:
class VO {
public var val = 'foo';
public function new() {
}
}
And Container:
class Container implements hex.di.IInjectorContainer {
@inject
var _vo:VO;
public function new() {
}
@PostConstruct
public function enter() {
trace("vo.val:" + _vo.val);
}
}
When it gets to Container.enter it fails with
Uncaught TypeError: Cannot read property 'val' of undefined
Thanks...that resolved the error, however now getting
Uncaught TypeError: mapping.getResult is not a function
import hex.di.Injector;
class Main {
static function main() {
new Main();
}
function new() {
var injector = new Injector();
var vo = new VO();
vo.val = 'bar';
injector.map(VO).toValue(vo);
var container = new Container();
injector.injectInto(container);
}
}class Container implements hex.di.IInjectorContainer {
@Inject
var _vo:VO;
public function new() {
}
@PostConstruct
public function enter() {
trace("vo.val:" + _vo.val);
}
}-cp src
-main Main
-lib hexdsl
-js main.js
output
vo.val:bar
I will open an issue