Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Ahmad K. Bawaneh
@vegegoku
I recommend creating the project using the cli tool..it will left a lot of work for you
howudodat
@howudodat

@howudodat If you are welling to gve this a test I have fixed the depndencies and added github actions to the repository, a HEAD-SNAPSHOT is in its way ... and if you test this and it works for you we can do a release

ok the app compiles now, so I think we are good there.

I also have the demo running, but I dont get a map in my app. I am probably missing a simple step. One that I can't deduce from the nalu framework

howudodat
@howudodat
here is how I am setting up the panel (BTW, this is the method I use for all of my panels. I left in all empty code in case you see something crazy wrong with the overall method)
public class PnlHomes extends FlexLayout implements IToolbarListener {
    protected FlexLayout content = FlexLayout.create();
    protected Map map = null;
    protected MapView mapview = null;

    public PnlHomes() {
        initUI();
    }

    protected void initUI() {
        content.setDirection(FlexDirection.TOP_TO_BOTTOM);
        this.appendChild(content);

        initHeader();
        initContent();

        Scheduler.get().scheduleDeferred(new Command() {
            @Override
            public void execute() {
                initPostVisible();
            }
        });
    }

    protected void initHeader() {}

    protected void initContent() {
        // create all the elements
        mapview = new MapView("homesmap");
        map = MapPresets.getOsmMap("homesmap");

        // set attributes necessary to the elements

        // add to the container
        content.appendChild(mapview.element());
    }

    protected void initPostVisible() {}
}
Ahmad K. Bawaneh
@vegegoku
I will check ..but as a quick confirmation... you sure the div size isnt too small to render the map?
howudodat
@howudodat
I tried setting the div width and height to 100%
Inspecting, I see nothing inside the div, it's as if there is nothing injected into the div
image.png
Ahmad K. Bawaneh
@vegegoku
ok I guess I know what is going on ..maybe
maybe you are attaching the map too eqarly before the div is actually attached
what is content btw?
howudodat
@howudodat
protected FlexLayout content = FlexLayout.create();
Ahmad K. Bawaneh
@vegegoku
for flexlayout you should append FlexItems
and can you please use the MapCard for now I need to understand something
howudodat
@howudodat
ok, I used a map card and the header is there. at first the body was 0px high even if I called MapCard#setHeight("90%"), so I set height to 1000px and the body is visible.
I decided to call map.updateSize(); and the console shows this error:
PluggableMap.js:1590 No map visible because the map container's width or height are 0.
        mapcard = new MapCard("homesmap");
        mapcard.setHeight("1000px");
        map = MapPresets.getOsmMap("homesmap");
        content.appendChild(FlexItem.create().appendChild(mapcard));
        Scheduler.get().scheduleDeferred(new Command() {
            @Override
            public void execute() {
                map.updateSize();
            }
        });
howudodat
@howudodat
ok, I got it working
I need to clean up the code and figure out what I did to get it working, then I'll post the code
howudodat
@howudodat
ok, here is the code that gets it to work, but I suspect that it's still not right
public class PnlHomes extends FlexLayout {
    protected Map map = null;
    protected MapView mapview = null;

    public PnlHomes() {
        initUI();
    }

    protected void initUI() {
        mapview = new MapView("homesmap");
        mapview.setWidth("100%");
        mapview.setHeight("100%");

        this.setHeight("900px");

        this.appendChild(FlexItem.create().appendChild(mapview).setFlexGrow(1));
//        this.appendChild(mapview);

        Scheduler.get().scheduleDeferred(new Command() {
            @Override
            public void execute() {
                map = MapPresets.getOsmMap("homesmap");
                map.updateSize();
            }
        });
    }
}
1: whether I wrap the view in flexitem makes no difference
2: nothing is visible unless I call setHeight with PIXELS. Why should I have to dictate pixel height? every screen could be different sizes. I just want the layout to handle this. it should be 100% of the viewport
howudodat
@howudodat
@TDesjardins what's the difference between ol.layer.Vector and ol.source.Vector? I'm trying to add some markers to the panel
Ahmad K. Bawaneh
@vegegoku
@TDesjardins you are right ..I didnt update the sample
Tino Desjardins
@TDesjardins

@TDesjardins what's the difference between ol.layer.Vector and ol.source.Vector? I'm trying to add some markers to the panel

OpenLayers distinguish between the type of layer and the type of datasources connected to layers (see https://openlayers.org/en/latest/doc/tutorials/concepts.html).

Do you know the example application of the domino map integration?
Tino Desjardins
@TDesjardins
By the way I have to update the example applications to new versions.
Jan
@HAC-jh
Hi @vegegoku Using the RC9 I've stumbled on an issue regarding a Select. Calling the select method with an existing SelectOption produces a "Maximum call stack size exceeded" exception because the Selects getValue method is called recursively
Ahmad K. Bawaneh
@vegegoku
yes there was a regression and I published an RC10
Jan
@HAC-jh
Ok, haven't seen this on the releases page of github. It mentiones still the RC9 as the last one. Thx for the info
Ahmad K. Bawaneh
@vegegoku
updated the github repo
Jan
@HAC-jh
:satisfied: thx
Jan
@HAC-jh
@vegegoku sorry to bother you again, just found another issue. The expand/collapse all icons aren't working anymore. This could be reproduced also with the demo. Just a short confirmation and I will create an issue
Ahmad K. Bawaneh
@vegegoku
I didnt update the demo yet too, plus I am runing a sample application with latest domino-ui and all works fine
Jan
@HAC-jh
https://demo.dominokit.org/components/tree?theme=indigo the expand icons expand only the childs of the selected parent, after collapsing all the expand all expands nothing anymore
Ahmad K. Bawaneh
@vegegoku
ok you mean the tree expand all/ collapse all
I thought you mean all collapse/expand functionality is broken
hmm.. I cant see any errors ..I will investigate
Jan
@HAC-jh
my fault, "the tree" was missing at my first message
Tino Desjardins
@TDesjardins

1: whether I wrap the view in flexitem makes no difference
2: nothing is visible unless I call setHeight with PIXELS. Why should I have to dictate pixel height? every screen could be different sizes. I just want the layout to handle this. it should be 100% of the viewport

Actually you don't have to dictate the pixel height but you have to ensure that the map container has a size when the map will be rendered. Especially with responsive layouts the height of containers and or it's parents is initially 0. If the map is drawn at this time the map also have a size of 0.

Maybe also this resource is interesting for you: https://www.freecodecamp.org/news/html-page-width-height/
Ahmad K. Bawaneh
@vegegoku
Yes also the size is 0 if the element is not attached yet and you draw the map before that, so always make sure the element is attached first, domino-ui has a nice way to do things on attach/detach
Tino Desjardins
@TDesjardins

Yes also the size is 0 if the element is not attached yet and you draw the map before that, so always make sure the element is attached first, domino-ui has a nice way to do things on attach/detach

@vegegoku Good point!

Ahmad K. Bawaneh
@vegegoku
@/all a new domino-mvp sample have been upload, find it here https://github.com/DominoKit/bookstore
the wiki should be updated by the end of next weekend
Ahmad K. Bawaneh
@vegegoku
@/all a new release of domino-cli have been released https://github.com/DominoKit/domino-cli/releases/tag/1.0.0-RC5
please follow the instructions in the readme to create gwt/domino project. looking forwrd for your feedback
Nick Gaens
@NickGaens

Hey guys.

@vegegoku It seems like the RC8 issue DominoKit/domino-ui#582 has come back in RC9 or 10:

Screen Shot 2021-10-20 at 2.03.07 PM.png
Initially the tree is totally fine, but after using the search function, it gets a bit messed up like shown in this screenshot.
Also, there are various gaps in the tree at times after clearing the search filter box.
I'll try to screenshot those.
It's ... weird .... perhaps you can make something out of it.