Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 09:08
    happyhua synchronize #668
  • 07:43
    happyhua synchronize #668
  • Jun 27 15:32
    vegegoku closed #666
  • Jun 26 12:10
    happyhua synchronize #668
  • Jun 26 11:50
    happyhua synchronize #668
  • Jun 26 11:29
    happyhua opened #668
  • Jun 25 17:49
    vegegoku commented #634
  • Jun 25 17:43
    vegegoku closed #655
  • Jun 25 17:43

    vegegoku on development

    fix #655 Chips of TagsInput sho… (compare)

  • Jun 25 17:35
    vegegoku closed #667
  • Jun 25 17:35

    vegegoku on development

    fix #667 It is impossible to se… (compare)

  • Jun 25 16:03
    vegegoku commented #666
  • Jun 25 16:02

    vegegoku on development

    fix #666 Odd or Unexpected Resp… (compare)

  • Jun 25 15:41
    vegegoku commented #634
  • Jun 25 15:41
    vegegoku commented #634
  • Jun 25 14:03
    vegegoku commented #666
  • Jun 25 09:45
    vegegoku closed #665
  • Jun 25 09:42

    vegegoku on development

    fix #665 Select dropdown menu b… (compare)

  • Jun 25 09:24
    vegegoku closed #664
  • Jun 25 09:00

    vegegoku on development

    fix #664 Memory leak in DataTab… (compare)

Jan
@HAC-jh
Hi @vegegoku Using the RC9 I've stumbled on an issue regarding a Select. Calling the select method with an existing SelectOption produces a "Maximum call stack size exceeded" exception because the Selects getValue method is called recursively
Ahmad K. Bawaneh
@vegegoku
yes there was a regression and I published an RC10
Jan
@HAC-jh
Ok, haven't seen this on the releases page of github. It mentiones still the RC9 as the last one. Thx for the info
Ahmad K. Bawaneh
@vegegoku
updated the github repo
Jan
@HAC-jh
:satisfied: thx
Jan
@HAC-jh
@vegegoku sorry to bother you again, just found another issue. The expand/collapse all icons aren't working anymore. This could be reproduced also with the demo. Just a short confirmation and I will create an issue
Ahmad K. Bawaneh
@vegegoku
I didnt update the demo yet too, plus I am runing a sample application with latest domino-ui and all works fine
Jan
@HAC-jh
https://demo.dominokit.org/components/tree?theme=indigo the expand icons expand only the childs of the selected parent, after collapsing all the expand all expands nothing anymore
Ahmad K. Bawaneh
@vegegoku
ok you mean the tree expand all/ collapse all
I thought you mean all collapse/expand functionality is broken
hmm.. I cant see any errors ..I will investigate
Jan
@HAC-jh
my fault, "the tree" was missing at my first message
Tino Desjardins
@TDesjardins

1: whether I wrap the view in flexitem makes no difference
2: nothing is visible unless I call setHeight with PIXELS. Why should I have to dictate pixel height? every screen could be different sizes. I just want the layout to handle this. it should be 100% of the viewport

Actually you don't have to dictate the pixel height but you have to ensure that the map container has a size when the map will be rendered. Especially with responsive layouts the height of containers and or it's parents is initially 0. If the map is drawn at this time the map also have a size of 0.

Maybe also this resource is interesting for you: https://www.freecodecamp.org/news/html-page-width-height/
Ahmad K. Bawaneh
@vegegoku
Yes also the size is 0 if the element is not attached yet and you draw the map before that, so always make sure the element is attached first, domino-ui has a nice way to do things on attach/detach
Tino Desjardins
@TDesjardins

Yes also the size is 0 if the element is not attached yet and you draw the map before that, so always make sure the element is attached first, domino-ui has a nice way to do things on attach/detach

@vegegoku Good point!

Ahmad K. Bawaneh
@vegegoku
@/all a new domino-mvp sample have been upload, find it here https://github.com/DominoKit/bookstore
the wiki should be updated by the end of next weekend
Ahmad K. Bawaneh
@vegegoku
@/all a new release of domino-cli have been released https://github.com/DominoKit/domino-cli/releases/tag/1.0.0-RC5
please follow the instructions in the readme to create gwt/domino project. looking forwrd for your feedback
Nick Gaens
@NickGaens

Hey guys.

@vegegoku It seems like the RC8 issue DominoKit/domino-ui#582 has come back in RC9 or 10:

Screen Shot 2021-10-20 at 2.03.07 PM.png
Initially the tree is totally fine, but after using the search function, it gets a bit messed up like shown in this screenshot.
Also, there are various gaps in the tree at times after clearing the search filter box.
I'll try to screenshot those.
It's ... weird .... perhaps you can make something out of it.
Frank Hossfeld
@FrankHossfeld
@NickGaens Just checked the demo app. It uses Domino-UI version 1.0.0-RC10. Doing a search inside the navigation tree works as expected. Please, can you check, that there is no additional coding from your side, that causes the error. As far as I can see fro your video, it looks like an element did get inivisible inside a tree item (that should be invisible) Please can you chek the generate code for that element.
Nick Gaens
@NickGaens
@FrankHossfeld Sure, I'll reiterate my code, but I'm quite sure no such custom code exists inside my project. I'll post my findings here later today.
Jan
@HAC-jh

ok you mean the tree expand all/ collapse all

Hi @vegegoku , did you have the chance to investigate regarding that problem?

Frank Wynants
@FrankW76

@FrankHossfeld Did you run the demo app on your own pc? Or are you talking about https://demo.dominokit.org/home?

In the latter case how do you know this is RC10?
Cause the online demo states : Last build on : 2021-10-10T07:04:46Z

Which is before RC10 was released.

Ahmad K. Bawaneh
@vegegoku
Demo is now updated to the latest and I can only confirm the expand all issue for tree component
Frank Hossfeld
@FrankHossfeld
Ah, ok, expected the demo is uptdate. Sorry, my fault.
Frank Hossfeld
@FrankHossfeld
@FrankW76 I took a look at your video. Thought, your were talking about the empty entries inside the tree when searching ...
Frank Wynants
@FrankW76

@FrankW76 I took a look at your video. Thought, your were talking about the empty entries inside the tree when searching ...

It is not my video.
I think @NickGaens is seeing a cache issue (and is in fact using RC10 with old domino css files)

Nick Gaens
@NickGaens
That seems to be the case.
I cleared the .m2/org/dominokit directory and (so I thought) the browser cache, but somehow there must have been cached CSS files still present. The issues I showed above in the screenshot and the recording are no longer.
Frank Hossfeld
@FrankHossfeld
sorry ... was confused, cause both of you are talking about tree issues ... :-)
Frank Wynants
@FrankW76
Do you guys have any hint on how to avoid some domino css files to get cached by the webserver.
image.png
For our own css files, everytime we compile we append a different ?version=1234 to the <link href tags in the index.html file
But for those imported by domino we cannot do this
And we often have the problem when updating domino. That the olds css files are being used
Ahmad K. Bawaneh
@vegegoku
why you cant do the same with domino css files?
Frank Wynants
@FrankW76
I think these are injected or something by domino code?
These are not in my index.html
Colin Alworth
@niloc132
the 304 means that your server is telling the browser "those files didnt change"
Frank Wynants
@FrankW76
Yeah I know.
But for some reason the browser is not telling the truth always.
Colin Alworth
@niloc132
how are you deploying? is it possible that your deployment mechanism (a war for example) is not updating the dates of the files when they are deployed? or that the server could use e-tags?
check the headers to be sure, i would be surprised if the client was the wrong one here
Frank Wynants
@FrankW76
In IIS just copying over the contents of the war...
Or in tomcat just normal deploy.