Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jul 29 12:35

    vegegoku on development

    Fixed calculation popup of Sele… (compare)

  • Jul 29 12:35
    vegegoku closed #565
  • Jul 29 12:34
    vegegoku milestoned #565
  • Jul 29 12:34
    vegegoku labeled #565
  • Jul 29 12:34
    vegegoku assigned #565
  • Jul 29 12:34
    vegegoku review_requested #565
  • Jul 29 11:45
    vegegoku edited #565
  • Jul 28 07:02
    FrankW76 commented #564
  • Jul 28 07:01
    FrankW76 commented #564
  • Jul 28 07:01
    FrankW76 opened #565
  • Jul 28 06:59
    FrankW76 opened #564
  • Jul 21 12:59
    vegegoku closed #561
  • Jul 21 12:58
    vegegoku milestoned #561
  • Jul 21 12:58
    vegegoku labeled #561
  • Jul 21 12:58
    vegegoku labeled #561
  • Jul 21 12:58
    vegegoku assigned #561
  • Jul 21 12:57

    vegegoku on development

    fix label floating after setRea… (compare)

  • Jul 21 12:57
    vegegoku closed #563
  • Jul 21 12:57
    vegegoku milestoned #563
  • Jul 21 12:57
    vegegoku labeled #563
Frank Wynants
@FrankW76
So the calculation is a little of.
And it switches too late to display on top.

I looked into the code of abstract select.
And did some changes....

The major thing I believe is that for the height it takes into account the complete height of the popup (including the search box, but this falls over the widget so should not be taken into account).

Frank Wynants
@FrankW76
image.png
With these changes it works perfect for me (also note the added line in the if).
But the -46 in line 946 should be the correct calculated height of the search box. Or it should take the height of correct element.
Should I create an issue for this?
Colin Alworth
@niloc132
can 46 be computed in some other way, rather than using a constant?
slightly different css could result in that number being incorrect, for example
sorry i think you were saying that, i was mostly commenting on the diff
Frank Wynants
@FrankW76
double popupHeight = popup.lastElementChild.getBoundingClientRect().height;
if (popup.getAttribute("popup-direction") != null && popup.getAttribute("popup-direction").equals("top")) popupHeight = popup.firstElementChild.getBoundingClientRect().height;
This is one solution I can come up with to get rid of the 46.
But also not really nice as popup-direction attribute can be null (so it seems because I get nullpointer exceptions).
And it assumes the needed element is the first, or last element.

double popupHeight = popup.getElementsByClassName("dropdown-menu").getAt(0).getBoundingClientRect().height;

This is better...

Frank Wynants
@FrankW76
So this is my proposal for change
image.png
Ahmad K. Bawaneh
@vegegoku
@FrankW76 Can you please make a PR and I will do the review and testing
Frank Wynants
@FrankW76
ok
Frank Wynants
@FrankW76
I created an issue : DominoKit/domino-ui#564
And I created a PR : DominoKit/domino-ui#565
Ahmad K. Bawaneh
@vegegoku
Thank you very much
Miroslav Pokorny
@mP1
you could rewrite the if -> if ("top"equals(popup.getAttribute("popup-direction") no need for the null test
Frank Hossfeld
@FrankHossfeld
+1
Ahmad K. Bawaneh
@vegegoku
Where do you see the null check, I dont see it in the PR
Frank Wynants
@FrankW76
That null check is not in the PR as I used another solution.
double popupHeight = popup.getElementsByClassName("dropdown-menu").getAt(0).getBoundingClientRect().height;
That is what I used instead, and what is in the PR.
Frank Wynants
@FrankW76
@vegegoku I see you closed PR DominoKit/domino-ui#565. I think you also need to change the state of the issue itself DominoKit/domino-ui#564 ? (maybe I have not linked the issue and the PR correctly?)
Or maybe you update the issue after a new release is released
Ahmad K. Bawaneh
@vegegoku
all you need to do normally to link the issue is to start the commit message with fix #issueNumberHere
I am busy right now, I will link it later, plus the development build failed
so need to check on that too
Dereck Haskins
@mumitr0ll_gitlab
The large UI project builds, but it is very large indeed. The DominoDo project does not build in maven
Is this a known problem
?
Colin Alworth
@niloc132
i dont think that demo gets maintained as much as the sampler
i just was using dominodo yesterday to test out the next version of j2cl-maven-plugin, and i used an older build so that i could be sure things worked properly
@mumitr0ll_gitlab is your issue that the output JS is too big? can you share some details about your project, setup?
Dereck Haskins
@mumitr0ll_gitlab
Not the JS, that isn't the problem. The problem is the size of the project proper, in the sense that the learning curve for giving to a colleague is very large. A simpler project would be helpful to share with others. The sampler is wonderful, but only if you understand GWT
Colin Alworth
@niloc132
right, samplers are often terrible apps to learn since the goal is to be as inconsistent as possible in your UI ;)
ok, so your request has nothing to do with your own app except that your own app is hard to learn, and you want "real" apps that are easy to learn?
Dereck Haskins
@mumitr0ll_gitlab
Got it -sorry to waste your time.
Colin Alworth
@niloc132
no no, not a waste
but i'm not the one you can help you
i just want to be sure i understand
(i mean, i could given some more free time, but i think we'd want the experts building the dominodo back to working again - i would be a good person to help a general gwt problem though, like compile issues or big output)
Frank Hossfeld
@FrankHossfeld
@mumitr0ll_gitlab not sure, what are you looking for, but this is a simply app with 4 screens. May be it helps: https://github.com/NaluKit/nalu-examples/tree/main/devkexample
Ahmad K. Bawaneh
@vegegoku
The demo apps uses the full domino stack ..creating a sample is as simple as creating one using domino-cli
Colin Alworth
@niloc132
@vegegoku i think the question is more about a well structured app with screens and such
Ahmad K. Bawaneh
@vegegoku
The demo should build with maven ..but I will confirm when I am back home
Well a well structured app will always need a learning curve ...I would always use domino-mvp to build such app
And btw ..there is a lot of info the domino repos wiki
Ahmad K. Bawaneh
@vegegoku
@/all I am glad to announce that recently we had big project that has its frontend build with domino stack gone live in 13 banks and we had zero reported issues during the go live.
Frank Hossfeld
@FrankHossfeld
😃