Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
KLuuKer
@KLuuKer
analysers in general, I always keep on missing some kind of analyser I should have because I am unable to find them
because this is my current list of analysers
AsyncFixer
Microsoft.CodeAnalysis.CSharp
Microsoft.CodeAnalysis.CSharp.Workspaces
Microsoft.CodeAnalysis.FxCopAnalyzers
Microsoft.DotNet.Analyzers.Compatibility
StyleCop.Analyzers
ToStringWithoutOverrideAnalyzer
and after some more searching (again) I found these
Microsoft.VisualStudio.Threading.Analyzers
IDisposableAnalyzers
ReflectionAnalyzers
Andrei Volkov
@zvolkov
Hello, a user checking in here. Last time I wanted to use these, they did not work with project.json - now that we are on Core 2.1 and back on MsBuild, this is expected to work OOB, right? I can just grab Microsoft.VisualStudio.Threading.Analyzers and use them as any other analyzer?
Andrew Arnott
@AArnott
@zvolkov project.json is dead. No new features being developed are tested with such projects. You can't target .NET Core 2.1 with project.json AFAIK.
But yes, you should be able to use MS.VS.Threading.Analyzers and use them as any other analyzer.
Andrei Volkov
@zvolkov
Okay cool. Looks like it just works OOB.
Sam Harwell
@sharwell
I archived AsyncUsageAnalyzers and changed the description to point to Microsoft/vs-threading
Andrew Arnott
@AArnott
Great. Should we publish one last package to nuget.org so the description or release notes can redirect folks who are hoping for a stable package there?
Sam Harwell
@sharwell
it doesn't use the easy deployment strategy now used by StyleCopAnalyzers and DocumentationAnalyzers
Andrew Arnott
@AArnott
Does nuget.org still allow you to interactively change package text in the web UI?
Johan Larsson
@JohanLarsson
think so yes
Andrew Arnott
@AArnott
then perhaps @sharwell can just edit the alpha-003 release description to let folks know where to look for the stable analyzers.
Johan Larsson
@JohanLarsson
Microsoft.VisualStudio.Threading.Analyzers is not awesome for discoverability
Microsoft.CodeAnalysis.AsyncAnalyzers
Andrew Arnott
@AArnott
@JohanLarsson I agree with your discoverability concern. We're actually planning to meet next week to discuss ways to improve this.
Johan Larsson
@JohanLarsson
:thumbsup:
Johan Larsson
@JohanLarsson
One way is to split out the general async stuff into Microsoft.CodeAnalysis.AsyncAnalyzers the stuff that was in this library
then reference it from Microsoft.VisualStudio.Threading
er no
they need to be in both, nasty breaking to move them
dunno if an analyzer nuget can specify a dependency on another analyzer nuget
can't see why it would not work
Andrew Arnott
@AArnott
Yes, analyzer packages can reference other ones. We already do this for a VS SDK analyzer package referencing the vs-threading analyzers.
Johan Larsson
@JohanLarsson
ok, that makes it easy then
maybe moving will still be a slight breaking if there is a ruleset