These are chat archives for DotNetAnalyzers/StyleCopAnalyzers

29th
Oct 2015
Yaakov
@yaakov-h
Oct 29 2015 04:21
Is there anything special I have to do to get MSBuild to report StyleCop.Analyzers failures? I have SA1614, SA1616 and SA1606 failures that MSBuild isn't reporting. Maybe related to #1659?
Ralf Beckers
@bexxx
Oct 29 2015 06:11
Any guidance on where I should add code that is shared between diagnostics and analyzers? Should I add a new assembly "StyleCop.Common"? For now, I only need an enum and a simple method.
Dennis Fischer
@pdelvo
Oct 29 2015 07:50
@bexxx add it to StyleCop.Analyzers and make it internal. You can use it in your codefix because internals are visible to the code fix project
Ralf Beckers
@bexxx
Oct 29 2015 08:32
Yeah, just realized it. My rebase was messed up and I could not see a reference to SC.Analyzers. Now that all works again.
Sam Harwell
@sharwell
Oct 29 2015 13:37
:+1:
@yaakov-h Are your violations being reported in the IDE when you open the file?
I'm definitely seeing SA1614 violations in the MSBuild output.
Sam Harwell
@sharwell
Oct 29 2015 16:45
:exclamation: @pdelvo Status page isn't showing hourglass for slow code fixes
Johan Larsson
@JohanLarsson
Oct 29 2015 17:34
master of emoticons :)
Sam Harwell
@sharwell
Oct 29 2015 18:36
We are in the process of adopting my emoji across the team at work
To promote positive and clear communication, here are some icons (and their definitions) which can be used:
  • :exclamation: The way I am interpreting the code, I am expecting a code change, bug filed, and/or clarification before moving forward
  • :question: I need clarification on something before I can know how to proceed
  • :bulb: idea or suggestion - take it or leave it, but it might be a strong idea to use - doesn't block a code review
  • :memo: I am adding additional context to what you see in the code review
  • :thought_balloon: I have a comment to make, but don't know what (if any) impact it should have - "thinking out loud"
  • :arrow_right: As a result of the previous discussion, here is the outcome - typically a direct answer to a previous question
Johan Larsson
@JohanLarsson
Oct 29 2015 19:37
nice
Sam Harwell
@sharwell
Oct 29 2015 20:31
@vweijsters Thanks for the reviews! There are two issues up that are probably perfect for you: #1706, #1707. Note that SA1101 and SX1101 should round-trip in any project:
  1. If you apply Fix in Solution for SX1101 to a project with no violations of SA1101, it should have no remaining violations of SX1101. If you then apply Fix in Solution for all the new SA1101 violations, you should end up with exactly the same code you started with.
  2. If you apply Fix in Solution for SA1101 to a project with no violations of SX1101, it should have no remaining violations of SA1101. If you then apply Fix in Solution for all the new SX1101 violations, you should end up with exactly the same code you started with.
Yaakov
@yaakov-h
Oct 29 2015 23:14
@sharwell yes, the SA violations showed up in Visual Studio, but not in MSBuild. I'll try put together a repro case early next week.
Sam Harwell
@sharwell
Oct 29 2015 23:21
Thanks :)