These are chat archives for DotNetAnalyzers/StyleCopAnalyzers

16th
Nov 2015
Andrew Arnott
@AArnott
Nov 16 2015 05:10
I don't think I'd avoid adopting Stylecop.Analyzers due to a few misbehaving code fixes. I'd just learn to avoid those particular code fixes, or at worst avoid them altogether.
Sam Harwell
@sharwell
Nov 16 2015 06:08
I worked on #1744 for a while today. Found a bunch of little bugs in UsingCodeFixProvider - two examples are #1770 and #1771.
The main problem with #1744 is the way it handles the following code when the user has requested using directives be placed outside the namespace declaration:
namespace System;
{
  using System.Threading;
  using Reflection;
}

The resulting code needs to look like this:

using System.Reflection;
using System.Threading;

namespace System;
{
}

But I'm finding it remarkably difficult to expand just the necessary parts of using directives when moving them.

Sam Harwell
@sharwell
Nov 16 2015 06:14
I'll probably send an initial pull request which does not handle this case (test is marked as ignore with a bug filed)
Sam Harwell
@sharwell
Nov 16 2015 15:46
@vweijsters UsingCodeFixProvider is ... "impressively complicated"
Vincent Weijsters
@vweijsters
Nov 16 2015 19:41
@sharwell That's a nice description :laughing:
Sam Harwell
@sharwell
Nov 16 2015 19:43
Here be :dragon:
Johan Larsson
@JohanLarsson
Nov 16 2015 19:45
frogs?
Sam Harwell
@sharwell
Nov 16 2015 20:17
hover tips escaped you
Vincent Weijsters
@vweijsters
Nov 16 2015 20:25
You probably mean: Here be :dragon::dragon::dragon::dragon::dragon::dragon::dragon::dragon::dragon::dragon:
:smile:
Johan Larsson
@JohanLarsson
Nov 16 2015 20:26
@sharwell so you think I'm a cheater? :)
Vincent Weijsters
@vweijsters
Nov 16 2015 20:27
More seriously if you manage to simplify that code, it would be more than welcome. I had a long struggle to get it working in its current state and I had no energy left to improve it.
Dennis Fischer
@pdelvo
Nov 16 2015 21:48
Have a look at the certificate: https://source.pdelvo.com/ :D
Sam Harwell
@sharwell
Nov 16 2015 22:09
Nice :D
Dennis Fischer
@pdelvo
Nov 16 2015 22:10
I think I forgot to include stylecop.pdelvo.com in my beta join request. So I have to wait for december 3rd I think
Sam Harwell
@sharwell
Nov 16 2015 22:17
How's the slow code fix detection coming along? :laughing: