These are chat archives for DotNetAnalyzers/StyleCopAnalyzers

25th
Nov 2015
Sam Harwell
@sharwell
Nov 25 2015 06:46
We may actually be on track for an RC 1 release on Dec. 1
Dennis Fischer
@pdelvo
Nov 25 2015 06:49
:+1:
Sam Harwell
@sharwell
Nov 25 2015 06:51
I encourage people to focus on feedback (issues) and code reviews (PRs) for the issues in the 1.0.0 Beta 17 and 1.0.0 RC 1 milestones, although of course we remain open to considering other items if someone feels passionate about working on them.
There are at least 16 items open in these.
If we land a 1.0.0 RC 1 on Dec. 1 and don't have any blocking bugs filed before Jan. 1, we could see a 1.0.0 stable as early Jan. 1 - although this does remain with a tentative target of Feb. 1 to allow for issues that could be filed in December.
Sam Harwell
@sharwell
Nov 25 2015 06:56
@pdelvo #702 and then #1820 and then possibly #1812 would be good for Beta 17. #1812 (the last one) is a bit more complicated but putting it in Beta 17 would provide leeway to figure out the kinks.
gnight y'all :smile: :sleeping:
Dennis Fischer
@pdelvo
Nov 25 2015 07:02
good night :D I just woke up
Sam Harwell
@sharwell
Nov 25 2015 13:18
@pdelvo Working on documenting the behavior of SA1509...

It seems the behavior I implemented is exactly equivalent to the following bold text:

An opening brace within a C# element, statement, or expression is preceded by a blank line, except when the previous token is a closing brace.

Sam Harwell
@sharwell
Nov 25 2015 14:36
@vweijsters Working on feedback in #1812. I'm thinking const should uniformly imply const static readonly.
Vincent Weijsters
@vweijsters
Nov 25 2015 19:51
@sharwell Seems logical, but I can't fully oversee the impact of it yet.
Sam Harwell
@sharwell
Nov 25 2015 20:14
The difference arises when you aren't sorting by "constant"
The way I have it now, you can mix const in with static readonly fields. Otherwise, you'd have to mix const with instance non-readonly fields
Vincent Weijsters
@vweijsters
Nov 25 2015 20:20
That is definitely the way to go then.
Dennis Fischer
@pdelvo
Nov 25 2015 20:53
dotnet/roslyn#7071
Sam Harwell
@sharwell
Nov 25 2015 21:30
Thanks @pdelvo