These are chat archives for EFox2413/initium-d

8th
Apr 2016
ConsiliumB
@ConsiliumB
Apr 08 2016 09:58
Nice! We should make a UI like i did in the stat tracker, with a enable/disable button for each feature:P
Elliot Fox
@EFox2413
Apr 08 2016 10:09
I've almost got that finished but the database update function im doing is pretty fucking stupid
your skills with making JSON would come in handy, especially for fine-tuning
ConsiliumB
@ConsiliumB
Apr 08 2016 10:21
Yeah no problem, ill take a look whenever you want
I also had a few functions only work in the script btw
cant remember what it was now, though.
Elliot Fox
@EFox2413
Apr 08 2016 10:29
hmm
one was disabled
did they throw errors?
ConsiliumB
@ConsiliumB
Apr 08 2016 10:30
dont think they did, just didnt work
Elliot Fox
@EFox2413
Apr 08 2016 10:30
hmm, there is a bug that hides the icons if there is no place to put the stats tracker icon
happens when the location text is too big
ConsiliumB
@ConsiliumB
Apr 08 2016 10:31
Hmm
Elliot Fox
@EFox2413
Apr 08 2016 10:39
super weird
if i have str.substr(index, value) it works fine
but if i have str.substr(index + 1, value) it returns nothing
ConsiliumB
@ConsiliumB
Apr 08 2016 10:47
lol
Elliot Fox
@EFox2413
Apr 08 2016 10:47
I thought a simple string check would be a simple way to do config values
but noo now it's the biggest fucking headache
seriously been staring at this function for like an hour
here see if you can't take a look haha
ConsiliumB
@ConsiliumB
Apr 08 2016 10:48
xD
yeah let me look
the issue is with the addChangeListener function
right now it looks stupid because ive been messing with it a lot so try to ignore the obvious fact that what it currently has won't work
pressing c will bring up the config popup
ConsiliumB
@ConsiliumB
Apr 08 2016 11:01
Ahh
Atleast i understand what you're doing now:P
Elliot Fox
@EFox2413
Apr 08 2016 11:06
fuck how could i be so stupid
stop looking consil
ConsiliumB
@ConsiliumB
Apr 08 2016 11:06
xD
Elliot Fox
@EFox2413
Apr 08 2016 11:07
index = "5" + 1;
/kill self
just need to throw in a parseInt
wow, and that took me an hour
ConsiliumB
@ConsiliumB
Apr 08 2016 11:09
happens to the best, lol
Elliot Fox
@EFox2413
Apr 08 2016 11:10
quiet errors are the worst
ConsiliumB
@ConsiliumB
Apr 08 2016 11:10
ikr
Elliot Fox
@EFox2413
Apr 08 2016 11:10
anyways converting the whole database storage to json would let us fine tune configuration more easily
ConsiliumB
@ConsiliumB
Apr 08 2016 11:10
Yeah, was thinking the same thing
Elliot Fox
@EFox2413
Apr 08 2016 11:11
ill push this to the repo and to master pretty soon, once i remove some of the debug lines of code
what do you think of the way the modularization works?
ConsiliumB
@ConsiliumB
Apr 08 2016 11:15
Its nice
never seen it done like this before
Wouldve been awesome if the other scripts were loaded dynamically though, if possible, so updates to the individual scripts would affect this aswell
Elliot Fox
@EFox2413
Apr 08 2016 11:18
you should change that to present tense
you can do it dynamically I just did a quick mockup for initialization
but in order to dynamically initialize and uninitialize scripts that means adding a remove function for every add function there is
the scripts can cross communicate by adding methods to oPublic
all scripts have access to Util.mkPopup for instance
Elliot Fox
@EFox2413
Apr 08 2016 11:23
oh btw, ID finally added the client side JS files to his repo, When I get a chance I'll get him in here and make him an admin so we can get access to his repo updates as well
via the activity sidebar
ConsiliumB
@ConsiliumB
Apr 08 2016 11:24
Sweet!
Again, nice work on the modularization - it took some time for me to see exactly how it worked
Elliot Fox
@EFox2413
Apr 08 2016 11:28
yeah me too
do you know the difference between function hello() {} and var hello = function() {};
they should both work even with the modularization however
ConsiliumB
@ConsiliumB
Apr 08 2016 11:29
i assume var hello function is called when the var is assigned?
lol
Yours was much more thorough. Will read that
Elliot Fox
@EFox2413
Apr 08 2016 11:31
actually if you look at your link, footnote 2 is the link i posted
haha
he basically ripped out all the comments and reposted it
ConsiliumB
@ConsiliumB
Apr 08 2016 11:31
haha you're right
Elliot Fox
@EFox2413
Apr 08 2016 11:31
footnote 3*
the var is assigned to the hello() function
the main difference seems to be that one is on runtime, and one is on compile time or something
the main thing I've noticed about it is that if you try to call a function before that function is defined you will get an undefined error
like if you try to call module.init() on line 1 but declare var module = function () {...}(); on line 200 you will get property .init() of undefined
ConsiliumB
@ConsiliumB
Apr 08 2016 11:33
ohh, that makes sense actually.
while if it was function module() it wouldnt matter
Elliot Fox
@EFox2413
Apr 08 2016 11:34
right
supposedly var module = function(){}; is better and a bit faster but I haven't really come to grok it.
anyways it's food for thought
ConsiliumB
@ConsiliumB
Apr 08 2016 11:36
Im learning as i go, so any food for thought is welcome:P Havent done too much JS before. Mainly PHP, Java and Python really
But JS is really intuitive imo, and easy to test, so its great.
Elliot Fox
@EFox2413
Apr 08 2016 11:37
yeah i'm used to java as well but JS is really similar
I'm a bit against the idea of being a webdev but It's fun right now
ConsiliumB
@ConsiliumB
Apr 08 2016 11:37
Yeah, noticed. JS is almost too forgiving though:P
Elliot Fox
@EFox2413
Apr 08 2016 11:38
yep
Elliot Fox
@EFox2413
Apr 08 2016 11:46
ok master branch updated
ConsiliumB
@ConsiliumB
Apr 08 2016 11:47
10 files changed. 18 additions, 118 deletion - nice:P
Elliot Fox
@EFox2413
Apr 08 2016 11:49
what really?
where do i see that lol
ConsiliumB
@ConsiliumB
Apr 08 2016 11:49
hover the commit in the sidebar
Elliot Fox
@EFox2413
Apr 08 2016 11:50
118 deletions might just be the metadata from all of those files X:D
ConsiliumB
@ConsiliumB
Apr 08 2016 11:50
Haha yeah, i was wondering if it was 118 chunks
Elliot Fox
@EFox2413
Apr 08 2016 11:50
still i think thats wrong
18 additions?
ConsiliumB
@ConsiliumB
Apr 08 2016 11:51
yeah, you added 18 lines of metadata
Elliot Fox
@EFox2413
Apr 08 2016 11:51
yeah if you click on compare it shows on github as Showing 14 changed files with 1,207 additions and 260 deletions.
ConsiliumB
@ConsiliumB
Apr 08 2016 11:51
oh?
Hehe, but this is sweet - obvious gitter was made for this
Elliot Fox
@EFox2413
Apr 08 2016 11:54
yep
im surprised how many other services it has the ability to integrate with
theres like 25 of them
ConsiliumB
@ConsiliumB
Apr 08 2016 11:54
Really? I assume only some of it is free, then?
Elliot Fox
@EFox2413
Apr 08 2016 11:55
yeah no clue how they make their money
ConsiliumB
@ConsiliumB
Apr 08 2016 11:56
Then this is closer to Slack than i thought. This is like exactly the same thing
chatrooms integrated with GitHub, VCS, google docs/drive, whatever.
Elliot Fox
@EFox2413
Apr 08 2016 11:57
doesn't slack cost $ tho
ConsiliumB
@ConsiliumB
Apr 08 2016 11:57
Exactly, you can only add like 5 things to a room before you have to pay
So how they pay for this is beyond me
Not complaining though:)
Elliot Fox
@EFox2413
Apr 08 2016 11:58
their basically the same thing from what i can tell in some basic google searches
they're
I hadn't heard of slack before though but remember using gitter a couple of years ago
damn forgot to remove the index numbers in the checkbox div... and didn't document press c for config
ConsiliumB
@ConsiliumB
Apr 08 2016 12:00
Oh lol
How professional:P
Elliot Fox
@EFox2413
Apr 08 2016 12:01
haha
ConsiliumB
@ConsiliumB
Apr 08 2016 12:01
Oh btw, do the scripts update automaticly when you add that @updateURL?
Havent checked if it actually happens yet
Elliot Fox
@EFox2413
Apr 08 2016 12:01
yeah they will if updates are enabled
also i changed the update url to point to a file only containing the metadata
that way the script smartly downloads just the metadata file, to see if there is an update
if there is it will then download the full js file
ConsiliumB
@ConsiliumB
Apr 08 2016 12:02
Great
Elliot Fox
@EFox2413
Apr 08 2016 12:09
there 828 deletions, lol
ConsiliumB
@ConsiliumB
Apr 08 2016 12:10
lol
Elliot Fox
@EFox2413
Apr 08 2016 12:11
are you imappy? you're not right?
ConsiliumB
@ConsiliumB
Apr 08 2016 12:12
I am, lol.
Elliot Fox
@EFox2413
Apr 08 2016 12:12
ahh you confused me because you changed your name
ConsiliumB
@ConsiliumB
Apr 08 2016 12:12
Yeah, at first i only planned to do some stuff with the map
so i made that. I thought i could host the files on github, but that didnt go so well
Elliot Fox
@EFox2413
Apr 08 2016 12:14
i see
I haven't forgotten about the mute admin notifications issue you commented on as imappy haha, planning on implementing it still
It's haunted me, I keep thinking oh man poor imappy feels like he got turned away because i told him to submit a pull request
XD
ConsiliumB
@ConsiliumB
Apr 08 2016 12:15
Hahahaa xD
I saw you overwrote the same function i did with your mute script, so i let it rest lol.
Elliot Fox
@EFox2413
Apr 08 2016 12:18
Yeah, the mute module will eventually be partially refactored into a ChatPlus module or something and then it will be easy to dynamically add whatever functions you want
but i haven't done much with the messenger system because it's not that appealing to me
I don't even use the mute function haha
ConsiliumB
@ConsiliumB
Apr 08 2016 12:18
haha xD
Elliot Fox
@EFox2413
Apr 08 2016 12:19
I think my priorities for now are set on code cleanup and the NoRefresh functionality
if you're working on anything though it makes sense to hold off on refactoring
brb getting beer
ConsiliumB
@ConsiliumB
Apr 08 2016 12:24
Only thing i have in the works is the minimap.
Elliot Fox
@EFox2413
Apr 08 2016 12:28
alright
ConsiliumB
@ConsiliumB
Apr 08 2016 12:28
But on that noe
note*, ID said he could dynamically load my minimap into a div if i made it embeddable
Elliot Fox
@EFox2413
Apr 08 2016 12:28
refactoring wouldn't change that since it's just a module insertion and some minor changes to config
ConsiliumB
@ConsiliumB
Apr 08 2016 12:28
Yeah i know
Elliot Fox
@EFox2413
Apr 08 2016 12:28
yeah if ID implements it then it's not necessary
he made his client side public also but I have my reservations about working on it until some further communication
ConsiliumB
@ConsiliumB
Apr 08 2016 12:33
Fair enough
Elliot Fox
@EFox2413
Apr 08 2016 12:34
well because ID seems pretty busy with other things, I don't see him being proactive in it. Which means unwilling to provide direction and unwilling to review pull requests and creation of issues
his main focus is on void space i figure
ConsiliumB
@ConsiliumB
Apr 08 2016 12:40
Yeah, most likely.
Even if its not, reviewing pull requests and especially providing direction takes alot of time
Which I bet ID would prefer to spend elsewhere. Who knows
Elliot Fox
@EFox2413
Apr 08 2016 12:46
yeah I mean at the least I'll attempt to PR some refactorings and documentation
and we'll see where it goes from there
ConsiliumB
@ConsiliumB
Apr 08 2016 13:03
Sounds like a plan.
Elliot Fox
@EFox2413
Apr 08 2016 14:33
submitted my first pull request
deleted 300 lines of whitespace...
ConsiliumB
@ConsiliumB
Apr 08 2016 14:33
lol
Elliot Fox
@EFox2413
Apr 08 2016 15:36

```What do I do as a reviewer?

I use a modified version of the single responsibility principle that applies to commits:

A commit should have one, and only one, change.

I try to follow steps like these:

Read the whole commit message. It should have no ands, ors, or buts. If it does, I kick it back to the author and request that the commit be split up into those pieces. Otherwise, I sear the commit message into my brain.```

Damn thats a hard pill to swallow

pfft so much for github markup, fuck you gitter
every single refactor commit i make has an 'and added some documentation'
Maybe that would be ok with this guy though
ConsiliumB
@ConsiliumB
Apr 08 2016 15:37
hmm
Elliot Fox
@EFox2413
Apr 08 2016 15:40