by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Jeremy Rice
@JRice
...That won't hit production until next deploy, though.
Jen Hammock
@jhammock
Thanks. It’s nice to keep up with that, but it’s not a high traffic area, so it can wait
JRice @JRice nods
Jen Hammock
@jhammock
Oh, I may have stumbled on a chunk of unlabeled language groups in the Tiger page, hang on...
they must have groups, because those are group codes, but they should also have labels
Jeremy Rice
@JRice
Well, "Q13359" for example, definitely isn't in the list, but we can add it / them....
Jen Hammock
@jhammock
(just the Q ones, that is. There are also some unmapped language codes on that page)
oh, interesting. They should all be here
Jeremy Rice
@JRice
Oh, interesting. Not what I expected to see in the database:
STAGING [4] pry(main)> Language.find_by_group 'Q13359'
=> #<Language:0x000055b6393ca8d0 id: 137, code: "xmf", group: "Q13359", can_browse_site: false>
Jen Hammock
@jhammock
the Q strings are all group codes, not language codes...
Jeremy Rice
@JRice
[nod] I do remember that, now.
So it looks like there are a bunch that either didn't make it to the translations file or were removed?
(Yeah, the name, "Mingrelian", is also not in the translations file.)
Jen Hammock
@jhammock
probably. If the labels are tracked in a separate place from the language-to-group mappings
Jeremy Rice
@JRice
I can add those, too. ...will just take a bit of work.
Yes, the translations of the groups is in a different place than the code->group mappings.
Jen Hammock
@jhammock
looks like I might have access. Would you like me to have a go, or might I blow it up?
Jeremy Rice
@JRice
Have a go! We can always check it on beta.
Jen Hammock
@jhammock
:+1:
Jeremy Rice
@JRice
Just please, if you can, try to keep that file as alphabetical as you can. :) It helps when debugging.
(Really helps.)
Jen Hammock
@jhammock
ok
Jen Hammock
@jhammock
Oh, alphabetical by label, I imagine?
Jeremy Rice
@JRice
Yes, sorry, by label.
Should be pretty close right now...
I usually cut the chunk in question (e.g. all of the language codes), put them into a separate text file, sort that, run through it to check for duplicates, then paste it back into place.
Watch out for 'no', it is an exception because it MUST be quoted.
(and auto-sorted files usually stick it at the top because of the quote)
Michael Vitale
@mvitale
It's not super urgent, since trait search will still work w/o it, but it's probably worth running TermStatUpdater.run on prod to facilitate the query ordering stuff we worked on
iirc it didn't take too long on beta
Jeremy Rice
@JRice
Running now
Jen Hammock
@jhammock
@JRice ah, I’ll fix the 'no': “Norwegian” in my pull request
… if I can. I’ve never edited a pull request
Michael Vitale
@mvitale
:+1: thanks
Jen Hammock
@jhammock
@JRice I think I have learned how to edit a pull request, but it turns out I never interfered with those single quotes anyway, so my pull request should be ready for your review
Jeremy Rice
@JRice
Cool.
Ugh. I'm eating lunch and I'm logged out of Github on my laptop and my phone is downstairs so I can't get their text validation thingie... Gah! I'll get to this in 15.
Jen Hammock
@jhammock
no rush!
Jeremy Rice
@JRice
Doesn't look like we have those languages on Beta, so it'll be hard to test the new entries, but I can at least see if it makes things blow up. Updated. (On beta.)
Jen Hammock
@jhammock
I am cautiously proud of myself
Jeremy Rice
@JRice
:D
Jen Hammock
@jhammock
if this requires an update, there’s no rush to production
Jeremy Rice
@JRice
It does, so: noted.
Jen Hammock
@jhammock
@JRice ah, we have email from Carmen about the SI effort to remove offensive names from hosts and docs. I remember you mentioning this a few weeks ago, but I’ve forgotten which if any arcane monickers we still have. Shall I let you respond?
Jeremy Rice
@JRice
Sure.
Jeremy Rice
@JRice
I'm ... hanging out in the hang out a bit early if you care to join. No rush otherwise.
Jen Hammock
@jhammock
Oh, great, be right there