Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Steve Clay
@mrclay
Thanks @hypeJunction
Ismayil Khayredinov
@hypeJunction
Welcome. It's a bit of a hassle
We will need to think how to make debugging easier
I think first off we need to get rid of complex access sqls
I haven't gotten to the access table yet :shipit:
Steve Clay
@mrclay
Any objections to me pulling in Elgg/Elgg#10077 ?
Ismayil Khayredinov
@hypeJunction
No, pull the plug
Ismayil Khayredinov
@hypeJunction
@mrclay Could you look into ElggCoreRegressionBugsTest::testElggResizeImage
Does the first case make sense to you?
Steve Clay
@mrclay
in a particular branch?
Ismayil Khayredinov
@hypeJunction
2.x
I don't know how it's passing given we have this: https://github.com/Elgg/Elgg/blob/2.x/engine/lib/filestore.php#L253
Steve Clay
@mrclay
I'll debug it
Ismayil Khayredinov
@hypeJunction
PHPUnit tests are green here, but simpletests are failing: Elgg/Elgg#10279
Steve Clay
@mrclay
The given image dimensions are square
Ismayil Khayredinov
@hypeJunction
true, but selection is not outside of the image...
Steve Clay
@mrclay
Sorry, the selection is square
Looking into your PR
Steve Clay
@mrclay
I see it...
Ismayil Khayredinov
@hypeJunction
What is it?
Steve Clay
@mrclay
\Elgg\ImageService::normalizeResizeParameters pulls $max_* from "w" and "h"
but caller sends them in keys "maxwidth" "maxheight"
Ismayil Khayredinov
@hypeJunction
DOH
Steve Clay
@mrclay
Yay for tests
Ismayil Khayredinov
@hypeJunction
Do you think it makes sense to combine the icon cropping into a batch?
I am now sure what impact Imagine's open() has on memory
I am sure it's already better than what we had
Steve Clay
@mrclay
[nervous smile] sure!
Ismayil Khayredinov
@hypeJunction
All right, I am out. It was a good hackathon. Thank you all for participating. Nice to see Elgg alive for a chance.
Steve Clay
@mrclay
Great work, thanks!
Matt Beckett
@beck24
hey guys
good work... :clap:
Steve Clay
@mrclay
:clap: all around
Juho Jaakkola
@juho-jaakkola
@mrclay is there any recommended way for reading elgg-plugin.php file?
Juho Jaakkola
@juho-jaakkola
Nevermind, I had missed this one:
$plugin->getStaticConfig($key);
Steve Clay
@mrclay
I need to document that
Wouter van Os
@Wouter0100
Hey guys!
Paul Stewart
@paulstewart
o hai.
Matt Beckett
@beck24
yo!
Jeroen Dalsem
@jdalsem
He Wouter
Wouter van Os
@Wouter0100
Do you guys have a recommended way of calling an user's icon/avatar in JS? Currently I just use /picture/view/{name}/tiny/{random}.jpg, but this seems removed in a later version of Elgg. A direct URL is preferred, as it's a plugin fully in JS, and prefer not to make an ajax call for every user rendered.
And the placeholder doesn't seems to work in that case ^
And all URL's I find are through the cache.
Wouter van Os
@Wouter0100
Fixed by creating an own page handler. If there's any better way, I'm open for suggestions :)
Kana Patrick
@foka_patrick_twitter
i am a newbie in elgg framework but i wanted design and customize i own social network
please help me how can do it quickly
Jeroen Dalsem
@jdalsem
Go here http://learn.elgg.org/en/stable/ and here http://community.elgg.org On those sites you can learn all you need. Also take a look at an existing theme like Aalborg to see how things are done.
Josh Santos
@thatnerdjosh
@jdalsem I am working on this modification now, expecting to have a PR ready (probably not perfect, but functional) to start going through review within the hour or so.
That being said, I am attempting to follow the contributor guide as best possible
Josh Santos
@thatnerdjosh
Taking me longer than anticipated because I am running into issues with it not having the initial cache