Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Steven Miller
    @yargalot
    Would we lost the history?
    *lose
    Jeremy Peter
    @jeremypeter
    No I don't think so, we would just need to change the repo/issues props in the package.json. NPM I believe keeps track of the module name and versions combined. So if we were to deprecate the module and someone else tried to make a new grunt-email-builder at version 2.0.0. They wouldn't be able to, they would have to use a version that was never used.
    This is what npm says:
    blockquote Even if a package version is unpublished, that specific name and version combination can never be reused. In order to publish the package again, a new version number must be used.
    Steven Miller
    @yargalot
    So we should publish it at 3.0 if we move the repo
    Makes sense
    Would either be that or rename the existing repo
    But yeh should def make it grunt-email-builder
    Makes sense if we make a gulp or broccoli or whatever kinda version
    Can just put the core into the existing codebae
    Jeremy Peter
    @jeremypeter
    Oh true, I guess we could just rename it the git repo. I did create a feature branch that's using email-builder-core that I didn't push yet
    has more tests and a lot less code
    Steven Miller
    @yargalot
    Copy paste job into the existing repo?
    More tests less code is awesome
    Depends what's easier I guess
    Never had to do this before =p
    Jeremy Peter
    @jeremypeter
    Yeah neither have I hahah. I can just copy and paste. I can look into renaming the Email-Builder repo and changing up the package.json
    sound good? Unless you already know how
    Steven Miller
    @yargalot
    Let's give that a while
    *whirl
    You have complete access to the repo now! ;D
    Unless you can push a branch to another repo lol
    Jeremy Peter
    @jeremypeter
    Sweetness, let's pray I don't break everything lol. Yeah at this point, I feel safer copy and pasting everything
    Steven Miller
    @yargalot
    Awesomesauce lol
    Pretty sure it'll be fine lol
    Unsure about the travis stuff lol
    Jeremy Peter
    @jeremypeter
    Going smooth so far, I didn't have to copy and paste after all. I just had to point my local to the new remote url using:
    git remote set-url origin https://github.com/Email-builder/grunt-email-builder.git
    Steven Miller
    @yargalot
    Man nice work on the core
    Steven Miller
    @yargalot
    Question is whats next lol
    Steven Miller
    @yargalot
    You've pretty much converted me to gulp btw, so much quicker than grunt
    Jeremy Peter
    @jeremypeter
    Yeah man! Streams FTW!! I say we get the gulp plugin working next, which looks like you've done most, if not all of it
    Steven Miller
    @yargalot
    Sounds like a plan
    Steven Miller
    @yargalot
    Think we need to put the defaults into core =p
    options.emailSpecialChars
    Jeremy Peter
    @jeremypeter
    Yeah that makes sense, is that the only one you think we need to add?
    Steven Miller
    @yargalot
    Think so
    Keep getting an error when I try to run email builder send test
    Think it loses reference to this.options
    Jeremy Peter
    @jeremypeter
    Ohhh, yeah "this" is getting lost. I was able to get it to work by doing:
    emailBuilder.inlineCss(file.path)
            .then(emailBuilder.sendLitmusTest.call(emailBuilder))
            .then(emailBuilder.sendEmailTest.call(emailBuilder))
            .then(function(html) {
    
              file.contents = new Buffer(html);
              cb(null, file);
    
            });
    using call
    Jeremy Peter
    @jeremypeter
    Actually this is a little better:
    emailBuilder.inlineCss(file.path)
            .bind(emailBuilder)
            .then(emailBuilder.sendLitmusTest)
            .then(emailBuilder.sendEmailTest)
            .then(function(html) {
    
              file.contents = new Buffer(html);
              cb(null, file);
    
            });
    Steven Miller
    @yargalot
    Momma cleaner
    Lots cleaner lol
    Jeremy Peter
    @jeremypeter
    Hahaha I like momma cleaner better
    Steven Miller
    @yargalot
    LulZ, will have a look at work then
    Steven Miller
    @yargalot
    Right pushed that
    seems to work
    Jeremy Peter
    @jeremypeter
    Looks good!