by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jul 03 06:29
    EmilStenstrom closed #7
  • Jul 03 06:29
    EmilStenstrom commented #7
  • Jul 03 06:25

    EmilStenstrom on master

    Fix packaging bug: By default s… Bump version. (compare)

  • Jul 02 07:13
    PhakkyoC commented #7
  • Jul 01 19:32
    EmilStenstrom commented #7
  • Jul 01 14:39
    PhakkyoC commented #7
  • Jul 01 13:59
    EmilStenstrom commented #7
  • Jul 01 13:56
    PhakkyoC opened #7
  • Jun 11 20:44

    EmilStenstrom on master

    Fix spelling. (compare)

  • Jun 11 19:34
    EmilStenstrom closed #4
  • Jun 11 19:34
    EmilStenstrom commented #4
  • Jun 11 19:31
    EmilStenstrom closed #6
  • Jun 11 19:31
    EmilStenstrom commented #6
  • Jun 11 19:30

    EmilStenstrom on master

    Bump version. (compare)

  • Jun 11 19:29

    EmilStenstrom on master

    Fix incorrect URL in setup.py. (compare)

  • Jun 11 15:02
    jonathan-s edited #6
  • Jun 11 15:02
    jonathan-s opened #6
  • Jun 07 22:06

    EmilStenstrom on master

    Bump version. (compare)

  • Jun 07 22:05

    EmilStenstrom on master

    Add test for component with und… Remove stray log statements. (compare)

  • Jun 07 06:46

    EmilStenstrom on master

    Fix flake8. Add flake8 and isort to CI. (compare)

Ryan Hiebert
@ryanhiebert
I have them installed locally, so I'm fine with doing it. That way we know if we introduce problems.
Ryan Hiebert
@ryanhiebert
Oh geez. It breaks under Django 1.7 right now too :-(
Emil Stenström
@EmilStenstrom
Yeah, the way you set up templates settings changed in 1.7.
Do I have to install stuff locally just to test for pypy? I'd rather skip it then.
I've found that the easier it is to run the tests on a new project, that easier it is to get people interested in contributing.
Ryan Hiebert
@ryanhiebert
Okay. We could also document how to run for only one version with tox.
should we only support django 1.8 then? It makes sense to me.
Emil Stenström
@EmilStenstrom
sure, lets start there, I can change the tests to be backwards compatible later
yes, documenting how to run stuff faster would be nice... tests run in seconds now instead of in milliseconds.
Ryan Hiebert
@ryanhiebert
Ok, I'll document that.
Ryan Hiebert
@ryanhiebert
Tox is really good for running tests easily and comprehensively. For quick iterative development, you may wish to drop down to py.test and manage the virtualenv yourself. That way it eliminates the overhead that tox introduces. You can use tox -e py34 -- -f to have it watch the current directory and re-run the tests, now that I've added pytest-xdist in #2.
Emil Stenström
@EmilStenstrom
excellent! tests run very fast that way :)
if I would like to add django 1.7 too, what would I change?
Ryan Hiebert
@ryanhiebert
Just merge #3 ;-)
Emil Stenström
@EmilStenstrom
Excellent, then I can just check out that branch and make things work before I check in.
I'll see if I can get to it later this week
Ryan Hiebert
@ryanhiebert
Actually, stuff was passing...
Locally, anyway
Andy Baker
@andybak
hi. is there much support from core devs for getting this into 1.9?
Emil Stenström
@EmilStenstrom
@andybak hi! Funkybob has said he's interested, I'm not sure if he's a core dev or not. Anyhow, helping to improve the code would increase the chances.
Ryan Hiebert
@ryanhiebert
Personally, I don't see a great reason why it should be. I think this has the potential to be an awesome approach, but there's nothing technically that should require inclusion in django proper. let's be awesome as a separate app, and it'll get merged when it's proven.
Emil Stenström
@EmilStenstrom
I don't think it would have to be included either. If it would, it would be a way of telling developers: we want to support this way of building interfaces.
I'm kinda hoping for it, but that's not a requirement for it to be useful and valueable
Emil Stenström
@EmilStenstrom
@ryanhiebert there seems to be something wrong with the django17 setup. if I run tox -e py34-django17, and in django_test_setup just import django and print django.VERSION it says Django 1.8.2.
I think that's why the tests pass at 1.7. they shouldn't since the TEMPLATES setting doesn't exist there
Ryan Hiebert
@ryanhiebert
I thought you said they should fail. Sorry, I'll look in a couple hours. Returning from my trip today.
Emil Stenström
@EmilStenstrom
Yes, they should fail with Django 1.7, but they pass with the current setup, so something is wrong with the test setup I think.
I've just improved the documentation, would love some feedback: https://github.com/EmilStenstrom/django-components/
Ryan Hiebert
@ryanhiebert
The readme is definitely an improvement. I understand the project better already
Emil Stenström
@EmilStenstrom
I'm not sure what the next step is here... maybe that means we're ready for a 0.1 release?
Ryan Hiebert
@ryanhiebert
I need to get the tests working properly for Django 1.7 first...
Ryan Hiebert
@ryanhiebert
I know what I stupidly did wrong... I have Django 1.8 set as the minimum in the setup.py. I'll have the PR updated momentarily.
Ryan Hiebert
@ryanhiebert
OK. Now the Django 1.7 tests fail as they should.
Emil Stenström
@EmilStenstrom
Thanks! I fixed the tests so that they run on Django 1.7 now too, and merged.
Ryan Hiebert
@ryanhiebert
:+1:
Emil Stenström
@EmilStenstrom
So, what's next? What do you miss and what should I add now?
Maybe it's time for a release?
Ryan Hiebert
@ryanhiebert
A release could work. The setup.py needs to get cleaned, up (remove the bad classifier, add some good ones, add a version number). I'd like there to be a universal wheel built in addition to the source release. The README would need updating to not say that the install process doesn't work.
It could get us some more feedback.
Emil Stenström
@EmilStenstrom
excellent suggestions
I'm leaving on vacation to canada on monday, I'll see if I can get it done before that
Ryan Hiebert
@ryanhiebert
I'm leaving on vacation to Canada on Tuesday...
Ryan Hiebert
@ryanhiebert
Where are you going? I'm headed to Vancouver
Emil Stenström
@EmilStenstrom
ah, I'm going to Torronto -> Ottawa -> Montreal, so other side :)
Ryan Hiebert
@ryanhiebert
Ah, nice. have fun. Montreal was much fun at PyCon in April.
Emil Stenström
@EmilStenstrom
@davidmtm Welcome! Interested in helping out?
samkurma
@samkurma
why do we get this error?
File "/home/sambaiah/.virtualenvs/Bits/local/lib/python2.7/site-packages/django/db/models/base.py", line 850, in _do_insert
return manager._insert([self], fields=fields, return_id=update_pk,
AttributeError: 'NoneType' object has no attribute '_insert'
Emil Stenström
@EmilStenstrom
hi! nice that you found my little beta library
i've never seen that problem before, so you will have to show a lot more code and try to explain to me how to reproduce the error