Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 04:34

    0x64 on develop

    WRO-2580: Add optional `contain… (compare)

  • 04:34

    0x64 on WRN-19179

    (compare)

  • 04:34
    0x64 closed #3042
  • 00:47
    codecov[bot] commented #3042
  • 00:47
    codecov[bot] commented #3042
  • 00:41
    codecov[bot] commented #3042
  • 00:41
    codecov[bot] commented #3042
  • 00:31
    codecov[bot] commented #3042
  • 00:31
    jeonghee27 synchronize #3042
  • 00:31

    jeonghee27 on WRN-19179

    apply review (compare)

  • 00:28
    codecov[bot] commented #3042
  • 00:28
    jeonghee27 synchronize #3042
  • 00:28

    jeonghee27 on WRN-19179

    travis revert (compare)

  • 00:19
    codecov[bot] commented #3042
  • 00:11
    codecov[bot] commented #3042
  • May 22 23:55
    codecov[bot] commented #3042
  • May 22 23:50
    codecov[bot] commented #3042
  • May 22 23:50
    jeonghee27 synchronize #3042
  • May 22 23:50

    jeonghee27 on WRN-19179

    tavis test (compare)

  • May 22 23:48
    codecov[bot] commented #3042
Seungho Park
@seunghoh
Merry Christmas Roy, Eric ;)
최형욱
@brouk2426
Hello World, I liked the font while looking around the site, so can I get it for personal use? "Enact Museo Sans"
Seungho Park
@seunghoh
Hi @brouk2426 Museo Sans license is restrected for use with Enact Application. Please refer to the full license at https://github.com/enactjs/moonstone/blob/master/fonts/MuseoSans/LICENSE.txt
최형욱
@brouk2426
@seunghoh Thanks!!
Eric Blade
@ericblade
anyone found a way to use absolute paths with enact? pretty sick of all the ../../../.. stuff :-D
Drake Witt
@DrakeWitt
@ericblade You can setup resolve aliases with Webpack, that should accomplish what you're looking for: https://webpack.js.org/configuration/resolve/
Eric Blade
@ericblade
@DrakeWitt how does one connect that with enact though
Seungho Park
@seunghoh
Hi @ericblade We fixed the absolute path issue on Enact CLI 4.0.2
Would you please update the Enact CLI and try again?
Eric Blade
@ericblade
@seunghoh :) i'm using 4.1.1 locally, is there something i need to configure ?
just updated to 4.1.6, doesn't seem to work there either
Eric Blade
@ericblade
i do have it apparently setup in my tsconfig correctly, as my editor understands it, but enact serve and pack just tells me that the files aren't findable if i remove the ../../.. strings
Drake Witt
@DrakeWitt
@ericblade Ah you need to run enact eject which will generate the webpack config files and such where you can customize them.
Eric Blade
@ericblade
meh, i will hope for a solution that doesn't require maintaining more configs i don't really care about, and continue using ../.. until then :)
Seungho Park
@seunghoh
Hm.. it should work. Would you explain a bit more detailed so that we can check?
Eric Blade
@ericblade
what information would help? i started this app back around enact first went public, i think before the 1.0 release, and i've slowly upgraded it over time ever since.
Seungho Park
@seunghoh
Enact & Sandstone version, the codes around which you want to use absolute path will help
Eric Blade
@ericblade
enact-cli 4.1.6, deps are "dependencies": { "@enact/core": "^4.1.2", "@enact/i18n": "^4.1.2", "@enact/moonstone": "^4.0.3", "@enact/spotlight": "^4.1.2", "@enact/ui": "^4.1.2",
Eric Blade
@ericblade
and i have a lot of imports that look like import CurrencyInput from '../../components/CurrencyInput/CurrencyInput';
Eric Blade
@ericblade
decided to go dig around and find it.. now checking to see if i can figure out how to add it to the enact options in package.json :)
Eric Blade
@ericblade
ugh also need to fork dev-utils
Eric Blade
@ericblade
ok.. so when i link in my modified dev-tools it deletes all the other modules necessary for cli to run.. :|
Eric Blade
@ericblade
please review enactjs/cli#257 and enactjs/dev-utils#85 to add the feature to package.json
Eric Blade
@ericblade
... and confirming that it works and does what it's supposed to, all the way out to my production server. \o/
i should've called it relative paths, not absolute paths, i thought that sounded weird, but all the articles were like 'absolute paths are amazing'.. but these aren't absolute paths. sorry if that caused any confusion
Eric Blade
@ericblade
image.png
2 hours to clone and figure out how to add the feature to enact, get it added to my production server, and touch every single file in my application to update for it. not too bad.
Mikyung Kim
@MikyungKim
@ericblade ,
Thanks for the PRs. Enact CLI does support "resolve.alias" (https://webpack.js.org/configuration/resolve/#resolvealias) through package.json as "alias" property.
But I guess you wanted to resolve additional paths.
I understand what's the pain point for developers and I think it's reasonable to add the feature.
I found Create React App also supports the feature through js/tsconfig file. (https://create-react-app.dev/docs/importing-a-component/#absolute-imports)
Fortunately, we have plans for adopting Webpack5 near future, we'll take a look at how we could achieve this while updating Webpack.
I think "enact" object in package.json is a good start point. Thanks for the suggestion!
Eric Blade
@ericblade
I don't know enough about webpack configuration to know if that can be used to achieve the same thing or not
hmm. i just looked up those fields, and for the specific purpose, it does look like both can be used to achieve what i wanted, though it does look like there might be good reasons to have both.
If you'd like to accept that change, but need me to make any changes to it, just lmk. I'm not sure my choice of variable names fits well.
Mikyung Kim
@MikyungKim
Sure, we'll let you know! If we need to make another PR for some reason, we'll also comment on your PR to let you know.
Thank you for your support! I really appreciate it.
Eric Blade
@ericblade
hmm. might be a long shot question, but .. anyone know of a way to defeat Android's pull-to-refresh behavior on a Touchable that is looking for a flick event?
I've just discovered that having a component slide out on flick is a really interesting UI thing I want to toy with, but Android keeps getting in the way
Eric Blade
@ericblade
i found a way!
            onFlick={() => { do_thing_flick_should_do(); document.body.style.overscrollBehaviorY = 'auto'; }}
            onTouchMove={(ev) => { document.body.style.overscrollBehaviorY = 'contain';}}
Eric Blade
@ericblade
should there be a fix soon to make enact serve work with node 17+ ?
requires NODE_OPTIONS=--openssl-legacy-provider right now
Seungho Park
@seunghoh
We have a plan to bump up the node LTS(16) not 17 soon.
Eric Blade
@ericblade
👍not sure if that problem affects 16, i think the pc i have 17 on i bumped straight from 14 to 17.
Eric Blade
@ericblade
it looks like this doesn't effect 16, this is a new change in 17. my production server uses 16 and doesn't set this, though i try to keep my dev machines up to date when i'm active on them. so, not a big deal, but someone will need to be aware that node 17+ will break npm run serve
Seungho Park
@seunghoh
Will do. Thanks for the information Eric!
Dead-Master
@Dead-Master
Tell me how to add your data to the index.html file, I can’t find the template for this file
Eric Blade
@ericblade
@Dead-Master in my package.json i have under "enact": { "template": "./template.html", ... }
Martin Scola
@martinscola-hwm
Hello Enact Team! I'm getting acquainted with the Enact Framework and I was wondering if it's compatible with React Hooks, and where would I go about using them. Can I use them while creating components with kind()?
Eric Blade
@ericblade
i don't know 100% but i haven't found a way to use hooks inside a kind.. when i need a hook, i use a react component
Martin Scola
@martinscola-hwm
Thank you, Eric. Sorry for the delay, I’m only seeing msgs at the office. You can just insert React components anywhere in the app, right? One other question, if you will: I’m having the most stupidest thing, where I try to insert an image using the Sandstone Image component, but it doesn’t render. Neither inside a panel, or inside a DIV. Any thoughts?
Martin Scola
@martinscola-hwm
What I don’t understand is that I’m getting a status 200 on the images, but when I see them on the Network preview, they’re blank
Martin Scola
@martinscola-hwm
Never mind, I fixed that
Seungho Park
@seunghoh
Hi @martinscola-hwm Yes, you can use react hooks with kind by setting functional: true
Please refer to the https://enactjs.com/docs/modules/core/kind/
Eric Blade
@ericblade
oh wow, that's great to know