Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jul 01 08:41

    0x64 on WRO-5932

    Apply @lit-labs/react partially… (compare)

  • Jul 01 07:45
    vladut-clapou-lgp synchronize #183
  • Jul 01 07:45

    vladut-clapou-lgp on WRO-713

    Review fix (compare)

  • Jul 01 07:44
    vladut-clapou-lgp synchronize #176
  • Jul 01 07:44

    vladut-clapou-lgp on WRO-713

    Review fix (compare)

  • Jul 01 07:35
    vladut-clapou-lgp synchronize #176
  • Jul 01 07:35

    vladut-clapou-lgp on WRO-713

    Review fix (compare)

  • Jul 01 06:55
    codecov[bot] commented #3069
  • Jul 01 06:49
    codecov[bot] commented #3069
  • Jul 01 06:49
    jeonghee27 synchronize #3069
  • Jul 01 06:49

    jeonghee27 on WRO-745

    apply review (compare)

  • Jul 01 06:40
    jeonghee27 closed #184
  • Jul 01 06:40

    jeonghee27 on develop

    Remove using svg background ima… Remove background-repeat, backg… Align indentation Enact-DCO-1.0… and 1 more (compare)

  • Jul 01 05:02
    sjro synchronize #184
  • Jul 01 05:02

    sjro on WRO-7413

    Align indentation Enact-DCO-1.0… (compare)

  • Jul 01 02:14
    codecov[bot] commented #3070
  • Jul 01 02:09
    codecov[bot] commented #3070
  • Jul 01 02:09
    jeonghee27 synchronize #3070
  • Jul 01 02:09

    jeonghee27 on WRO-4003

    fix lint (compare)

  • Jul 01 02:07
    jeonghee27 edited #3070
Eric Blade
@ericblade
I've just discovered that having a component slide out on flick is a really interesting UI thing I want to toy with, but Android keeps getting in the way
Eric Blade
@ericblade
i found a way!
            onFlick={() => { do_thing_flick_should_do(); document.body.style.overscrollBehaviorY = 'auto'; }}
            onTouchMove={(ev) => { document.body.style.overscrollBehaviorY = 'contain';}}
Eric Blade
@ericblade
should there be a fix soon to make enact serve work with node 17+ ?
requires NODE_OPTIONS=--openssl-legacy-provider right now
Seungho Park
@seunghoh
We have a plan to bump up the node LTS(16) not 17 soon.
Eric Blade
@ericblade
👍not sure if that problem affects 16, i think the pc i have 17 on i bumped straight from 14 to 17.
Eric Blade
@ericblade
it looks like this doesn't effect 16, this is a new change in 17. my production server uses 16 and doesn't set this, though i try to keep my dev machines up to date when i'm active on them. so, not a big deal, but someone will need to be aware that node 17+ will break npm run serve
Seungho Park
@seunghoh
Will do. Thanks for the information Eric!
Dead-Master
@Dead-Master
Tell me how to add your data to the index.html file, I can’t find the template for this file
Eric Blade
@ericblade
@Dead-Master in my package.json i have under "enact": { "template": "./template.html", ... }
Martin Scola
@martinscola-hwm
Hello Enact Team! I'm getting acquainted with the Enact Framework and I was wondering if it's compatible with React Hooks, and where would I go about using them. Can I use them while creating components with kind()?
Eric Blade
@ericblade
i don't know 100% but i haven't found a way to use hooks inside a kind.. when i need a hook, i use a react component
Martin Scola
@martinscola-hwm
Thank you, Eric. Sorry for the delay, I’m only seeing msgs at the office. You can just insert React components anywhere in the app, right? One other question, if you will: I’m having the most stupidest thing, where I try to insert an image using the Sandstone Image component, but it doesn’t render. Neither inside a panel, or inside a DIV. Any thoughts?
Martin Scola
@martinscola-hwm
What I don’t understand is that I’m getting a status 200 on the images, but when I see them on the Network preview, they’re blank
Martin Scola
@martinscola-hwm
Never mind, I fixed that
Seungho Park
@seunghoh
Hi @martinscola-hwm Yes, you can use react hooks with kind by setting functional: true
Please refer to the https://enactjs.com/docs/modules/core/kind/
Eric Blade
@ericblade
oh wow, that's great to know
quite a time ago, i had asked about creating a PWA with enact.. finally figured out a way to do it.. just built the app manifest and related information, then installed it into the enact dist directory after packing everything with pack-p . . . just totally bypass the problem :-)
i'd just never thought about doing it like that, and i saw someone else doing something similar, and was like... oh.. i can do that. :-D
Martin Scola
@martinscola-hwm
Thank you, @seunghoh
Eric Blade
@ericblade
@seunghoh so setting functional: true does get past the initial "you can't use a hook here" problem, but then it triggers: Line 25:30: React Hook "useSelector" is called in function "render" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter react-hooks/rules-of-hooks
both the variable name and the 'name' field are set to a name that begins with an uppercase letter.
Seungho Park
@seunghoh
@ericblade Thanks for the notes. We will take a look and let you know
Seungho Park
@seunghoh
hi @ericblade We've released Enact CLI 4.1.7
It supports absolute path imports. https://github.com/enactjs/cli/releases/tag/4.1.7
Eric Blade
@ericblade
<3 ty
i just upgraded to react 18-rc2, and unless there's something really really sticky hiding in there, the entire app appears to work 100% with no changes other than adding react 18 to my peerDeps in one component
goodev2021
@goodev2021
hi
I come across Paper Mache - https://www.ryanwatkins.net/software/papermache/press.html
I have huge content to be displayed like Paper Mache or https://lwcast.org/Mobile which uses enjoy framework. Looks the enyo framework is not very active right now or not sure whether i should use enjojs
Could you please kindly suggest the best framework or plugin or anything similar to Paper Mache or Enjo framework implementation like https://lwcast.org/Mobile or should we use enyojs which will satisfy the artcile or paper publishing website with search engine.
Eric Blade
@ericblade
hmm. i switched back to using the mainline version of @enact/cli, instead of my modified one, and now it's complaining about typescript features i'm using in 4.5.. but only on my production build..
my development build has no problem with the new typescript
Seungho Park
@seunghoh
hi @goodev2021 Enyo has switched to Enact in 2018. https://medium.com/enact-js/hello-enact-2d971dc763ab
You can use Enact. https://enactjs.com/
Thanks
1 reply
@ericblade Can you share the complaining message of new feature?
Eric Blade
@ericblade
image.png
specifically, type imports
Seungho Park
@seunghoh
Thanks! We will take a look.
Eric Blade
@ericblade
i just reverted back to using my custom enact from when i submitted that PR and the type imports work fine.
Mikyung Kim
@MikyungKim
Hm.. It's weird.. Could you share "enact" property in your package.json for providing additional modules path?
Eric Blade
@ericblade
    "enact": {
        "theme": "moonstone",
        "template": "./template.html",
        "additionalModulePaths": [
            "./src"
        ]
    },
it is very weird. i have doubts that additionalModulePaths is affecting it, it's acting like it's using a specific version of typescript rather than the one installed
and this is what my Dockerfile does up to the point where it builds and fails
FROM node:16 AS build
WORKDIR /usr/src/pos
#ENV NODE_OPTIONS=--openssl-legacy-provider # not allowed in v14, but necessary in v17+ until we get upgraded webpack in enact
RUN npm install -g @enact/cli
#RUN npm install -g ericblade/cli#dev
RUN enact -v
RUN npm install -g typescript
RUN npm install -g workbox-cli
COPY package*.json ./
RUN npm install --production
COPY . .
WORKDIR /usr/src/pos/public
# RUN npm install --production
RUN npm install
RUN npm run pack-p
Eric Blade
@ericblade
the global installed enact/cli is 4.1.7, and the global typescript should be latest at 4.6.2
Mikyung Kim
@MikyungKim
Okay thanks, I'll try to reproduce the issue and get back to you.
Seungho Park
@seunghoh
@goodev2021 Enact has Scroller & VirtualList component which supports huge content with high performance. webOS TV uses these components a lot.
Please refer to our doc https://enactjs.com/docs/developer-guide/virtual-list-scroller/
You can also check our components samples in the storybook at https://enactjs.com/sampler/sandstone/
1 reply
Eric Blade
@ericblade
i checked out for sure that the global installed typescript with the above docker script is in fact 4.6.2.
It is even more strange that switching back to my fork of cli works with the exact same everything else. The only change on my fork are adding the module paths, there are no dependency changes or anything. My fork of cli is 4.1.3 + change. So, I guess this might be something to do with enactjs changes between 4.1.3 and 4.1.7
Eric Blade
@ericblade
oops my fork of cli is 4.1.6, fork of dev-utils is 4.1.3.
Eric Blade
@ericblade
enact -v reports 4.1.7, tsc -v reports 4.6.2, and then the npm run pack-p fails on all lines of code that use the new import { type ... } introduced in .. 4.5 https://devblogs.microsoft.com/typescript/announcing-typescript-4-5/#type-on-import-names
Eric Blade
@ericblade
and the only change i make between one working and one not working is the 'npm install -g @enact/cli' versus the 'npm install -g ericblade/cli#dev' ..
Seungho Park
@seunghoh
@goodev2021 I recommend you to read & follow enact tutorial page https://enactjs.com/docs/tutorials/introduction/ and you can also see the tutorial samples in the github https://github.com/enactjs/samples/tree/develop/sandstone
Don't worry that you are new to enact, if you are familar with react, then you won't have any problem :)
Juwon Jeong
@juwonjeong

so setting functional: true does get past the initial "you can't use a hook here" problem, but then it triggers: Line 25:30: React Hook "useSelector" is called in function "render" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter react-hooks/rules-of-hooks

@ericblade, we looked into the above issue. uppercase letter issue occured with the property name("render") in kind.
It seems that the kind() method needs an update.
I think we should disable the react-hooks/rules-of-hooks eslint rule to use hooks in kind for now.