daniel-stoian-lgp on WRO-7542
code review fixes (compare)
daniel-stoian-lgp on WRO-7542
Feature/WRO-713: TypeScript: Ex… Fix eslint warnings in strict m… Merge remote-tracking branch 'o… (compare)
MikyungKim on WRO-713-eslint-strict
MikyungKim on develop
Fix eslint warnings in strict m… (compare)
0x64 on WRO-713-eslint-strict
Fix eslint warnings in strict m… (compare)
enyo-jenkins on release-4.5.0-rc.2-test
enyo-jenkins on 4.5.0-rc.2
0x64 on WRO-713
0x64 on develop
Fixed Enact + Typescript tutori… Update src/pages/docs/tutorials… Update src/pages/docs/tutorials… and 3 more (compare)
0x64 on WRO-713
0x64 on develop
Feature/WRO-713: TypeScript: Ex… (compare)
0x64 on WRO-5932
Apply @lit-labs/react partially… (compare)
onFlick={() => { do_thing_flick_should_do(); document.body.style.overscrollBehaviorY = 'auto'; }}
onTouchMove={(ev) => { document.body.style.overscrollBehaviorY = 'contain';}}
FROM node:16 AS build
WORKDIR /usr/src/pos
#ENV NODE_OPTIONS=--openssl-legacy-provider # not allowed in v14, but necessary in v17+ until we get upgraded webpack in enact
RUN npm install -g @enact/cli
#RUN npm install -g ericblade/cli#dev
RUN enact -v
RUN npm install -g typescript
RUN npm install -g workbox-cli
COPY package*.json ./
RUN npm install --production
COPY . .
WORKDIR /usr/src/pos/public
# RUN npm install --production
RUN npm install
RUN npm run pack-p
npm run pack-p
fails on all lines of code that use the new import { type ... } introduced in .. 4.5 https://devblogs.microsoft.com/typescript/announcing-typescript-4-5/#type-on-import-names
so setting functional: true does get past the initial "you can't use a hook here" problem, but then it triggers: Line 25:30: React Hook "useSelector" is called in function "render" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter react-hooks/rules-of-hooks
@ericblade, we looked into the above issue. uppercase letter issue occured with the property name("render") in kind.
It seems that the kind() method needs an update.
I think we should disable the react-hooks/rules-of-hooks eslint rule to use hooks in kind for now.