enyo-jenkins on release-4.5.2-test
enyo-jenkins on 4.5.2
MikyungKim on WRO-9768
MikyungKim on develop
WRO-9768: Fix `Marquee` to stop… (compare)
jeonghee27 on WRO-3625
jeonghee27 on develop
WRO-3625: Add `usePublicClassNa… (compare)
jeonghee27 on WRO-9768
fix changelog (compare)
MikyungKim on WRO-3625
fix based on review Enact-DCO-… (compare)
FROM node:16 AS build
WORKDIR /usr/src/pos
#ENV NODE_OPTIONS=--openssl-legacy-provider # not allowed in v14, but necessary in v17+ until we get upgraded webpack in enact
RUN npm install -g @enact/cli
#RUN npm install -g ericblade/cli#dev
RUN enact -v
RUN npm install -g typescript
RUN npm install -g workbox-cli
COPY package*.json ./
RUN npm install --production
COPY . .
WORKDIR /usr/src/pos/public
# RUN npm install --production
RUN npm install
RUN npm run pack-p
npm run pack-p
fails on all lines of code that use the new import { type ... } introduced in .. 4.5 https://devblogs.microsoft.com/typescript/announcing-typescript-4-5/#type-on-import-names
so setting functional: true does get past the initial "you can't use a hook here" problem, but then it triggers: Line 25:30: React Hook "useSelector" is called in function "render" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter react-hooks/rules-of-hooks
@ericblade, we looked into the above issue. uppercase letter issue occured with the property name("render") in kind.
It seems that the kind() method needs an update.
I think we should disable the react-hooks/rules-of-hooks eslint rule to use hooks in kind for now.
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<meta http-equiv="x-ua-compatible" content="ie=edge">
<meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1, maximum-scale=1, user-scalable=no">
<title>Enact App Template</title>
<link href="main.css" rel="stylesheet"/></head>
<body>
<div id="root"></div>
<script src="main.js"></script></body>
</html>