Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 29 22:27
    wildcard starred Erudika/scoold
  • Mar 27 16:45
    gannunziata starred Erudika/scoold
  • Mar 27 13:24
    albogdano commented #33
  • Mar 27 13:24
    albogdano commented #33
  • Mar 27 13:24
    albogdano closed #33
  • Mar 27 13:24
    albogdano closed #33
  • Mar 27 13:24

    albogdano on master

    added CSP2 backward compatibili… (compare)

  • Mar 27 13:23
    albogdano reopened #33
  • Mar 27 13:23
    albogdano reopened #33
  • Mar 27 11:51
    albogdano commented #33
  • Mar 27 11:51
    albogdano commented #33
  • Mar 27 11:44
    b-morgenthaler commented #33
  • Mar 27 11:44
    b-morgenthaler commented #33
  • Mar 27 11:08
    albogdano closed #33
  • Mar 27 11:08
    albogdano closed #33
  • Mar 27 11:08
    albogdano commented #33
  • Mar 27 11:08
    albogdano commented #33
  • Mar 27 11:02
    b-morgenthaler opened #33
  • Mar 27 11:02
    b-morgenthaler opened #33
  • Mar 27 01:16

    albogdano on master

    changed logging level for avata… (compare)

Alex Bogdanovski
@albogdano
is the certificate self-signed?
b-morgenthaler
@b-morgenthaler
to be honst, I don't know for sure. since configuration management is taking care of requesting and installing certificates. does it make any difference?
Alex Bogdanovski
@albogdano
well, perhaps certificate validation fails because of this or because the subject names (subdomains) are not public. not sure which though
b-morgenthaler
@b-morgenthaler
I looked at the certificate and since the issuer is also our company, I am pretty sure it self-signed
Alex Bogdanovski
@albogdano
I think the purpose of the avatar image validation is just to prevent broken links to images not verify certificates so I think it's safe to disable cert verification in that case
b-morgenthaler
@b-morgenthaler
I agree that it could be safe but I am still wondering why the DEBUG couldn't find a string inside a list of strings that is obviously existing
Alex Bogdanovski
@albogdano
that's done by the Apache HttpClient library - it handles cert verification and matching domains
I can't say why it fails to match the subject names
it's a bug in the HttpClient library used by Scoold
b-morgenthaler
@b-morgenthaler
is this lib different in the current version than in the previous?
Alex Bogdanovski
@albogdano
yes, quite possibly
this explains the strange behavior
b-morgenthaler
@b-morgenthaler
because I cannot remember observing this issue for our productive system which runs on the previous version of scoold
it seems you found the root cause... tough one
Alex Bogdanovski
@albogdano
yes, I couldn't have anticipated this because these bugs are very rare
:thumbsup: I will update the library and fix this
b-morgenthaler
@b-morgenthaler
Unfortunately, I am used to "rare bug" ;-)
Alex Bogdanovski
@albogdano
:smile:
I'm happy it's not my fault at least..
b-morgenthaler
@b-morgenthaler

lol, if it would have been, nobody is perfect, especially not in software. I was developing software for more than a decade and implemented lots of bugs ;-)

alright, take your time. I wait for an update to reproduce in the next days

Alex Bogdanovski
@albogdano
I agree - we all make mistakes. Thank you for you patience honestly - some issues are really frustrating sometimes!
update is coming asap (in half an hour maybe)
b-morgenthaler
@b-morgenthaler
Frustrating, indeed. Thank you for being so responsive. I work with a lot of suppliers professionally - total different story...
No need to hurry because of me. Tomorrow is also a day which needs some work ;)
Alex Bogdanovski
@albogdano
:thumbsup:
b-morgenthaler
@b-morgenthaler
good news and bad news
Alex Bogdanovski
@albogdano
start with the bad news :)
b-morgenthaler
@b-morgenthaler
good news: curl now can access the image even with FQDN and there's no DEBUG about failing to get user avatar
bad news: with the web page of scoold it is still not working
is the version you sent me still w/o cert validation?
Alex Bogdanovski
@albogdano
huh? the new build does have cert validation turned on but it also contains the latest fixed HttpClient library
b-morgenthaler
@b-morgenthaler
I have an idea:
Alex Bogdanovski
@albogdano
if you don't see any messages in the logs then the avatar should be passed through to the browser (i.e. the URL after /people/avatar?url=...)
have you tried clearing the browser cache or hard refreshing the page
b-morgenthaler
@b-morgenthaler

in the web console the URL looks like this: https://testsystem/people/avatar?url=https%3A%2F%2Ftestsystem.company.intern%2Fupload%2Ffiles%2Fprofile_1046380278353760256_avatar_bm.jpg

what if the "." from testsystem.company.intern also need to be URL encoded with "%2E"?

Alex Bogdanovski
@albogdano
no
b-morgenthaler
@b-morgenthaler
I will clear the cache, resp start a new browser session to be sure
Alex Bogdanovski
@albogdano
avatar images are cached as far as I know
24hours to be exact
b-morgenthaler
@b-morgenthaler
ok. with a new session the image is shown even with the FQDN in the URL. this seems to be fixed. had a hard time changing the avatar image by drag and drop. it didn't change the URL and didn't change the image automatically. had to add the URL manually
Alex Bogdanovski
@albogdano
alright! finally
so, is the drag&drop broken?
b-morgenthaler
@b-morgenthaler
yes. i think this is finally fixed.
drag and drop shows the new image as avatar but the URL does not change and the small avatar image at the upper right corner still shows the previous image. when I change to a different page, everything gets updated to the new image, even the URL when I go back to the profile
Alex Bogdanovski
@albogdano
ok, I'll see what exactly happened here...
b-morgenthaler
@b-morgenthaler
but still, the main issue is fixed :-)
Alex Bogdanovski
@albogdano
yey!
b-morgenthaler
@b-morgenthaler
I am out... see you around for the next rare issue ;-)
Alex Bogdanovski
@albogdano
see you later!