These are chat archives for Exa-Networks/exabgp

2nd
Apr 2015
Thomas Mangin
@thomas-mangin
Apr 02 2015 08:33
Hi, That would not work
Sorry ..
It may work ...
sanjmonkey
@sanjmonkey
Apr 02 2015 08:34
But it's not good practice ?
Thomas Mangin
@thomas-mangin
Apr 02 2015 08:34
But if you run multiple ExaBGP the behaviour would become extremely unpredictable with the connection going to one of the application
The same will happen within one application - a random socket will get the connection which may not be the one you are expecting ...
Unless I am not fully understanding what you are trying to achieve ..
sanjmonkey
@sanjmonkey
Apr 02 2015 08:35
Yes, I understand. But bind() seems to be limiting in this case as even when supplied with MD5 SO's (making it unique) it only takes into account local IP + port
Thomas Mangin
@thomas-mangin
Apr 02 2015 08:35
You want to have something like
neighborg ( local ip A, remote ip B, passive )
neighbour ( local ip A, remote ip C, passive )
sanjmonkey
@sanjmonkey
Apr 02 2015 08:36
I'll try passing multiple MD5 SO's to it for each of my neighbors before calling bind
Thomas Mangin
@thomas-mangin
Apr 02 2015 08:37
Can I call you .. it would be simpler to understand your use case
I think I would need to change the listening code to :
  • allow more than one peer per listening IP
  • on connection reception, lookup the remote IP and dispatch to the right peer
Correct ?
sanjmonkey
@sanjmonkey
Apr 02 2015 08:38
Sure. Will be in office in 30 mins
Thomas Mangin
@thomas-mangin
Apr 02 2015 08:39
Ok - Drop me a mail with your number and I will call you
Thomas Mangin
@thomas-mangin
Apr 02 2015 10:08
@sanjmonkey I just pushed a patch to my tree can you pull it ?
sanjmonkey
@sanjmonkey
Apr 02 2015 10:14
have sent you details of lab - with new patch already deployed, but it still tries to bind multiple times i think
Thomas Mangin
@thomas-mangin
Apr 02 2015 10:20
ok thanks
Thomas Mangin
@thomas-mangin
Apr 02 2015 10:38
Can I call you ?
sanjmonkey
@sanjmonkey
Apr 02 2015 10:38
sure!
Thomas Mangin
@thomas-mangin
Apr 02 2015 11:04
@sanjmonkey you have a patched version of the code (same as mine)
Can you please tell me if it works ?
sanjmonkey
@sanjmonkey
Apr 02 2015 11:15
yes! both came up :) :clap:
thankyou
Thomas Mangin
@thomas-mangin
Apr 02 2015 11:24
ok - pushed the patch to my tree and will go to the main tree once the CI checks pass
I have excluded a mix on non MD5 and MD5 - it may work but I can not test it
If you want to test it so I can be sure it would be great !
if so let me know as I need to edit slightly the code :smile:
sanjmonkey
@sanjmonkey
Apr 02 2015 11:40
will test it now from your branch.
Thomas Mangin
@thomas-mangin
Apr 02 2015 11:45
Thanks
Do you want me to add code on the server for the mixed MD5 , non-MD5 ?
sanjmonkey
@sanjmonkey
Apr 02 2015 11:47
ah yes please. i see it fails atm
Thomas Mangin
@thomas-mangin
Apr 02 2015 11:47
k
patched
sanjmonkey
@sanjmonkey
Apr 02 2015 11:50
both session up - one MD5 one not
Thomas Mangin
@thomas-mangin
Apr 02 2015 11:50
who who
sorry I meant whao !
sanjmonkey
@sanjmonkey
Apr 02 2015 11:51
Great success :sparkles:
Thomas Mangin
@thomas-mangin
Apr 02 2015 11:53
Thank you for your help.
Pleased the MD5 code is now fully functional :sparkles:
I will surely release 3.4.10 soon before going to Japan
sanjmonkey
@sanjmonkey
Apr 02 2015 11:54
no no, thank you! I will remove my filthy ‘reuseports' hack from you know where. were you planning on pushing to main sometime soon? If not i will just patch in our internal repo
Thomas Mangin
@thomas-mangin
Apr 02 2015 11:55
The new code will be on the exabgp repo as soon as travis finished with mine
running them at the same time seems to cause issues sometimes
sanjmonkey
@sanjmonkey
Apr 02 2015 11:56
great, ty
Thomas Mangin
@thomas-mangin
Apr 02 2015 11:59
pusged
pushed even
sanjmonkey
@sanjmonkey
Apr 02 2015 12:00
cloned !