These are chat archives for Exa-Networks/exabgp

29th
Sep 2016
Stacey Sheldon
@solidgoldbomb
Sep 29 2016 17:55
thomas-mangin: thanks for merging
Thomas Mangin
@thomas-mangin
Sep 29 2016 17:56
@solidgoldbomb you are welcome
Thank you for fixing the issue - I have been busy recently
Stacey Sheldon
@solidgoldbomb
Sep 29 2016 17:56
there's also a problem with the ipv4 unicast eor serialization. i'll see if i can fix that one too.
Thomas Mangin
@thomas-mangin
Sep 29 2016 17:56
That said today I fixed a bug :-)
@solidgoldbomb Thank you very much - much appreciated - what is the issue ?
Stacey Sheldon
@solidgoldbomb
Sep 29 2016 17:57
invalid json
Thomas Mangin
@thomas-mangin
Sep 29 2016 17:57
:-(
I should have created dict and used json.dumps ...
insight ...
Stacey Sheldon
@solidgoldbomb
Sep 29 2016 17:58
only the ipv4 unicast eor is wrong. looks like it's encoded as an eor inside of an update or something
looks very different than the ipv6 unicast or ipv4/6 flow eor
are you also interested in fixes in the 3.4 branch or is 4.0 the dev focus now?
Thomas Mangin
@thomas-mangin
Sep 29 2016 18:00
Fixes which do not break existing 3.4 users are normally backported, but the one you did would change the API and therefore can not be
Stacey Sheldon
@solidgoldbomb
Sep 29 2016 18:00
right. i meant an unrelated fix.
it's a config fix
Thomas Mangin
@thomas-mangin
Sep 29 2016 18:00
The focus for stability is 3.4 - 4.0 is not yet alpha (but it is stable) as I want to change the configuration file (to have different family sections for the routes)
Sure fixes should be back ported. I have one backport pending atm ..
And I forward port fix to 3.4 to master too :P
Stacey Sheldon
@solidgoldbomb
Sep 29 2016 18:02
ok. will submit another PR for the 3.4 branch. it's a bug unique to 3.4 since the config is much nicer in 4.0
Thomas Mangin
@thomas-mangin
Sep 29 2016 18:03
Thank you - 4.0 should be better but I am lacking the time.
and I want to move the BGP parsing in another process to use multi-core and and and ...
Stacey Sheldon
@solidgoldbomb
Sep 29 2016 18:05
in changelog on 3.4 branch, is 3.4.18 the placeholder for a future release or should i add a 3.4.19 section for the new bugfix?
Thomas Mangin
@thomas-mangin
Sep 29 2016 18:10
I had to look :p - 3.4.18 is the next release
3.4.17 was released two weeks ago .. and I think I forgot to announce it ..
Stacey Sheldon
@solidgoldbomb
Sep 29 2016 18:12
ok, thanks.