These are chat archives for Exa-Networks/exabgp

6th
Mar 2017
Thomas Morin
@tmmorin
Mar 06 2017 08:33
hi @thomas-mangin
i'm trying to grab the low hanging fruits of py2 to py3 adaptations
my assumption is, of course, that the resulting code would still run under py27/26
are you ok with "six" as a dependency that makes it easy to write code working both under py27 and py26 ?
Thomas Morin
@tmmorin
Mar 06 2017 11:12
(sorry: I meant under both py27 and py3x)
Thomas Mangin
@thomas-mangin
Mar 06 2017 13:43
no issue if the required code is available in the vendoring (previously deps) folder
Thomas Morin
@tmmorin
Mar 06 2017 15:07
ah... not the case with "six" package...
Thomas Mangin
@thomas-mangin
Mar 06 2017 15:07
This message was deleted
what do you mean ?
Thomas Morin
@tmmorin
Mar 06 2017 15:07
"six" package is not under vendoring
i'll see if I can do something clean enough without this package
Thomas Mangin
@thomas-mangin
Mar 06 2017 15:08
nope, what I mean is that if you want to use six, just copy the code in the vendoring folder in lib/exabgp and use this reference so users do not have to have it installed
Thomas Morin
@tmmorin
Mar 06 2017 15:08
I can do that
Thomas Mangin
@thomas-mangin
Mar 06 2017 15:09
that’s it - I use a few third party libs but have it installed that way
Thomas Morin
@tmmorin
Mar 06 2017 15:09
out of curiosity: why not accept fairl y standard deps (like six) ?
Thomas Mangin
@thomas-mangin
Mar 06 2017 15:10
historical mostly, at first exabgp had no deps and it made it easy to install .. all you need is the tarball .
there is deps for testing and for health check tho
but it is not “core"
Thomas Morin
@tmmorin
Mar 06 2017 15:11
would the introduction of externals (non vendored-in) deps be perhaps acceptable for running under python3 ?
Thomas Morin
@tmmorin
Mar 06 2017 15:37
here are the kind of fixes I would like to push to you: https://github.com/tmmorin/exabgp/commits/master (not finished, will do a PR when ready)
Thomas Mangin
@thomas-mangin
Mar 06 2017 15:38
Sure - that would be great .. feel free to change the default python to python3 in the run script too
Thomas Morin
@tmmorin
Mar 06 2017 15:50
what I'm trying to do is make things py27/py3 compatible
Thomas Mangin
@thomas-mangin
Mar 06 2017 15:50
sure :-) good - thank you
Thomas Morin
@tmmorin
Mar 06 2017 15:51
switching the default to python3 won't be doable after much much more changes/testing
so I won't touch the run script for now
Thomas Mangin
@thomas-mangin
Mar 06 2017 15:51
Yes, it will be the last patch :p
Thomas Morin
@tmmorin
Mar 06 2017 15:51
well, I would even let the decision up to the end user or packager...