Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 22 12:08
    thomas-mangin labeled #911
  • Aug 22 12:03
    thomas-mangin closed #910
  • Aug 22 12:03
    thomas-mangin commented #910
  • Aug 22 09:31
    thomas-mangin commented #911
  • Aug 22 09:29
    thomas-mangin labeled #911
  • Aug 22 09:28
    thomas-mangin assigned #911
  • Aug 22 03:58
    andy19910403 edited #911
  • Aug 22 03:58
    andy19910403 opened #911
  • Aug 15 14:15
    vincentbernat commented #910
  • Aug 15 07:46
    sincerywaing edited #910
  • Aug 15 05:19
    sincerywaing opened #910
  • Aug 14 21:40
    Vascko commented #909
  • Aug 13 10:04
    thomas-mangin labeled #909
  • Aug 13 10:04
    thomas-mangin assigned #909
  • Aug 13 10:02
    thomas-mangin commented #909
  • Aug 12 07:32
    wavezhang commented #908
  • Aug 12 07:32
    wavezhang commented #908
  • Aug 11 23:04
    Vascko opened #909
  • Aug 09 21:44
    thomas-mangin commented #908
  • Aug 09 21:44

    thomas-mangin on master

    accepting patch suggestion from… (compare)

tim-preston
@tim-preston
Well one issue is how do I specify wether a 4 Octet ASN is vein used when I have the form target:<adn
Bah, target:<asn>:<value>
And probably related to that target:60000:160000 or origin:160000:60000 seem to work, but origin:60000:160000 or target:160000:60000 throw an error error: 'H' format requires 0 <= number <= 65535
tim-preston
@tim-preston
But I'm wrestling a little bit with how the extended communities are being represented in the BIRD table dump I'm generating my config from so I'm not 100% sure I have my head around this yet and it isn't a problem at my end...
Thomas Mangin
@thomas-mangin
Ok - do you want me to call you ?
Sorry for the delay in answering
I will look into this I believe this is normal tho.
Thomas Mangin
@thomas-mangin
The way the numbers are split betwen target and origin
Long : short vs short : Long — I will check the RFC and see if the code is correct
Thomas Mangin
@thomas-mangin
Tk
Tim, you can add a “L” at the end of the number to say that the number is a LONG (i.e.: ASN4)
origin:1L:2 with do
I added the parsing for origin4:1:2 which will take the first number as long
tim-preston
@tim-preston
OK sounds good
Thomas Mangin
@thomas-mangin
Untested, not added any unittesting but should work (otherwise shout here)
going into a meeting will be back in around one hour
Thomas Mangin
@thomas-mangin
hope it helps:
tim-preston
@tim-preston
Only just got got around to re-testing. Had to do some work on my config generator amongst other things
Seems it still doesn't like this which I believe is valid
origin:20632:197303
RFC4360 is not very helpful about this, but from looking at the IANA assignments I believe that origin should be valid for Transitive Two-Octet AS-Specific, Transitive Four-Octet AS-Specific & Transitive IPv4-Address-Specific Extended Community Sub-Types so origin:<2 octet number>:<4 octet number> should be fine
tim-preston
@tim-preston
Still throws error: 'H' format requires 0 <= number <= 65535
I think all my other real-world extended communities are getting through otherwise
Thomas Mangin
@thomas-mangin
That should definitively work
Could you please send me the line which is sending this
So I can fix it ..
(a copy and paste of the trace per mail will do)
I am in transit to London ( going to check our BETT stand tonight )
So I may be able to fix the issue in the next 30 minutes .. or it will be .. later ...
Thomas Mangin
@thomas-mangin
Try now
I think the bug is now squashed
Please use my thomas-mangin tree not pushed to Exa-Networks yet
nice ! gitter support vi search and replace correction on the last line entered :clap:
tim-preston
@tim-preston
Thanks, just had something come so may have to delay testing until tomorrow. Will let you know
Thomas Mangin
@thomas-mangin
nope - still broken ...
hopefully fixit it before the trains arrives at kx
tim-preston
@tim-preston
Had my lab setup in a frozen state for most of this week whilst I've been trying to reproduce something. So I've only just got around to looking at this again. I've run my config through the current thomas-mangin tree code and it's now accepting all my real-world-harvested extended-communities, I'm using the 'L' form rather than the origin4/target4 forms. Cheers for sorting this quickly =)
Thomas Mangin
@thomas-mangin
Good :-)
If you need anything I will be available tomorrow PM
And at the London office Monday :smile:
Aaron Kalin
@martinisoft
Hiya. Is anyone around to help debug a stacktrace on the latest ExaBGP release?
Getting what looks like a parsing error
Aaron Kalin
@martinisoft
I'm updating a public Chef cookbook and trying to get it to actually build normally.
Thomas Mangin
@thomas-mangin
Going to look
Ok will need to try 0 as community
Please try 0:0
[0:0]
Aaron Kalin
@martinisoft
Trying that now