Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 17 20:10
    elindsey commented #927
  • Oct 17 20:05
    elindsey commented #927
  • Oct 17 20:00
    elindsey commented #927
  • Oct 17 19:36
    pguibert6WIND commented #927
  • Oct 17 19:34
    pguibert6WIND commented #927
  • Oct 17 18:54
    martinohansen closed #925
  • Oct 17 18:54
    martinohansen commented #925
  • Oct 17 16:57
    elindsey commented #927
  • Oct 17 16:32
    elindsey commented #927
  • Oct 17 16:27
    elindsey commented #927
  • Oct 17 16:26
    elindsey commented #927
  • Oct 17 16:26
    elindsey commented #927
  • Oct 17 16:05
    pguibert6WIND commented #927
  • Oct 17 16:03
    thomas-mangin labeled #927
  • Oct 17 16:02
    thomas-mangin assigned #927
  • Oct 17 16:02
    thomas-mangin commented #927
  • Oct 17 16:00
    thomas-mangin commented #927
  • Oct 17 15:53

    thomas-mangin on master

    fix AFI for next-hop self when … (compare)

  • Oct 17 15:37
    pguibert6WIND commented #927
  • Oct 17 15:36
    pguibert6WIND commented #927
Thomas Mangin
@thomas-mangin
I have not used it myself, we have some home cooked code and always configure the IPs on the servers (and just not announce the MAC on the net)
old but still valid
Ben Agricola
@benagricola
lol, so the healthcheck script adds the loopback ip
but doesn't remove it on exit
and then fails on next start if it already exists :D
i'll patch that to check if the IP exists and not attempt to re-add it
Ben Agricola
@benagricola
ahh, looks like an issue trying to parse the output of ip addr show to find existing IPs :)
Thomas Mangin
@thomas-mangin
is it something you should open an issue on github ?
Ben Agricola
@benagricola
yep, will do
the change to the regex is simple i think
it's looking for some trailing spaces after the 'loopback IP label' which appear to not exist in the output from ip addr show on our machines :)
(\s+.), I'm not sure why it's not just . because the trailing info doesn't matter (even if it does exist) once the label is parsed out
also just having a quick look at the daemonisation order - exabgp runs daemon.daemonize() prior to process.start() so that explains why it's necessary to run exabgp as root in order to have the healthchecker also run as root!
Thomas Mangin
@thomas-mangin
ok - I may change this - can you please open an issue raising it. It MAY not be possible for other issues … but I can not recall and should investigate
Ben Agricola
@benagricola
yeah will do
i'll submit a PR for the regex change in healthcheck.py too
Thomas Mangin
@thomas-mangin
Thanks
Thomas Mangin
@thomas-mangin
@vincentbernat - it seems the code need to not failover if the IP is already there and perhaps intercept SIGTERM to perform the IP removal ?
Ben Agricola
@benagricola
@thomas-mangin when it correctly detects the IP already exists it doesn't error which is fine
but intercepting sigterm to remove it is probably a good idea anyway
Ben Agricola
@benagricola
heh, so I had a look at removing the IP address on sigterm as well
it's only possible if the healthcheck script runs as root
obviously if you have it drop privileges it's no longer able to remove the IP address on sigterm :D
Ben Agricola
@benagricola
@thomas-mangin is it possible to set a default med for each neighbour or template? or would that only be possible by modifying the announcement made to exabgp?
Thomas Mangin
@thomas-mangin
No .. sorry, feature request but I do not know yet how I would implement it.
Ben Agricola
@benagricola
@thomas-mangin no worries :)
Bo-Han Liao
@hankofficer
Hello everyone, I'd like to ask a question. Hope I didn't cause any inconvenience here. .u.
I tried to run to exabgp on Windows but got no luck, it seems I need to find several Unix modules in order to get it work. Do anyone have idea or tips how to make it run on Windows?
Btw I'm glad I found this software on github, this could save a lot of time. keep up the good work! :smile:
Thomas Mangin
@thomas-mangin
Sorry ExaBGP is unix only ...
To run it on windows: install virtualbox, run linux on it :wink:
Bo-Han Liao
@hankofficer
Aww okay. Thanks for help. :)
Vincent Bernat
@vincentbernat
@thomas-mangin I have some difficulties to package the new ExaBGP in Debian. qa/bin/conversation is timeoutting for all tests, except E and K
Is there some easy way to make those tests more verbose?
Or from the top of your head, is there anything that changed significantly since 3.4.13 on this part?
Thomas Mangin
@thomas-mangin
Hi @vincentbernat - I am not sure myself. The test are successful on my laptop but fail on travis-CI but pass on codeship !
I added one test and I am forking two processes per test. Could it be that I am hitting some limit somewhere ?
Vincent Bernat
@vincentbernat
I'll investigate a bit, I was just asking in case you had already a clue.
Thomas Mangin
@thomas-mangin
sorry - no clues as all the tests are fine individually
Vincent Bernat
@vincentbernat
@thomas-mangin: I am wondering if the problem doesn't lie in the two communicate()
if the daemon outputs too much, it will block
Vincent Bernat
@vincentbernat
also, the communicate() in dispatch is a bit late: if a process has more than 8 or 16kb to write, it will just block
Vincent Bernat
@vincentbernat
however, in my case, this doesn't seem to be the problem
but it would be easier to debug if the script was collecting output from both programs iteratively, instead of relying on communicate()
for example each output could be collected in a thread, or a loop with select()
Vincent Bernat
@vincentbernat

I am also getting this:

Sun, 20 Mar 2016 00:02:48 | ERROR    | 29879  | configuration | syntax error in section process
Sun, 20 Mar 2016 00:02:48 | ERROR    | 29879  | configuration | line 12: run ./api-nexthop-self.run ;
Sun, 20 Mar 2016 00:02:48 | ERROR    | 29879  | configuration |
Sun, 20 Mar 2016 00:02:48 | ERROR    | 29879  | configuration | can not execute directories "/etc/exabgp"

when /etc/exabgp exists.

Unfortunately, I don't have much time this week.
I could just skip those tests
I suppose it's important you run them, I don't need to run them myself
Thomas Mangin
@thomas-mangin
Thank you - I will look into this /etc/exabgp issue
You can indeed skip the tests - I run them on my laptop before release