Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 12:08
    thomas-mangin labeled #911
  • 12:03
    thomas-mangin closed #910
  • 12:03
    thomas-mangin commented #910
  • 09:31
    thomas-mangin commented #911
  • 09:29
    thomas-mangin labeled #911
  • 09:28
    thomas-mangin assigned #911
  • 03:58
    andy19910403 edited #911
  • 03:58
    andy19910403 opened #911
  • Aug 15 14:15
    vincentbernat commented #910
  • Aug 15 07:46
    sincerywaing edited #910
  • Aug 15 05:19
    sincerywaing opened #910
  • Aug 14 21:40
    Vascko commented #909
  • Aug 13 10:04
    thomas-mangin labeled #909
  • Aug 13 10:04
    thomas-mangin assigned #909
  • Aug 13 10:02
    thomas-mangin commented #909
  • Aug 12 07:32
    wavezhang commented #908
  • Aug 12 07:32
    wavezhang commented #908
  • Aug 11 23:04
    Vascko opened #909
  • Aug 09 21:44
    thomas-mangin commented #908
  • Aug 09 21:44

    thomas-mangin on master

    accepting patch suggestion from… (compare)

Thomas Morin
@tmmorin
@thomas-mangin I was wondering if there were plans to do a release based on the exabgp master branch (4.0.0?)
@thomas-mangin asking, because this would help CI and packaging work on networking-bagpipe (openstack stuff)
Thomas Mangin
@thomas-mangin
Yes, I am planning to do a 4.0.0 (unstable) release soon - just want to change a little how the template works in the config file
as once it is released I will not be able to change the format
If you want to create a branch for yourself, feel free - I can give you access to the repo if you do not already have it
Thomas Morin
@tmmorin
nice to hear @thomas-mangin that 4.0.0 is coming soon
a branch would not help a lot, what will help though is having a pypi release
this is great
!
Thomas Morin
@tmmorin
hi @thomas-mangin, are you around ?
integrating bagpipe (networking-bagipe & bagpipe-bgp) into openstack would require declaring exabgp as an "official" requirement of the openstack project
there a few things to check before this is possible: https://github.com/openstack/requirements#for-new-requirements
most of these are ok (maitained code, licence, packaged in key distros)
Thomas Mangin
@thomas-mangin
so need to make sure the code is P3 happy
Thomas Morin
@tmmorin
yes, this is the key obstacle I see remaining
"At this point adding non python 3 compatible libraries should only be done under extreme need. It should be considered a very big exception."
I think it will be hard to get an "exemption"
I can try though, but having an idea of your plans would help
I can possibly give some help to make the code py3 happy where it is not
Thomas Mangin
@thomas-mangin
It reads like “must do"
I will but atm my coding time is very limited
Thomas Morin
@tmmorin
well... yes...
I guess you will accept py3 fixing patches if I provide any ?
Thomas Mangin
@thomas-mangin
oh ! yes :-)
Thomas Morin
@tmmorin
@thomas-mangin ok, I'll probably push some as I find issues...
Thomas Morin
@tmmorin
hi @thomas-mangin
i'm trying to grab the low hanging fruits of py2 to py3 adaptations
my assumption is, of course, that the resulting code would still run under py27/26
are you ok with "six" as a dependency that makes it easy to write code working both under py27 and py26 ?
Thomas Morin
@tmmorin
(sorry: I meant under both py27 and py3x)
Thomas Mangin
@thomas-mangin
no issue if the required code is available in the vendoring (previously deps) folder
Thomas Morin
@tmmorin
ah... not the case with "six" package...
Thomas Mangin
@thomas-mangin
This message was deleted
what do you mean ?
Thomas Morin
@tmmorin
"six" package is not under vendoring
i'll see if I can do something clean enough without this package
Thomas Mangin
@thomas-mangin
nope, what I mean is that if you want to use six, just copy the code in the vendoring folder in lib/exabgp and use this reference so users do not have to have it installed
Thomas Morin
@tmmorin
I can do that
Thomas Mangin
@thomas-mangin
that’s it - I use a few third party libs but have it installed that way
Thomas Morin
@tmmorin
out of curiosity: why not accept fairl y standard deps (like six) ?
Thomas Mangin
@thomas-mangin
historical mostly, at first exabgp had no deps and it made it easy to install .. all you need is the tarball .
there is deps for testing and for health check tho
but it is not “core"
Thomas Morin
@tmmorin
would the introduction of externals (non vendored-in) deps be perhaps acceptable for running under python3 ?
Thomas Morin
@tmmorin
here are the kind of fixes I would like to push to you: https://github.com/tmmorin/exabgp/commits/master (not finished, will do a PR when ready)
Thomas Mangin
@thomas-mangin
Sure - that would be great .. feel free to change the default python to python3 in the run script too
Thomas Morin
@tmmorin
what I'm trying to do is make things py27/py3 compatible
Thomas Mangin
@thomas-mangin
sure :-) good - thank you
Thomas Morin
@tmmorin
switching the default to python3 won't be doable after much much more changes/testing
so I won't touch the run script for now