Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 10:20
    ykondratov edited #917
  • 10:16
    ykondratov opened #917
  • Sep 19 10:23
    mattoddy commented #916
  • Sep 18 10:26
    thomas-mangin commented #916
  • Sep 18 08:27
    mattoddy opened #916
  • Sep 14 11:24
    pettai closed #912
  • Sep 14 11:24
    pettai commented #912
  • Sep 12 10:42
    thomas-mangin commented #915
  • Sep 12 09:15
    omkartikare closed #915
  • Sep 12 09:15
    omkartikare edited #915
  • Sep 12 07:53
    omkartikare edited #915
  • Sep 12 07:52
    omkartikare opened #915
  • Sep 11 15:30
    mattoddy commented #913
  • Sep 09 11:27
    thomas-mangin commented #912
  • Sep 08 08:12
    thomas-mangin commented #912
  • Sep 05 11:22
    pettai commented #912
  • Sep 05 10:37
    thomas-mangin commented #912
  • Sep 05 10:31
    thomas-mangin commented #912
  • Sep 05 10:07
    pettai commented #912
  • Sep 05 10:06
    pettai commented #912
Thomas Morin
@tmmorin
a branch would not help a lot, what will help though is having a pypi release
this is great
!
Thomas Morin
@tmmorin
hi @thomas-mangin, are you around ?
integrating bagpipe (networking-bagipe & bagpipe-bgp) into openstack would require declaring exabgp as an "official" requirement of the openstack project
there a few things to check before this is possible: https://github.com/openstack/requirements#for-new-requirements
most of these are ok (maitained code, licence, packaged in key distros)
Thomas Mangin
@thomas-mangin
so need to make sure the code is P3 happy
Thomas Morin
@tmmorin
yes, this is the key obstacle I see remaining
"At this point adding non python 3 compatible libraries should only be done under extreme need. It should be considered a very big exception."
I think it will be hard to get an "exemption"
I can try though, but having an idea of your plans would help
I can possibly give some help to make the code py3 happy where it is not
Thomas Mangin
@thomas-mangin
It reads like “must do"
I will but atm my coding time is very limited
Thomas Morin
@tmmorin
well... yes...
I guess you will accept py3 fixing patches if I provide any ?
Thomas Mangin
@thomas-mangin
oh ! yes :-)
Thomas Morin
@tmmorin
@thomas-mangin ok, I'll probably push some as I find issues...
Thomas Morin
@tmmorin
hi @thomas-mangin
i'm trying to grab the low hanging fruits of py2 to py3 adaptations
my assumption is, of course, that the resulting code would still run under py27/26
are you ok with "six" as a dependency that makes it easy to write code working both under py27 and py26 ?
Thomas Morin
@tmmorin
(sorry: I meant under both py27 and py3x)
Thomas Mangin
@thomas-mangin
no issue if the required code is available in the vendoring (previously deps) folder
Thomas Morin
@tmmorin
ah... not the case with "six" package...
Thomas Mangin
@thomas-mangin
This message was deleted
what do you mean ?
Thomas Morin
@tmmorin
"six" package is not under vendoring
i'll see if I can do something clean enough without this package
Thomas Mangin
@thomas-mangin
nope, what I mean is that if you want to use six, just copy the code in the vendoring folder in lib/exabgp and use this reference so users do not have to have it installed
Thomas Morin
@tmmorin
I can do that
Thomas Mangin
@thomas-mangin
that’s it - I use a few third party libs but have it installed that way
Thomas Morin
@tmmorin
out of curiosity: why not accept fairl y standard deps (like six) ?
Thomas Mangin
@thomas-mangin
historical mostly, at first exabgp had no deps and it made it easy to install .. all you need is the tarball .
there is deps for testing and for health check tho
but it is not “core"
Thomas Morin
@tmmorin
would the introduction of externals (non vendored-in) deps be perhaps acceptable for running under python3 ?
Thomas Morin
@tmmorin
here are the kind of fixes I would like to push to you: https://github.com/tmmorin/exabgp/commits/master (not finished, will do a PR when ready)
Thomas Mangin
@thomas-mangin
Sure - that would be great .. feel free to change the default python to python3 in the run script too
Thomas Morin
@tmmorin
what I'm trying to do is make things py27/py3 compatible
Thomas Mangin
@thomas-mangin
sure :-) good - thank you
Thomas Morin
@tmmorin
switching the default to python3 won't be doable after much much more changes/testing
so I won't touch the run script for now
Thomas Mangin
@thomas-mangin
Yes, it will be the last patch :p
Thomas Morin
@tmmorin
well, I would even let the decision up to the end user or packager...
Thomas Morin
@tmmorin
hi @thomas-mangin
I've got a PR ready with a bunch of python3-related changes
Thomas Mangin
@thomas-mangin
Go for it :-)
Thomas Morin
@tmmorin
this is not something that makes exabgp python3 ready, but at least the whole QA suite seems to pass both in py2 and py3