Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 15 14:15
    vincentbernat commented #910
  • Aug 15 07:46
    sincerywaing edited #910
  • Aug 15 05:19
    sincerywaing opened #910
  • Aug 14 21:40
    Vascko commented #909
  • Aug 13 10:04
    thomas-mangin labeled #909
  • Aug 13 10:04
    thomas-mangin assigned #909
  • Aug 13 10:02
    thomas-mangin commented #909
  • Aug 12 07:32
    wavezhang commented #908
  • Aug 12 07:32
    wavezhang commented #908
  • Aug 11 23:04
    Vascko opened #909
  • Aug 09 21:44
    thomas-mangin commented #908
  • Aug 09 21:44

    thomas-mangin on master

    accepting patch suggestion from… (compare)

  • Aug 08 12:53
    vincentbernat commented #908
  • Aug 08 12:48
    vincentbernat commented #908
  • Aug 08 10:36
    thomas-mangin commented #908
  • Aug 08 10:35
    thomas-mangin commented #908
  • Aug 08 10:33

    thomas-mangin on master

    free resources before calling t… (compare)

  • Aug 08 10:30

    thomas-mangin on master

    withdraw routes when exit treate EXIT as DISABLE for metr… fix bug that reload and termina… and 2 more (compare)

  • Aug 08 10:30
    thomas-mangin closed #908
  • Aug 08 08:12
    wavezhang synchronize #908
Thomas Mangin
@thomas-mangin
pypy has python3 support for some time now .. on my mac, brew intall pypy3 gives
Thomas Morin
@tmmorin
@thomas-mangin hi :)
Thomas Mangin
@thomas-mangin
Hi
Thomas Morin
@tmmorin
bagpipe is actually a bit more than only exabgp bgp message classes, and uses also the classes required to setup Connections
Thomas Mangin
@thomas-mangin
Ah!
Thomas Morin
@tmmorin
about pypy: "Tuesday, March 21, 2017 / PyPy2.7 and PyPy3.5 v5.7 - two in one release
The PyPy team is proud to release both PyPy2.7 v5.7 (an interpreter supporting Python v2.7 syntax), and a beta-quality PyPy3.5 v5.7 (an interpreter for Python v3.5 syntax)."
Thomas Mangin
@thomas-mangin
Do you use the peer and/or connection classes
Thomas Morin
@tmmorin
Yes, we use both.
Thomas Mangin
@thomas-mangin
Here goes my hope to use yield from....
Thomas Morin
@tmmorin
:-(
the positive aspect is that you good release exabgp4 sooner, isn't it ? :)
Thomas Mangin
@thomas-mangin
I still want to release it as python 3
Thomas Mangin
@thomas-mangin
So no, not sooner :worried:
Vincent Bernat
@vincentbernat
@thomas-mangin I see there is code for EVPN NLRI, but I don't see code for sending/receiving them with the text API.
Or maybe it would work with some generic syntax?
Thomas Mangin
@thomas-mangin
Yes evpn is receive only atm
Vincent Bernat
@vincentbernat
So, we can receive them with the text API ?
I could implement sending them.
Since the syntax is already here.
Thomas Mangin
@thomas-mangin
I believe the patch I got was Json only
Vincent Bernat
@vincentbernat
JSON would work for me too. It's in ExaBGP 4 then?
Thomas Mangin
@thomas-mangin
Yes it is
imperalix
@imperalix_twitter
I was reading the release notes for 3.4.17 (https://github.com/Exa-Networks/exabgp/blob/3.4/CHANGELOG#L36), does this mean you can now specify an ipv6 router-id?
Thomas Mangin
@thomas-mangin
No a router id is a 32 bits number expressed as a quad byte, like an IPv4 but it is not an IP. Please do reply here as otherwise all my idevices will notify me and awake my family. Good night it is 11pm here.
imperalix
@imperalix_twitter
Great, thanks.
Brian Johnson
@brijohn
@thomas-mangin What is the point of commit 04a026a1e98b29fa3bab30 on master? It looks like its designed to keep reading until you get a full line of text, but readline by itself should always return a full line.
This commit introduced a bug on EOF, but from looking at the code it seems like whenever readline returns it will always have an entire line so I'm not sure why that logic exists.
Thomas Mangin
@thomas-mangin
Trying to figure out what you mean … @brijohn
Readline behaves differently on different OS ...
This code should be harmless if the line is not received in full, I could do better and split on \n should we get mid buffer tho ..
But I agree it should not happen
unless the data is > 4k - what I expect a normal kernel read buffer to be, as in this case it may return partial data
Brian Johnson
@brijohn
Ah, I was looking at that and it seemed like readline would always return a full line of text, testing on linux seemed to confirm that. So it behaves differently on different platforms then?
Thomas Mangin
@thomas-mangin
readline has subtile variations betwen unix and bsd - can not recall the exact details.
Brian Johnson
@brijohn
This came up because that commit breaks things if the backend process dies, in which case readline returns an empty string due to an EOF condition and will then sit there in an infinite loop forever.
Thomas Mangin
@thomas-mangin
Yes, it should handle the ‘’ condition, do you want to add it ?
please ? pretty please ?
Brian Johnson
@brijohn
Yeah I was going to fix that, i just wasn't sure about the logic of the patch that broke things since it didn't seem to actually ever do anything.
Thomas Mangin
@thomas-mangin
sure - I now understand.
Thomas Mangin
@thomas-mangin
@brijohn Thank you for the two fixes :+1:
imperalix
@imperalix_twitter
I want to manage what IP addresses exabgp advertises. I was going down the route of adding the ip to my healthcheck config. However, I see that when i send a SIGUSR1, exabgp doesn't reload the healthcheck config.
Thomas Mangin
@thomas-mangin
Happy to discuss it tomorrow GMT
imperalix
@imperalix_twitter
Sounds good, thanks.
Justin
@JustinAzoff
@imperalix_twitter you should look into using a 'process' section in your config
the process just needs to output to stdout announce/withdraw statements
imperalix
@imperalix_twitter
@JustinAzoff Maybe that's my problem. I have a default process that has run .../healthcheck.py -F healthcheck.cfg
and i'm updating healthcheck.cfg with my health check command and vip
Justin
@JustinAzoff
ah.. then it sounds like you need to be HUPing your healthcheck process, not exabgp