yup, yup
Okay. Customized FluentAssertions it is, not unlike BeAnExceptionOfType.
@LukeMarlin, is this something you're comfortable with/interested in? I'd be happy to work on the change if not, but I realize it's blocking you, so maybe the timing works better if you investigate?
Whatever you prefer.
Sorry folks. Gotta run. Time to clean up and maybe hang some pegboard.
What would be the best way, replacing all /r/n with /n, the check that the resulting strings are equal, or going through them via a loop to avoid "duplicating" the strings?
Or I suppose
\r\n|\r|\n with System.Environment.NewLine. Or is this even necessary? I've been out of the Mac game for a while. Bare \rs have gone out of fashion, right?
Ah. Seems we switched over about 19 years ago. Probably no need to worry about it then.
... and VS is not responding, so I'll be delayed in confirming!
there
I looked at
BeAnExceptionOfType as mentionned
If yes, it can just be a tweak to that method, and use it everywhere there are verbatim. Might be easier than finding a name to the new FluentAssertion I'm trying to write, what do you think?
It's also possible to replace the 3 occurences of that method by verbatims, whatever you think makes the most sense
Great question! Maybe. It looks like the sort of thing I would make up, and it's used in 3 tests, but never spread. Probably we forgot about it immediately after it was made.
I see your point. Join with
I see your point. Join with
Environment.NewLine. I'm agnostic. Either approach would be fine with me.
You calling me old?
lol
I'm headed back out to the garage. Will support whatever you guys decide.
And don't be sorry, @LukeMarlin. We welcome questions. I feel a little bad for you that things weren't set up right for you to tackle the issue you care about, but this movement toward supporting builds on Linux is kind of exciting to me.
And don't be sorry, @LukeMarlin. We welcome questions. I feel a little bad for you that things weren't set up right for you to tackle the issue you care about, but this movement toward supporting builds on Linux is kind of exciting to me.
I understand why this was not comfortable then :D
What would be your take on the three options we've covered:
1)
String.WithNormalizedLineEndings, and use normal assertions
2) Some custom fluentAssertion, but I cannot find a name that would be practical and clear (ideas?)
3) Reuse of that old method, with
Environment.NewLine instead
Not sure about the name... You could use the same names as the existing assertions, but with some meaningful prefix, I think
Should().BeEquivalentExpectLineEndings()?
I took out Equivalent because that already have a meaning in FluentAssertions
And I thought "Modulo" was more precise, although it might be more obscure
(sense 2 in https://www.yourdictionary.com/modulo)