FakeItEasy/FakeItEasy

The easy mocking library for .NET - http://fakeiteasy.github.io

Luke Marlin

@LukeMarlin

Maybe it's possible to expose a restricted version of it?

With a new interface. It's not like one more is going to be too much at that point :D

Thomas Levesque

@thomaslevesque

Maybe we should split it into 2 different interfaces, one to specify what is matched, and one to specify how it behaves.

Anyway, it would be a significant refactoring, I think.

Not something to undertake lightly

Blair Conrad

@blairconrad

What bothers me is that this interface doesn't just encapsulate which calls should be matched, but also how these calls should behave

Yeah, I was tracking down the interfaces we return from the various A.CallTo and A.CallToSets (and extensions such as WithAnyArguments and To) and wondering if we could provide a very narrow interface that's all about the call validation.

it would be a significant refactoring, I think.

Well, we are about to break things anyhow. Then again, we'd need to look at the scope of the breakage and balance it against the utility of the feature.

And now I'm wondering about Fake<T>.CallsTo!

Thomas Levesque

@thomaslevesque

Another issue, currently, is that call rules are mutable. What is called BuildableCallRule is really MutableCallRule. If we introduce something like AsRule() like in my example above, the rule that is returned should really be a snapshot of the state of the rule when AsRule() is called. Otherwise, we could have things like this:

var callToConfigure = A.CallTo(() => fake.Foo());
var rule = call.AsRule();
callToConfigure.Where(... ) // rule modified here
    .Returns(42);

Blair Conrad

@blairconrad

I guess it returns the same set of interfaces, so...

Yeah, and I don't love AsRule to begin with. I'd rather have immutable rules inside.

Thomas Levesque

@thomaslevesque

I'd rather have immutable rules inside.

Me too. If they were immutable, each call to a configuration method would return a new instance. And it could directly implement IFakeObjectRule (or at least a new interface that exposes IsApplicableTo)

And it could directly implement IFakeObjectRule (or at least a new interface that exposes IsApplicableTo)

Or maybe not, because then IsApplicableTo would show up in Intellisense for configuration interfaces, which would be messy

Blair Conrad

@blairconrad

Hide it like we do with IHideObjectMembers?

I know, doesn't hide it for all...

Thomas Levesque

@thomaslevesque

(sorry if this is all a little confusing, I'm thinking as I type...)

Blair Conrad

@blairconrad

(Me too.)

Thomas Levesque

@thomaslevesque

Anyway, I think we should formalize (as an interface) what constitutes a "call specification", i.e. what calls should be matched, and make that immutable. This interface would provide a way to match a call. And the "behavior" methods (Returns, Throws, etc) would work with that.

It would make the whole configuration API easier to think about, I think.

Blair Conrad

@blairconrad

Oh, do you find it difficult now?
:stuck_out_tongue_winking_eye:

Thomas Levesque

@thomaslevesque

I always did!

Blair Conrad

@blairconrad

It breaks my head!

Yeah, even when it was "easy", it was hard.

Recent additions like property setters and ordered calls did not help.

Thomas Levesque

@thomaslevesque

Anyway, the existing configuration interfaces wouldn't disappear. They're still needed for fluent configuration. It's just that we would have a common base interface to represent "which calls are matched"

Blair Conrad

@blairconrad

https://twitter.com/fakeiteasyfx/status/1194975748412579845

Blair Conrad

@blairconrad

New FakeItEasy! 5.5.0:
https://twitter.com/fakeiteasyfx/status/1198930278758137856

Thomas Levesque

@thomaslevesque

New FakeItEasy! 6.0.0-beta.1
https://twitter.com/fakeiteasyfx/status/1207622933574823936

Blair Conrad

@blairconrad

And also analyzers!!
https://twitter.com/fakeiteasyfx/status/1207628979127148545

Blair Conrad

@blairconrad

New production release of FakeItEasy! 6.0.0
https://twitter.com/fakeiteasyfx/status/1218140938654142466

Thomas Levesque

@thomaslevesque

FakeItEasy 6.0.1 released
https://twitter.com/fakeiteasyfx/status/1248669306503692289

Alper

@asunar

Is there any guidance on when to use the AutoFake.Dispose method? When working with objects implementing IDisposable?

Thomas Levesque

@thomaslevesque

Hi @asunar, I'm not sure what you're referring to... there's nothing called AutoFake in FakeItEasy

Alper

@asunar

I meant an instance of AutoFake.

Thomas Levesque

@thomaslevesque

Oh, do you mean this? https://autofaccn.readthedocs.io/en/latest/integration/fakeiteasy.html

Using the Autofac.Extras.FakeItEasy package?

Alper

@asunar

private readonly AutoFake _faker;
// later
 _faker?.Dispose();

Thomas Levesque

@thomaslevesque

We don't maintain this, it's made by the AutoFac folks

Alper

@asunar

oops yes, sorry. Looks like it's in Autofac.Extras.FakeItEasy

Thomas Levesque

@thomaslevesque

You should probably ask in this repo: https://github.com/autofac/Autofac.Extras.FakeItEasy

Alper

@asunar

Thank you.

Thomas Levesque

@thomaslevesque

Or in their Gitter, if they have one

Alper

@asunar

Awesome, thanks.

Blair Conrad

@blairconrad

Sadly, they kind of don't maintain it either. It's a contributed repo, and neither Autofac nor FakeItEasy know enough about it to be really responsible…

Consider asking in https://gitter.im/autofac/Autofac

Hi, @asunar.

Alper

@asunar

Hello, @blairconrad thanks for the info.

Blair Conrad

@blairconrad

At a guess, though, I'd probably never call it. Just make a new AutoFake for each test and throw 'em away when done. They'll clean themselves up eventually.

Blair Conrad

@blairconrad

Wondering when FakeItEasy 6.1.0 will be available? Wonder no longer!
https://twitter.com/fakeiteasyfx/status/1269945609181675520

New string argument constraints! A way to make strict fakes be a little lenient when it comes to object methods! et cetera!

Mrugala Fabrice

@MrugalaFabrice_twitter

Hi, Is FakeItEasy usable with Visual Basic 2017 ?

Thomas Levesque

@thomaslevesque

Hi @MrugalaFabrice_twitter,
Yes, you can use it with VB in Visual Studio 2017, if that's what you meant

Where communities thrive

People

Repo info

Activity