Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Marak
    @Marak
    I run ad block locally through https://github.com/StevenBlack/hosts and also Opera extensions
    2 replies
    Tobias Witt
    @ohcibi
    ya the point is, if its your own app you wil get pretty much worried about it soon
    Marak
    @Marak
    So I see a lot of those issues
    Will checkout BugSnag, thanks
    Tobias Witt
    @ohcibi
    so to add something is a good choice actually..
    Marak
    @Marak
    I'd like to get the top locales fully supported, that would probably be a good idea. de, fr, and es are good candidates. How does the de locale data look @ohcibi , do we need anything added? We can open up new Issues on the tracker
    Tobias Witt
    @ohcibi
    de developers usually don't care for the language of fake data (given the language they can work with is english, that is)... i'm not saying it is irrelevant but I need to look somewhat more closely into this... since you can provide formats for currencies and stuff i was never actually using that locale
    Marak
    @Marak
    For example, Address.streetAddress doesn't seem to return localized results for de
    Tobias Witt
    @ohcibi
    i also think this should be better separated.. its a locale but its also a set of fake data.... maybe make fake datasets its own repository and publish localized fake data sets as npm packages that need to beinstalled along with faker, similar to how fontawesome works
    Marak
    @Marak
    Yes, we've talked about that a lot. It's on the Issues as well. It's planned for v6 of the Roadmap
    Can't skip steps
    Tobias Witt
    @ohcibi
    thing is: we dont need german street names.. theres is nothing special to a street name in germany as far as i can remember i was able to create street names like "Iowa street 35" which is perfectly well for fake data even though there is no iowa street in germany most probably
    so to me as a german the de locale has one o the lowest priorities in this project... i cannot speak for other locales though.. but i guess out of the locale relevant stuff , formats are more important than actual fake data....... "January" is not a problem for our stakeholders.. "January, 23rd" could confuse them however
    Tobias Witt
    @ohcibi
    module["exports"] = [
      "#{street_name} #{building_number}"
    ];
    this is a proper german street address
    street name could be "梓晨" :laughing:
    Thing is: what is about companies that have a lot of international clients in their database? They would want english non-german street names with german format if they'd cared about the language
    i'd argue that this is in fact a pretty common usecase in most parts of western europe
    Christophe Gesché
    @Moosh-be

    IMHO Whe I was work for an opensource projet translated in 40 languages 15y ago, our locale code was
    en_US_context

    In our case Context was

    • Elementary
    • College
    • University
    • Works
    • OpenAcademy
    • ....

    I think this can be an inspriration to have

    • de_AT_national means german used in Austria, about national (austrian) stuff
    • de_AT_China means german used in Austria, about china stuff

    but it's so "fine" that we had use an heritage structure.

    En each list we define another local to use as fall back.

    For production we ha a builder to set "how many file (heritage) max can be load on run.
    And the builder merge data to have no more file (to load on run) than request.

    To cost was 'if we set on 1 max, it' generate one heavy file per combinaison, if we set No limit, no file was merged but, on run, can sometimes load 10-15 locales
    (it' was in 2004 lot of tool are perhaps better now ;)

    But so. As Agilist, I think "What need the final user ?"

    Did you have an idea of what people do really with faker ?

    Its more used for fill data in a test process ? more to fill data as Realist LoremIpsum ? other ?

    Marak
    @Marak
    @ohcibi - I find it's generally better to focus on the data and API instead of trying to assume what the intent of every single user is. We aren't really here to make arguments or make assumptions for the users. If you aren't interested in helping improve de locality that's fine.
    Tobias Witt
    @ohcibi
    @Moosh-be ive used faker a lot in projects. It’s suitable for both tests and development/prototyping given that your fake api is as easy accessible in both situations. There is a need for specific languages and phrases as the average length of strings differs depending on it, so to test your layout properly you need edge cases. Many of them however are so special that you end up using fixed data anyways. Text usually is Loren ipsum but having real sounding company names is nice in show cases besides the layout testing aspect. I created them from randomly combining 2-3 bsNouns and appending „Inc.“
    Tobias Witt
    @ohcibi
    @Marak you misunderstood me here. All I’m saying is the de locale is fine as it is. The only bad thing about it is that some modules use the fake api which suggests one can do this everywhere. But one can’t. I’ve replaced the occurrences in DE with lists of real city/street names and will push it this week. Just need to generate a bunch of numbers for the „street address“ fake data. There is public lists online and I think we can quickly fix up the top languages even if we don’t speak the Language with These. At least for most parts. Is it only about missing data and fake syntax or are there other issues? A very loud request is to make this library es6compatible. The locales are the only thing that prevent a fast (fast as in run 2-3 sed commands and it’s done) transition to that so I’m all in on getting these ready ASAP.
    Marak
    @Marak
    If you can provide any proof of example code for ES6 imports working with locales that would be great as a reference
    We also could use a script or toolchain or process to test treeshaking
    I hear you about de locale. It's pretty close actually, maybe just one or two methods are slightly off.
    Christophe Gesché
    @Moosh-be
    One more Iban fixed in my pr
    Marak
    @Marak
    Marak/faker.js#1112 is looking good @Moosh-be
    Are we ready to merge or should I hold off?
    1 reply
    Marak
    @Marak
    So I think the goal is to have ES6 imports working by April 1st. I think it's going to take about a month to get it right, I won't really know until we get a week or two in.
    kid-icarus
    @kid-icarus
    y so long?
    Marak
    @Marak
    ?
    If you can get it done in a shorter time @kid-icarus , we look forward to hearing your detailed plan or seeing your Pull Requests.
    Tobias Witt
    @ohcibi
    We should make a Blog/newssite and call it Fake(r)news 🤣
    2 replies
    Marak
    @Marak
    @Moosh-be - You got any ideas about this one? Marak/faker.js#1083
    Marak
    @Marak
    Can anyone figure out what's going on here? Marak/faker.js#756
    LBuerstmayr
    @lbuerste
    Hi all, I've recently opened a PR regarding the new datatypes module ( #1114 ) . Although the lib files are successfully merged, it has not been added to the faker.js itself nor is it in the Readme. I thought a contributor should only push the lib files and not touch the ones built by gulp. Was I wrong? :sweat_smile:
    Marak
    @Marak
    @lbuerste - Greetings!
    The code should be merged into master now. It will take a few cycles to see it get into the ReadMe and published version
    Marak
    @Marak
    @Moosh-be I'm going to merge Marak/faker.js#1118 is that okay?
    Marak
    @Marak
    How my fake people doing today?
    Christian
    @makepanic
    is there anything i can do to help Marak/faker.js#841 getting merged?
    Marak
    @Marak
    @makepanic - I think this week we can get it merged. Seems about time
    We managed to merge a lot of the pending PRs
    Welcome!
    Christophe Gesché
    @Moosh-be
    Hello sorry for the delay . Ok for 1118.
    I'm sorry some difficulty in real life
    Marak
    @Marak
    It's all good don't worry about it
    Christophe Gesché
    @Moosh-be
    and I'm currently trying to have a good install to check what I do. My lapttop is full managed by administrator, I can't install nothing It's still really difficult for me to "check" my code. Not good
    avou my investigation for error/warning in npm . I've nothing interresting found to help to progress.
    Marak
    @Marak
    @makepanic - This is super awesome you made this! https://github.com/Marak/faker.js/pull/1143#issuecomment-802714436