Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Tobias Witt
    @ohcibi
    We should make a Blog/newssite and call it Fake(r)news 🤣
    2 replies
    Marak
    @Marak
    @Moosh-be - You got any ideas about this one? Marak/faker.js#1083
    Marak
    @Marak
    Can anyone figure out what's going on here? Marak/faker.js#756
    LBuerstmayr
    @lbuerste
    Hi all, I've recently opened a PR regarding the new datatypes module ( #1114 ) . Although the lib files are successfully merged, it has not been added to the faker.js itself nor is it in the Readme. I thought a contributor should only push the lib files and not touch the ones built by gulp. Was I wrong? :sweat_smile:
    Marak
    @Marak
    @lbuerste - Greetings!
    The code should be merged into master now. It will take a few cycles to see it get into the ReadMe and published version
    Marak
    @Marak
    @Moosh-be I'm going to merge Marak/faker.js#1118 is that okay?
    Marak
    @Marak
    How my fake people doing today?
    Christian
    @makepanic
    is there anything i can do to help Marak/faker.js#841 getting merged?
    Marak
    @Marak
    @makepanic - I think this week we can get it merged. Seems about time
    We managed to merge a lot of the pending PRs
    Welcome!
    Christophe Gesché
    @Moosh-be
    Hello sorry for the delay . Ok for 1118.
    I'm sorry some difficulty in real life
    Marak
    @Marak
    It's all good don't worry about it
    Christophe Gesché
    @Moosh-be
    and I'm currently trying to have a good install to check what I do. My lapttop is full managed by administrator, I can't install nothing It's still really difficult for me to "check" my code. Not good
    avou my investigation for error/warning in npm . I've nothing interresting found to help to progress.
    Marak
    @Marak
    @makepanic - This is super awesome you made this! https://github.com/Marak/faker.js/pull/1143#issuecomment-802714436
    Marak
    @Marak
    okay, i just merged a few pending PRs. The next one will probably be #841, which is Linting. that might invalidate all the current PRs that are open
    if anyone sees any PRs we can merge make a comment / approval on the thread or try to see whats missing
    Christian
    @makepanic
    I could rework the image generation into a unit test for arrayElements. I think one could do the same thing for other methods like floats between 0 and 1 to check for an average 0.45 < x < 0.55 or similar
    Marak
    @Marak
    That sounds good @makepanic
    Christian
    @makepanic
    Marak
    @Marak
    v5.5.0 just published
    Christophe Gesché
    @Moosh-be
    :thumbsup:
    Marak
    @Marak
    @makepanic Do you have any idea about this one? Marak/faker.js#1148 It might be related to the System changes we made? I'm slightly confused
    Marak
    @Marak
    Seems like we broke es6 style imports somehow, oops. Need more tests re: Marak/faker.js#1150
    Marak
    @Marak
    yo, how do we actually test this? Marak/faker.js#1150
    Marak
    @Marak
    @makepanic - Additional issues today with Marak/faker.js#985 Seems you broke a few things
    Marak
    @Marak
    :-)
    Diego Fortes
    @dpw1
    Hi everyone! Is there anyway to give a specific set of countries for Faker to randomize from? Say I'd like to pick random states only from the USA and Russia, how could I do that? Thank you. :)
    Marak
    @Marak
    @dpw1 Nothing is built in, but you could select a random value from locales list and then use that to change faker.locale value?
    I've been considering similar functionality, but no one else asked for it. Would you open up a Github Issue for this?
    Marak
    @Marak
    @makepanic You alive? We could use a follow-up on the issue with System. I had to revert a few of your changes. Would like to get those back in.