FeedReader/Lobby

felix

@Stunkymonkey

let should_marked_read: Vec<ArticleID>;

this is an array, which contains all the articles, which are read remotely, but still unread local. Is there a function to set certain IDs as read? Because appending them to the returned SyncResult seems not right for me.

Jan Lukas Gernert

@jangernert

No, there is intentionally no way for backends to write to the db directly. The sync should be atomic. Also I would guess simply writing all the read states (as headlines) to the db in a single transaction is cheaper than filtering only the remotly read articles by checking the state of every id in the db.

Jan Lukas Gernert

@jangernert

Also why do you feel having the state updates in the sync result is incorrect? The SyncResultis a big pack of data with all the information needed to bring the local database up to date with what happened on the server side. Or as close as possible as the API reasonably allows.

felix

@Stunkymonkey

ok i get it, why there is no direct access. But I am still not understand how I should continue. converting a Headline into an Fatarticle does not seem right. Maybe you have a look at the latest commit.

felix

@Stunkymonkey

@jangernert
https://gitlab.com/news-flash/news_flash_base/-/merge_requests/9/diffs#715ea9a96a94f3c2f76917029e47409b6844d582_273_300
in this line i am having problems with. It contains all the remotely read articles, which have the "wrong" state locally. Am I supposed to convert the Headlines to FatArticles? which seems not really a good way. Is there another way?

btw. this is the line, why it is not compiling, because adding Vec<Headline> to Vec<FatArticle> does not work

felix

@Stunkymonkey

I feel quite stupid to be stuck on this problem for this long.

Jan Lukas Gernert

@jangernert

@Stunkymonkey Sorry, I was working on drag&drop the last few days. I'll take a look at it later tonight and tomorrow. Can I push to your branch? I think github had a button to allow it for MR. I'm not sure if its the same for gitlab.

felix

@Stunkymonkey

@jangernert thanks :thumbsup: . I granted write access to everyone who can merge this branch.

felix

@Stunkymonkey

i am curious if this is wanted:

[0/3] Generating cargo-build with a custom command
+ export OUTPUT=src/com.gitlab.newsflash
+ OUTPUT=src/com.gitlab.newsflash
+ export CARGO_TARGET_DIR=/home/felix/.cache/yay/newsflash-git/src/news_flash_gtk/_build/target
...

this resultes in an executable beeing called: com.gitlab.newsflash

felix

@Stunkymonkey

i also want to move the code to https://gitlab.com/news-flash/fever_api, but I go no initial write access there.
Sorry for having so many requests.

Jan Lukas Gernert

@jangernert

yeah, that's pretty stupid :D I had the same issue at work recently. I promoted you to maintainer of fever_api

felix

@Stunkymonkey

same maybe for this one:
https://gitlab.com/news-flash/greader_api

thanks for the access

Jan Lukas Gernert

@jangernert

@binary name: yes that is intended.

@greader_api: I would check first if the freshRSS API differs from the original google reader API. I think it's just google reader like. Otherwise the name of the crate would be confusing.

felix

@Stunkymonkey

they claim to be google reader compatible (at the bottom):
https://freshrss.github.io/FreshRSS/en/users/06_Mobile_access.html
this would mean the name is correct, but some additional features are supported

Jan Lukas Gernert

@jangernert

Okay, then the name is reasonable. Maybe think about putting all the additional freshRSS features behind a feature switch in the crate. Made you a maintainer there as well.

felix

@Stunkymonkey

the feature switch is a good idea :thumbsup:

felix

@Stunkymonkey

@jangernert thanks for your help
good night

felix

@Stunkymonkey

@jangernert super happy how fast the sync is now. thanks for your help.

Jan Lukas Gernert

@jangernert

I released a first beta :)

@Stunkymonkey there is someone having a problem with logging in to fever compatible self hosted service

I asked him to open a ticket and provide some information

maybe we can figure this out together https://www.reddit.com/r/gnome/comments/gb4tp6/newsflash_rss_client_10_beta/fp3ybva?utm_source=share&utm_medium=web2x

Bilal Elmoussaoui

@bilelmoussaoui

Hey o/

Congrats on the beta release

I have seen your message about the feedly secrets on Flathub, I can do the same thing we did for Gitlab CI for now until we have the proper infrastructure to support that

Jan Lukas Gernert

@jangernert

Thx

You mean you have access to the flathub internals and can add it there?

Cool! But we should probably wait a bit till the initial wave of bugs is fixed :)

Bilal Elmoussaoui

@bilelmoussaoui

I don't have access to all the internals but I know who to poke for that

You cans

*you can send a pull request to add it and we won't merge until you're ready, just to give us the time to add the tokens in place

felix

@Stunkymonkey

@jangernert sorry to inform you that this and the next two weeks are super busy. I will not work on the issues. sorry

Jan Lukas Gernert

@jangernert

no worries, it's not urgent

I wanted to implement the "fake" categories first anyway

felix

@Stunkymonkey

:thumbsup:

felix

@Stunkymonkey

currently my installation generates new_tree.json and old_tree.json in my home directory. What flags do i have to provide during installation, to prevent this?

Jan Lukas Gernert

@jangernert

should be deactivated already in master

news-flash/news_flash_gtk@dc5785b

btw: I'm still working on feedbin, then I can help out with the fever issues again

felix

@Stunkymonkey

give me time until next Tuesday (19th). then i can continue to work on it. Before this I will have two exams. Maybe I will have a break one or two days.

Jan Lukas Gernert

@jangernert

yeah, no pressure ... I was just mentioning where my focus is for the next few days

Jan Lukas Gernert

@jangernert

@Stunkymonkey I added http auth support to the fever_api crate. But you still need to push the new release to crates.io as you are the owner. Until then I'm stuck referencing the git version.

felix

@Stunkymonkey

currently getting some weird errors when building master

another error i am getting with fever:
Failed to update sidebar: 'Failed to get feed title for article'

felix

@Stunkymonkey

Where communities thrive

People

Repo info

Activity