Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 08 15:12

    gazpachoking on clean

    Automated ChangeLog update (compare)

  • Dec 08 15:08

    FlexGet-Bot on master

    Automated ChangeLog update (compare)

  • Dec 08 15:07

    FlexGet-Bot on v3.0.13

    (compare)

  • Dec 08 15:07

    FlexGet-Bot on master

    Prepare v3.0.13.dev [fix] web server inserts base_u… v3.0.13 (compare)

  • Dec 08 15:07

    FlexGet-Bot on develop

    v3.0.13 Prepare v3.0.14.dev (compare)

  • Dec 08 07:23
    metaMMA commented #2514
  • Dec 08 04:54
    metaMMA synchronize #2514
  • Dec 08 03:36
    FeromonDE closed #2520
  • Dec 07 20:09
    lllluqu opened #2522
  • Dec 07 19:18

    gazpachoking on clean

    Automated ChangeLog update (compare)

  • Dec 07 19:13

    FlexGet-Bot on master

    Automated ChangeLog update (compare)

  • Dec 07 19:12

    kristenmills on fix-webui-baseurl

    (compare)

  • Dec 07 19:12

    kristenmills on develop

    [fix] web server inserts base_u… (compare)

  • Dec 07 19:12
    kristenmills closed #2518
  • Dec 07 15:56
    Meeeeow edited #2450
  • Dec 07 03:02
    rue-ieaston commented #2443
  • Dec 06 22:35
    kristenmills review_requested #2518
  • Dec 06 21:18
    gazpachoking commented #2521
  • Dec 06 19:04
    paranoidi opened #2521
  • Dec 06 14:08
    gazpachoking edited #2520
FlexGet Bot
@FlexGet-Bot
gazpachoking (slack) True. Can just add a property like I did for the version
gazpachoking (slack) And have the class define its own name
gazpachoking (slack) Or, we could just ditch the module, and hope we don't run into collisions
gazpachoking (slack) Seems unlikely
paranoidi (irc) require giving unique name might be best
paranoidi (irc) by subclass
paranoidi (irc) well, I guess name is pretty similar
FlexGet Bot
@FlexGet-Bot
liiight (slack) Nice idea. How will that work with db synonym?
FlexGet Bot
@FlexGet-Bot
gazpachoking (slack) @liiight We'd probably move that util to use it
gazpachoking (slack) I just changed the name to drop the module name. Also made version a classmethod with 1 as the default. Both name and version can be overridden by the serializer classes when needed though.
FlexGet Bot
@FlexGet-Bot
paranoidi (irc) should we have built in support for expiring/purging? what if some plugins want to supplement additional metadata, like archive could add own table with extra columns and have SerializedEnrtry as FK
gazpachoking (slack) Are you thinking we'd have a separate table for entries now, so that when many plugins store it's only in one place?
gazpachoking (slack) In that case, I'd say they get purged when they are orphaned, and each plugin is still responsible for cleaning up its own table
gazpachoking (slack) A couple other questions: Are we worried about non-string entry field keys? That would require a tweak, as json doesn't have that. Also, do we need to store other stuff besides the fields, like the accepted state?
gazpachoking (slack) My inclination to both of those is no.
paranoidi (irc) state should not be there at all, but goal should be that all fields are serializeable regardless of their format
FlexGet Bot
@FlexGet-Bot
gazpachoking (slack) Entry class could check that fields are serializable when being set
gazpachoking (slack) So that plugin authors get an error when trying to store non-serializable stuff
gazpachoking (slack) And either change it, or implement the custom serialization
gazpachoking (slack) I guess we should store a version number on the entry serialization itself too, in case we change our minds at some point
FlexGet Bot
@FlexGet-Bot
paranoidi (irc) yeah, sounds reasonable
FlexGet Bot
@FlexGet-Bot
gazpachoking (slack) In fact, I should split out all that functionality to the Serializable class, then Entry can inherit that as well.
FlexGet Bot
@FlexGet-Bot
gazpachoking (slack) Okay, did a bit of refactoring, now serializing entries is using the same backend as serializing entry fields
FlexGet Bot
@FlexGet-Bot
SBan (discord) is there a way to slow down the speed to which flexget searches?
FlexGet Bot
@FlexGet-Bot
BrutuZ (discord) Would https://flexget.com/Plugins/domain_delay fit the bill?
metaMMA (discord) @BrutuZ Just beat me to it
metaMMA (discord) @SBan ^
SBan (discord) beauties, all of you
FlexGet Bot
@FlexGet-Bot
gazpachoking (slack) paranoidi: Hmm, if we switch to common entry storage in the db, how would we handle storing entries at different times, for example, if one plugin stores right after input, but another after a bunch of other fields have been attached.
FlexGet Bot
@FlexGet-Bot
paranoidi (irc) gazpachoking: good point, I guess we come back to the unique entry identifier which we've discussed few times
paranoidi (irc) ie, make it by hashing original title + original url
paranoidi (irc) entry could have internal counter for every change, so we can identify which one is newer version
paranoidi (irc) well, not so easily as lists etc are mutable and invisible for entry ;/
FlexGet Bot
@FlexGet-Bot
gazpachoking (slack) During one task run it wouldn't really be hard to see what's newer, but across task runs I don't know how that could work
FlexGet Bot
@FlexGet-Bot
gazpachoking (slack) How about serializing lazy fields. I was thinking that we'd require lazy functions to be registered under a name
gazpachoking (slack) So we can restore them based on the name
FlexGet Bot
@FlexGet-Bot
paranoidi (irc) by name you mean entry field .. or ?
gazpachoking (slack) I mean arbitrary name
gazpachoking (slack) @register_lazy_func('some name')
gazpachoking (slack) One lazy function can lookup many entry fields
gazpachoking (slack) And many lazy lookup functions can look up the same entry fields
gazpachoking (slack) So entry fields aren't really unique
paranoidi (irc) ah, true
gazpachoking (slack) If we want to serialize the function, we need some way to get the function back when loading
paranoidi (irc) yep, name seems good way
FlexGet Bot
@FlexGet-Bot
gazpachoking (slack) Hmm. Plugin methods complicate this a bit
gazpachoking (slack) If we register with a decorator, the method is unbound
gazpachoking (slack) @register_lazy_func('some name', plugin='somepluginname') ?
Dennis Gaida
@DennisGaida
hey is there any plugin you guys are aware of that parses JSON input? or maybe call an external python script that does exactly that? I guess I could write a plugin then anyways?
i have json in the format of {"status":"success","response":[{"TorrentID":"123","Category":"Linux","TimeAdded":"2019-12-01 12:12:29"}]}, pretty simple but not RSS