Wiki: https://flexget.com/ Forum: https://discuss.flexget.com/ Bugs: https://github.com/Flexget/Flexget/issues | Got a problem? Upload logs and config to a paste service
gazpachoking (slack) And have the class define its own name
gazpachoking (slack) Or, we could just ditch the module, and hope we don't run into collisions
gazpachoking (slack) Seems unlikely
paranoidi (irc) require giving unique name might be best
paranoidi (irc) by subclass
paranoidi (irc) well, I guess name is pretty similar
gazpachoking (slack) I just changed the name to drop the module name. Also made version a classmethod with 1 as the default. Both name and version can be overridden by the serializer classes when needed though.
gazpachoking (slack) Are you thinking we'd have a separate table for entries now, so that when many plugins store it's only in one place?
gazpachoking (slack) In that case, I'd say they get purged when they are orphaned, and each plugin is still responsible for cleaning up its own table
gazpachoking (slack) A couple other questions: Are we worried about non-string entry field keys? That would require a tweak, as json doesn't have that. Also, do we need to store other stuff besides the fields, like the accepted state?
gazpachoking (slack) My inclination to both of those is no.
paranoidi (irc) state should not be there at all, but goal should be that all fields are serializeable regardless of their format
gazpachoking (slack) So that plugin authors get an error when trying to store non-serializable stuff
gazpachoking (slack) And either change it, or implement the custom serialization
gazpachoking (slack) I guess we should store a version number on the entry serialization itself too, in case we change our minds at some point
metaMMA (discord) @BrutuZ Just beat me to it
metaMMA (discord) @SBan ^
SBan (discord) beauties, all of you
paranoidi (irc) ie, make it by hashing original title + original url
paranoidi (irc) entry could have internal counter for every change, so we can identify which one is newer version
paranoidi (irc) well, not so easily as lists etc are mutable and invisible for entry ;/
gazpachoking (slack) So we can restore them based on the name
gazpachoking (slack) I mean arbitrary name
gazpachoking (slack) @register_lazy_func('some name')
gazpachoking (slack) One lazy function can lookup many entry fields
gazpachoking (slack) And many lazy lookup functions can look up the same entry fields
gazpachoking (slack) So entry fields aren't really unique
paranoidi (irc) ah, true
gazpachoking (slack) If we want to serialize the function, we need some way to get the function back when loading
paranoidi (irc) yep, name seems good way
gazpachoking (slack) If we register with a decorator, the method is unbound
gazpachoking (slack) @register_lazy_func('some name', plugin='somepluginname') ?
i have json in the format of
{"status":"success","response":[{"TorrentID":"123","Category":"Linux","TimeAdded":"2019-12-01 12:12:29"}]}, pretty simple but not RSS