Give and receive constructive feedback from your fellow campers on Algorithm Challenge solutions, Frontend and Backend projects
freeCodeCamp. Please review and suggest any improvements .
:)
I published a react tooltip library on npmjs: npmjs.com/package/react-power-tooltip Would be great if you guys could have a look at it and give feedback. That would be awesome!!
Thanks for sharing such a great article or post on it. It is very useful for everyone. Publish some more article on it in future. Our institute PTI Academy also offer various IT courses and training for all IT students. For more info visit: https://www.ptiacademy.in/
Hey all, this is not technically a code review, but I wrote some notes with the objective of giving a high-level overview of the core concepts of the Phoenix framework for Elixir. I'm doing this as sort of a Feynman thing as I'm going through the Programming Phoenix >= 1.4 book, and I wanted to know if there are any concepts that I've misunderstood, misrepresent, or don't communicate well. Link: https://github.com/samuelludwig/elixir-practice/blob/master/prog_phx_gte1.4_programs/notes/chapter02.md
Hi guys! I want to ask if is there a better way to handle async code with a rest api using express+mongodb(without mongoose). I have the logic split in services/model/routes.
I'll add an example of the code for a rest endpoint just for clarity:
I'll add an example of the code for a rest endpoint just for clarity:
// service
export const getUserByUsername = username => new Promise(async function(resolve, reject) {
const userData = await dbgetUserByUsername(username);
const user = userModelFactory(userData);
if(validateUser(user)) {
resolve(user);
} else {
reject();
}
});//model
export const dbgetUserByUsername = username => getdb().collection('users').find({ username }).toArray((err, result) => (err || result));//route
router.get('/user/:username', handleasyncreq(req => getUserByUsername(req.params.username)
.then(result => ({ body: result }))
.catch(result => ({ body: result, status: 400 }))
));//handleasyncreq code
export function handleasyncreq(f) {
async function asynchandler(req, res) {
const { status = 200, headers = {}, body = {} } = await f(req);
res.status(status).set(headers).json(body);
}
return asynchandler;
}
I don't know if I'm doing promises/async right. I feel like I have to handle the async nature of MONGODB in two different places for just one operation - get a user by username -.
@abeledovictor I personally feel like the code you posted it too complex for its own good. Your mixing async/await with normal promises, your own async handler function, and new Promise, even tho you have async/await code.
For such a simple case, you should be fine with just the route, service and maybe the model. I also don't believe in using .then and .catch if your using async/await. It's more important to stay consistent than to do "one-liners" for the same of one-liners.
Great code is dirt easy to read and understand. Don't be clever/shorter just for the sake of it.
without getting to verbose (I'm to lazy to write out all your code hehe)
I would have this:
// route
router.get('/user/:username', (req, res) => {
try {
const {username} = req.params;
const user = await getUserByUsername(username);
res.send({status: 200, body: user});
} catch (err) {
res.send({body: err, status: 400});
}
});// getUserByUsername service
// NOTE: if your using async await, you automatically return promises from this function
export const getUserByUsername =(username) => {
const user = userModelFactory(dbGetUserByUsername(username)); // this function is the same
if (validateUser(user) {
return user;
}
throw Error();
}The dbGetUserByUsernamefunction is the same
@abeledovictor
I mainly threw out the async-handler, and the
new Promise code. I feel like using them saves you a few lines, but were like 1 or 2 lines here or there haha
and you will need the
await next to the dbGetUserByUsername call aswell hehe
let me know what you think of my personal portfolio.. still need to add form submission .. mostly interested in everyones opinion on the design and colors of the site.. i suck at design and am working on it.
https://gracious-torvalds-39f1c5.netlify.com
https://gracious-torvalds-39f1c5.netlify.com
menu texts are dancing while hovering over
Paradox Framework - Please review and suggest any improvements. - https://emilo9.github.io/Paradox-CSS-Framework-Alpha/Paradox_Example.html
Managing Packages with Npm
Someone help me please
And always send the full page view 🤹