Give and receive constructive feedback from your fellow campers on Algorithm Challenge solutions, Frontend and Backend projects
@abeledovictor I personally feel like the code you posted it too complex for its own good. Your mixing async/await with normal promises, your own async handler function, and new Promise, even tho you have async/await code.
For such a simple case, you should be fine with just the route, service and maybe the model. I also don't believe in using .then and .catch if your using async/await. It's more important to stay consistent than to do "one-liners" for the same of one-liners.
Great code is dirt easy to read and understand. Don't be clever/shorter just for the sake of it.
without getting to verbose (I'm to lazy to write out all your code hehe)
I would have this:
// route
router.get('/user/:username', (req, res) => {
try {
const {username} = req.params;
const user = await getUserByUsername(username);
res.send({status: 200, body: user});
} catch (err) {
res.send({body: err, status: 400});
}
});// getUserByUsername service
// NOTE: if your using async await, you automatically return promises from this function
export const getUserByUsername =(username) => {
const user = userModelFactory(dbGetUserByUsername(username)); // this function is the same
if (validateUser(user) {
return user;
}
throw Error();
}The dbGetUserByUsernamefunction is the same
new Promise code. I feel like using them saves you a few lines, but were like 1 or 2 lines here or there haha
await next to the dbGetUserByUsername call aswell hehe
https://gracious-torvalds-39f1c5.netlify.com
Sometimes, it becomes necessary to take advice from the professionals who will help you out by resolving the whole host of your problems. What you need to do is to visit the official website of cash app and then move to Cash App Help section at anytime from anywhere.
https://www.gonetech.net/cash-app-customer-service/
Do you really want to add up extra security over your cash app account? Are you also looking for the help to avoid breaking security? For the reason itself, you should get the complete information along with the proper supervision from customer care experts by using Cash App Number at anytime.
https://www.gonetech.net/square-cash-app-hacked/
