These are chat archives for FreeCodeCamp/HelpFrontEnd

14th
Sep 2017
korzo
@korzo
Sep 14 2017 00:10

@sansae That's not actually true. It's because how javascript works. Juvascript runs event loop (async functions) after main script exits

Yes, it's because your forEach finishes before the data comes back from the glitch.me server. Javascript runs faster than the internet :)

Yan Kozlovskiy
@YanKozlovskiy
Sep 14 2017 00:10
where do we help non profits?
korzo
@korzo
Sep 14 2017 00:11
@piteto If you put infinite loop in main script like while(true) {} ajax never fire
Daniel Feldman
@Feldbot
Sep 14 2017 00:27
@YanKozlovskiy I think FCC changed their policy so now you can contribute to their https://www.freecodecamp.org/nonprofits/ non-profit projects at any time.
piteto
@piteto
Sep 14 2017 00:34
The request goes out, but yes, as you point out, the callback doesn't run until there is a network response
korzo
@korzo
Sep 14 2017 00:35
@piteto No
First Ajax is run after main script exists
As I said, put infinite loop at the end of main script and ajax request never fire
piteto
@piteto
Sep 14 2017 00:41
@korzo Okay, so you're saying the forEach doesn't finish before the data comes back from the server
korzo
@korzo
Sep 14 2017 00:41
@piteto No
foreach finish.
whole script finish
ajax run
Engjell Bislimi
@Engjell00
Sep 14 2017 00:42
Does anyone knows why my footer and header aren't at the 100% width?
korzo
@korzo
Sep 14 2017 00:43
@piteto Not inside foreach. In the javascript box at the end.
@piteto Take a look at this https://repl.it/LEOb
piteto
@piteto
Sep 14 2017 00:43
@korzo Right, I thought you were saying I was incorrect when I said " it's because your forEach finishes before the data comes back from the glitch.me server"
The for each finishes, then we get the data. I wasn't commenting on order of execution, rather order of results from execution
@Engjell00 Your footer and header are 100% of their parent elements. Your footer is wider because it is outside of your <body> tag
Engjell Bislimi
@Engjell00
Sep 14 2017 00:46
@piteto to me it doesnt seem to take all the gray space why?
I dont want it to be in the center like the content!
korzo
@korzo
Sep 14 2017 00:46
@piteto Oh, well, then it's race condition. All ajax requests from foreach fire at the same time(almost).
piteto
@piteto
Sep 14 2017 00:47
@Engjell00 That's how % works in CSS - it means the percentage of the parent element. If you want it to take up the entire width of the screen, use 100vw
@korzo How can we have a race condition in single-threaded JS?
I hadn't ever thought of that before with JS
korzo
@korzo
Sep 14 2017 00:50
@piteto Because all async function are put in event loop.
After main script is done, javascript starts with event loop: first ajax run, second ajax, third ajax... and then javascript wait for response.
responses are processed in order they return
So if last ajax call is fastest, response processed first
piteto
@piteto
Sep 14 2017 00:52
Ah, okay, that makes sense. I was thinking more of threads getting deadlocked. Another "race condition" could also be running code before the DOM is ready
(code that depends on the DOM)
Mike
@mikeytsou
Sep 14 2017 01:12
Hi, is there anyone with a lot of experience with JavaScript and JSON who can help me out with a problem?
korzo
@korzo
Sep 14 2017 01:14
It's better to post your problem
林欣荣
@golovefree24
Sep 14 2017 01:30
please,how to add exteral images in codepen?
korzo
@korzo
Sep 14 2017 01:32
@golovefree24 Use github, dropbox, GDrive or http://cloudinary.com/
林欣荣
@golovefree24
Sep 14 2017 01:33
oh,thanks,let me try @korzo
Miguel T Rivera
@mtrivera
Sep 14 2017 01:59
Can anyone tell me why the color doesn't change when I click the button?
https://codepen.io/mtrivera/pen/WZbOGd
Mike
@mikeytsou
Sep 14 2017 02:08
@korzo thanks for the tip man. So I'm trying to build a purchase form with json data. there are three dropdown menus and the second dropdown menu will display different data from the json depending on the selection on the first dropdown menu. have trouble with this.
CamperBot
@camperbot
Sep 14 2017 02:08
mikeytsou sends brownie points to @korzo :sparkles: :thumbsup: :sparkles:
:cookie: 484 | @korzo |http://www.freecodecamp.com/korzo
Mike
@mikeytsou
Sep 14 2017 02:11
help from anyone is greatly appreciated
korzo
@korzo
Sep 14 2017 02:12
@mtrivera Because backgroundColor is in rgb() format
@mikeytsou Post your code on codepen or github, if it's possible.
Generally, you listen for for change event on select and the set options for next select either from ajax request or from data already obtained
Mike
@mikeytsou
Sep 14 2017 02:18
@korzo would you possibly be able to get on a hangout with me?
korzo
@korzo
Sep 14 2017 02:21
@mikeytsou sure
Mike
@mikeytsou
Sep 14 2017 02:21
@korzo awesome ill private msg you
Jake
@JakeDVirus
Sep 14 2017 07:23
can anyone help me figure out why my statement in line-73 is not working but the statement in line-67 do work(which is commented out in the code to work on line-73).
The context is about $(abc).appendTo() method, which on line-67(working) the abcis individual element while on line-73(not working) the abc is an array of elements.
https://codepen.io/neel111/pen/oeKGJL?editors=0011
Ken Haduch
@khaduch
Sep 14 2017 08:15
@NeelDVirus - I tried to take a look but am limited because I'm on a mobile phone so I cannot scroll down to see the code in question. I'll try to look in a couple hours when I can get to the computer, if you are still stuck.
Jake
@JakeDVirus
Sep 14 2017 08:17
@khaduch yeah sure that will be very kind of you. i am off from coding now for an hour. if i get it done i will drop a post about it here
Jan
@pungiish
Sep 14 2017 10:15
Sup
Maria Theresa Arruda
@arrudamt
Sep 14 2017 11:06
hello guys!
can anyone help me with something? why when i set the color background on the body tag nothing happen?
heroiczero
@heroiczero
Sep 14 2017 11:07
@arrudamt could you link your code or codepen
@heroiczero i'm just trying some stuff that i'm learning, but this tag didnt respond
Maria Theresa Arruda
@arrudamt
Sep 14 2017 11:15
@heroiczero ok, thanks
CamperBot
@camperbot
Sep 14 2017 11:15
arrudamt sends brownie points to @heroiczero :sparkles: :thumbsup: :sparkles:
:star2: 1728 | @heroiczero |http://www.freecodecamp.com/heroiczero
Fabien SHAN
@X140hu4
Sep 14 2017 11:25
@arrudamt Your container is taking all the available space
Fabien SHAN
@X140hu4
Sep 14 2017 11:31
Also the stylesheet you link to in the HTML overwrites the background you would set in the css
If you open it you will see that it gives body a background-color of #fff (white)
Ken Haduch
@khaduch
Sep 14 2017 14:13
@NeelDVirus - your code on line 73 is only going to be invoked if there is an error in your ajax request - are you seeing errors in the second section of code? It might be that you have some errors that happen when you are trying to fetch details of user data, but no errors in the original request?
Ken Haduch
@khaduch
Sep 14 2017 14:46
@NeelDVirus - yes, I think that what is happening is that your original request for information is not returning any kind of error, but you are coming up with a list of user names, and one of them has an illegal name, at least as far as the use of that name in the API to request additional information, so that is returning an error, you can see it in the console (the devtools console) it might be the name with the Chinese (or something that looks like Chinese) characters. So when you try to pass that into the API for user details, it returns an error. So the original request is processed without error, you will never trigger the the error code that you are concerned with.
@NeelDVirus - you might want to use the name instead of display_name
Ken Haduch
@khaduch
Sep 14 2017 14:51
unless you want to see an error?
Peter Steele
@PeterHSteele
Sep 14 2017 15:04
hey guys, i have a function on line 11 called makeSquareLive which is supposed to turn a square red when clicked. instead it turns the whole column red and I'm not sure why
https://codepen.io/psteele1128/pen/NaWQwZ?editors=0110
piteto
@piteto
Sep 14 2017 15:17
@PeterHSteele Use this to generate your array: Array(10).fill(false).map(v => Array(10).fill(v))
If you console.log your current array generated with Array(10).fill(Array(10).fill(false)) it contains circular references
Peter Steele
@PeterHSteele
Sep 14 2017 15:20
@piteto thank you very much
CamperBot
@camperbot
Sep 14 2017 15:20
peterhsteele sends brownie points to @piteto :sparkles: :thumbsup: :sparkles:
:cookie: 104 | @piteto |http://www.freecodecamp.com/piteto
Koderkid1936
@Koderkid1936
Sep 14 2017 15:37
Hey I just finished my first responsive website and would love some feedback /criticism thanks in advance :) https://codepen.io/Mr_Evers/pen/XeJQON
Peter Steele
@PeterHSteele
Sep 14 2017 15:48
@Koderkid1936 i got nothing to criticize, looks really solid. i like the shadow effect on the bottom of your sections. very nice touch
Koderkid1936
@Koderkid1936
Sep 14 2017 15:52
@PeterHSteele thanks but sorry to disappoint the design isn't mine :P its from W3Schools: http://bit.ly/2xzVd1o I was thinking more of the code itself, if I needed to improve and how I coded the web, I wrote the HTML and CSS myself by looking at the site only so have you got any feedback on that ?
CamperBot
@camperbot
Sep 14 2017 15:52
koderkid1936 sends brownie points to @peterhsteele :sparkles: :thumbsup: :sparkles:
:cookie: 322 | @peterhsteele |http://www.freecodecamp.com/peterhsteele
Roxroy
@roxroy
Sep 14 2017 16:00
@Koderkid1936 , you made good use of html, css and bootstrap classes. Nice use of aside and section tags to provide declarative areas.
piteto
@piteto
Sep 14 2017 16:01

@Koderkid1936 The CSS has a couple of invalid settings, like:

#buttonWrapper{
    max-height: width: 20%;
    ....
}

And:

.buttonClass{
    max-height: width: 35.22%;
    ....
}
Koderkid1936
@Koderkid1936
Sep 14 2017 16:01
@roxroy theres no bootstrap tho :worried: and thanks any crticism tho I'm looking for that too
CamperBot
@camperbot
Sep 14 2017 16:01
koderkid1936 sends brownie points to @roxroy :sparkles: :thumbsup: :sparkles:
:star2: 1141 | @roxroy |http://www.freecodecamp.com/roxroy
piteto
@piteto
Sep 14 2017 16:01
I'm not familiar with w3.css, so can't comment on your use of that
Koderkid1936
@Koderkid1936
Sep 14 2017 16:01
@piteto can you elaborate, invalid settings?
piteto
@piteto
Sep 14 2017 16:02
You can have a height or a width, but a height can't have a width
Koderkid1936
@Koderkid1936
Sep 14 2017 16:02
oooooooh I didn't notice that thanks haha :D
piteto
@piteto
Sep 14 2017 16:02
no problem
:)
Minor point - but usually you want one <h1> element in a page and your CSS shouldn't modify the default h2 and h1 elements - use a class like ".section-title" instead
Peter Steele
@PeterHSteele
Sep 14 2017 16:12
@piteto @Koderkid1936 I was wondering about the multiple h1s too because I was taught never to do that. But I found this mdn article saying its ok for each section to have its own heading hierarchy, which I never knew https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Using_HTML_sections_and_outlines#Defining_sections.
piteto
@piteto
Sep 14 2017 16:15
It's valid HTML as far as I understand, but I learned it was a general best practice for SEO. I could be wrong - it's been a few years since I did wordpress development and looked at all those Yoast messages :p
Koderkid1936
@Koderkid1936
Sep 14 2017 16:16
@PeterHSteele yeah I was a bit hesitant having that in my css since it goes against the 'DRY' and thought there may be a more efficient way of doing it but I'm new to this and I couldnt come up with a better way, also partly because I became lazy 3/4 of the way through making this site but thanks I'll have a look at the article :+1:
CamperBot
@camperbot
Sep 14 2017 16:16
koderkid1936 sends brownie points to @peterhsteele :sparkles: :thumbsup: :sparkles:
api offline
Koderkid1936
@Koderkid1936
Sep 14 2017 16:17
@piteto so... the multiple h1's are bad for SEO?
piteto
@piteto
Sep 14 2017 16:20
@Koderkid1936 Traditionally, that has been the case. It depends on how they are used, as I think the search engines have gotten smarter - with the help of HTML5
Looks like the current guidance is to use semantic tags, like <section>, <article>, <aside> and limit one h1 tag in each of those.
(so with that info, your HTML is fine :) ignore my comment)
Koderkid1936
@Koderkid1936
Sep 14 2017 16:24
@piteto I've been trying to use the HTML5 semantic tags more and more now the whole "try to use one h1 tag in each of HTML5 tags like <section>, <aside>, <article>" is new to me thanks for thatt I will definitely keep that in min
CamperBot
@camperbot
Sep 14 2017 16:24
koderkid1936 sends brownie points to @piteto :sparkles: :thumbsup: :sparkles:
:cookie: 106 | @piteto |http://www.freecodecamp.com/piteto
Koderkid1936
@Koderkid1936
Sep 14 2017 16:24
mind*
hifede
@hifede
Sep 14 2017 18:08
hi there! ive been trying to put all my rows in containers in order to make my page mobile-friendly. but as a result, my contact form and the elements in my navbar all moved to the right. could you please help me figure out how to align them back to the left ? https://codepen.io/arolf_flora/pen/WEoYmd
and it's still not working well on mobile either :/
Sue
@coding-sue-true
Sep 14 2017 18:23
angular lists, anyone?
Koderkid1936
@Koderkid1936
Sep 14 2017 18:36
@hifede make it spread across 12 rows instead of 3? then give it equal margins to the left and right? so 4 rows on each side?
@hifede also why not use media queries if you wanted to make it mobile friendly its easier that way?
Kent Saeteurn
@sansae
Sep 14 2017 18:39
@piteto Thank you so much for the help, piteto. Your suggestion worked perfectly :)
CamperBot
@camperbot
Sep 14 2017 18:39
sansae sends brownie points to @piteto :sparkles: :thumbsup: :sparkles:
:cookie: 107 | @piteto |http://www.freecodecamp.com/piteto
Jake
@JakeDVirus
Sep 14 2017 18:40

there is an unsual behaviour. i am working on twitch.tv challenge. my project seems all fine but if the username of the online streamer is clicked (it will redirect to the twitch.tv app) then in the console there pops out a too long list of same error indicating.

Uncaught TypeError: event.data.indexOf is not a function
at receiveMessage (scriptTagContext.js:122)"

https://codepen.io/neel111/pen/oeKGJL?editors=1111
i dont know about codepen console, i was debugging in browser console after changing the view to "debug mode" in codepen and it was shown there.
shall i be concerned with those error? i am being blunt here

Kent Saeteurn
@sansae
Sep 14 2017 18:41
@korzo > foreach finish. whole script finish. ajax run
Thank you so much for the explanation korzo.
CamperBot
@camperbot
Sep 14 2017 18:41
sansae sends brownie points to @korzo :sparkles: :thumbsup: :sparkles:
:cookie: 486 | @korzo |http://www.freecodecamp.com/korzo
Jake
@JakeDVirus
Sep 14 2017 18:43
@khaduch Thank you sir for your concern. That quirk is being fixed and i mentioned in my succeding post, it dint crossed my mind that you might miss out and by mistake i dint tagged you.
Btw there is another quirk where i am getting no lead for debugging. The quirk is mentioned in my above post
BrianWilliams28
@BrianWilliams28
Sep 14 2017 18:43
Can someone help? I am working on the telephone number algorithm and i've hit a road block. my code is below...
function telephoneCheck(str) {
  str = str.replace(/\s/g, '');
   // check if string has 10 or 11 numbers
  let match = str.match(/\d/g);
  let bracketMatch = str.match(/[()]/g);
  let dashMatch = str.match(/-/g);
  let numTest = /\d{10}/g.test(str);
  console.log(bracketMatch.length);
  // generating regex to check for appropriate number patterns
  let dash = /\b-/g;
  let areaCode = /\([0-9]{3}\)/g;
// 1st check to see if the number is simply 10 digits without any spaces or brackets, if so returns true
  if (match.length === 10 && numTest) {
    return true;
// 2nd check to see if the number contains a "(", if so it matches "()" with any 3 numbers in it and returns true if there are only two brackets in the string
  } else if (match.length === 10 && bracketMatch.length === 2) {
    // if there are no brackets the code returns an error because it can't read a null length?!
    if (areaCode.test(str)) {
      return true;
    }
  } else if (match.length === 10 && dashMatch.length <= 3) {
    if (dash.test(str)) {
      return true;
    }
  }
  return false;
}
console.log(telephoneCheck("(555)555-5555")); // works
telephoneCheck("555-555-5555"); // doesn't work
apologies its long and kinda messy, but basically it's telling me that if the string doesn't contain a bracket match it returns an error and stops working. but i don't understand why this stops the next else if statement from executing?
Ken Haduch
@khaduch
Sep 14 2017 18:53
@NeelDVirus - there is a problem, as i've seen, when you try to load a user's page when clicking from within the CodePen API interface, that it blocks the opening of the users data in the other window. If you run it in the COdePen "debug" view, I think that it works? I don't know if there is a way to overcome the problem from the CodePen full page view, but maybe someone else has figured that out? Maybe a stackoverflow question has an answer?
Jake
@JakeDVirus
Sep 14 2017 18:59
@khaduch oh yeah i have just noticed that if i try to load user's page from Codepen main page(not debug) then user's page seems to be blocked(loading do start but not get finsihed and keeps loading), but if i do the same in the DEBUG mode then the user's page do work well. Is that what you meant by "it blocks the opening of the users data in the other window"?
actually i was not using codepen console for debuggin and so i couldn't noticed that difference
Ken Haduch
@khaduch
Sep 14 2017 19:09
@NeelDVirus - yes - the new tab opens when you click the name, but the page never loads (when using the CodePen "full" view.) There is something about an iframe being "sandboxed" - apparently there is no way to overcome that, from what I've seen on a couple pages that I opened? like this page and this page
Jake
@JakeDVirus
Sep 14 2017 19:13
@khaduch well i have no knowledge of sandboxed and just a little 0.1% knowledge of iframe.
just a curiosity for a little knowledge, is this "iframe being sandboxed" issue exist in the codepen or in the twitch.tv?
BrianWilliams28
@BrianWilliams28
Sep 14 2017 19:55
no one wants to help with my disgusting algorithm? :(
Jan Shah
@JanShah
Sep 14 2017 20:03
@BrianWilliams28 have you tried using regex?
for the full number
Saikat-Sinha
@Saikat-Sinha
Sep 14 2017 20:13
How to replace one HTML tag with another?
for example in this case, I am trying to replace <blank></blank> with <span></span> but it replaces only <blank> with <span> but not </blank> causing issues
function replaceHTML(text) {

 var beginRegExp = /<blank(?:\s+\w+(?:\s*=\s*(?:(?:"[^"]*")|(?:'[^']*')|[^>\s]+))?)*\s*\/?>/gm

var endRegExp = /<\/blank>/gm

if(text === false){
          return ' '
        }

 else{
            return String(text).replace(beginRegExp, '<span>') 
        }
      }
piteto
@piteto
Sep 14 2017 20:27
@Saikat-Sinha It's usually not a good idea to use regex for HTML. You can do this to replace <blank></blank> with <span></span>:
var blank = document.getElementsByTagName('blank');
[...blank].forEach(el => {
  el.outerHTML = '<span>' + el.innerHTML + '</span>'
});
Saikat-Sinha
@Saikat-Sinha
Sep 14 2017 20:31
Thanks @piteto .......can u show me without ES6, i m not using babel
CamperBot
@camperbot
Sep 14 2017 20:31
saikat-sinha sends brownie points to @piteto :sparkles: :thumbsup: :sparkles:
:cookie: 108 | @piteto |http://www.freecodecamp.com/piteto
piteto
@piteto
Sep 14 2017 20:32
@Saikat-Sinha
var blank = document.getElementsByTagName('blank');
for(var i = 0; i < blank.length; i++) {
  blank[i].outerHTML = '<span>' + blank[i].innerHTML + '</span>'
}
Saikat-Sinha
@Saikat-Sinha
Sep 14 2017 20:33
@piteto u r great
piteto
@piteto
Sep 14 2017 20:33
There are a few other ways to do it - lots of examples on stack overflow if you're curious
replaceChild(), for example
Saikat-Sinha
@Saikat-Sinha
Sep 14 2017 20:34
I m working with angular 1.x.x , this one will do the job @piteto
Engjell Bislimi
@Engjell00
Sep 14 2017 21:32
Hello does anyone can tell me why my text is being in the opacity too? https://codepen.io/EngjellBislimi/pen/RLPWdp

https://developer.mozilla.org/fr/docs/Web/CSS/opacity

La valeur s'applique à l'ensemble de l'élément et à ce qu'il contient même si la valeur n'est pas héritée par les éléments fils.

Ken Haduch
@khaduch
Sep 14 2017 21:51
@NeelDVirus - I think that it is the CodePen side that is sandboxed - the error message reads like this: Failed to load '' as a plugin, because the frame into which the plugin is loading is sandboxed. CodePen definitely uses an iframe when you are running in the editor or full page mode, not in the debug mode. So the solution, I think, is to set up the project in a separate area, like github pages, where you are not running in the codepen interface.
@BrianWilliams28 - you can write one regular expression - one line of code solves it...
Koderkid1936
@Koderkid1936
Sep 14 2017 22:01
Okay guys this the second responsive site I did today, is there anything you feel I'm lacking could I have done anything better? feedback/crticism would be much appreciated thanks a lot :D https://codepen.io/Mr_Evers/pen/xXGZgO
Moisés Man
@moigithub
Sep 14 2017 22:16
some accesibility UX rule says max width per text should be between 50 to 80 characters per line
Engjell Bislimi
@Engjell00
Sep 14 2017 22:51
my UL list isn't inline with my text on the white container? why? https://codepen.io/EngjellBislimi/pen/RLPWdp
Chase
@hmmChase
Sep 14 2017 22:58
if i have a paragraph of text, but I don't want line breaks around it, should i use a <span>, or should use a <p> and then style it display:inline ?
Tom
@moT01
Sep 14 2017 22:59
@Engjell00 what is your goal there?
Engjell Bislimi
@Engjell00
Sep 14 2017 23:00
@moT01 http://www.csszengarden.com/ i'm trying to do the same page! As you can see at the right of the first Content there is some link and I would like to put there the same way!
should I make a new container for all the right side?
Tom
@moT01
Sep 14 2017 23:01
that's probly how i would do it
you used float, im not a fan
Engjell Bislimi
@Engjell00
Sep 14 2017 23:02
so i make a new container and put the width that remain open?
Tom
@moT01
Sep 14 2017 23:02
i would probly make two elements, wrapped in a parent...
<div> //block
  <div></div> //inline
  <div> //inline
    <ul> //margin-left
  </div>
</div>
Ken Haduch
@khaduch
Sep 14 2017 23:04
@BrianWilliams28 - you can handle all of the conditional cases within the regex expression.
Engjell Bislimi
@Engjell00
Sep 14 2017 23:04
what is the //block ,inline margin..? I never saw this
Tom
@moT01
Sep 14 2017 23:04
yea, you could define a width for that left one
thats how you get things the way you want them
its css (styling)
you lay out your html elements, then style them with it
not exactly like i put there, that was just for show
its different syntax
Engjell Bislimi
@Engjell00
Sep 14 2017 23:06
oh so you mean you put the html and what you'll put in their css element?
@moT01 thank you!
CamperBot
@camperbot
Sep 14 2017 23:06
engjell00 sends brownie points to @mot01 :sparkles: :thumbsup: :sparkles:
:cookie: 855 | @mot01 |http://www.freecodecamp.com/mot01
Tom
@moT01
Sep 14 2017 23:07
yea, you are using all sorts of css in your pen, so you know... that was just for an explanation
i think that will work anyway
Engjell Bislimi
@Engjell00
Sep 14 2017 23:07
is it bad that i'm using different sorts?
Tom
@moT01
Sep 14 2017 23:08
everyone has different ways to do things
lots of way to get it done
what you should do is clean up the code in the css
the random line breaks and misaligned stuff
Engjell Bislimi
@Engjell00
Sep 14 2017 23:10
@moT01 oh good idea thank you
CamperBot
@camperbot
Sep 14 2017 23:10
engjell00 sends brownie points to @mot01 :sparkles: :thumbsup: :sparkles:
api offline
Tom
@moT01
Sep 14 2017 23:10
@hmmChase get it figured out?
Engjell Bislimi
@Engjell00
Sep 14 2017 23:12
@moT01 you wrote margin-left so I guess I put it at 0?
Chase
@hmmChase
Sep 14 2017 23:16
@moT01 yeah, i should use a <p> with display: inline to keep the semantics, whatever that is worth. But also it raises more questions for me about when to NOT use a <p>
Tom
@moT01
Sep 14 2017 23:17
@Engjell00 i meant to put it at more than 0
you might want margin elsewhere - like the top as well
but keep the text aligned left (will be by default) - and add a margin on the left- or maybe a padding
probly a padding
Engjell Bislimi
@Engjell00
Sep 14 2017 23:18
@moT01 where should I place all this div? after the first container? If I do that the second container is all messed up
Tom
@moT01
Sep 14 2017 23:19
@hmmChase im not sure on best practice there
but i dont think it really matters too much in that case, as long as you get the result you want
Chase
@hmmChase
Sep 14 2017 23:26
a good rule I found: "the <span> and <div> elements are used where parts of a document cannot be semantically described by other HTML elements"
Engjell Bislimi
@Engjell00
Sep 14 2017 23:39
Any way I can increase the size of my icons?
If I do font-size it only looks like me padding is pushing in all the ways